Skip to content

Version: 1906141418310

Baseline: 1906131851520

  • 🐛Make handling of history state responses more robust. (#22546)

Breakdown by component

Assets 2

Version: 1906131851520

Baseline: 1906051812580

  • Linker: fix handling of fragments (#22753)

Breakdown by component

Assets 2
Pre-release
Pre-release

@ampprojectbot ampprojectbot released this Jun 13, 2019

Version: 1906111828200

Baseline: 1906042041510

  • Remove several getServiceForDoc() in extensions/* (#22511)
  • Linker: fix handling of fragments (#22753)
  • Move core service installation into core-services.js for easier refactoring (#22732)
  • Include child margin-bottom in content height (#22718)
  • Added Strossle to AMP solutions (#22615)
  • Adding 'allow-popups' to the consent prompt UI iframe (#22760)
  • 📖 Update testing documentation (#22762)
  • 🏗 Create gulp a4a and refactor unit/integration/a4a (#22717)
  • Integrate amp-form-dirty into AMP form (#22709)
  • amp-list-load-more validator rules change (#22702)
  • Rename reported test status from local_changes to local-changes (#22761)
  • Update story viewport size styles in prerender. (#22754)
  • Add explanatory comment (#22728)
  • Cleanup amp-autocomplete experiment. (#22708)
  • Fix amp-sidebar scrolling on open/close in UIWebView (#22738)
  • ♻️ Analytics and variable service refactoring (#22729)
  • 🐛Fix zucks ad return timing (#22719)
  • 📖amp-consent: Add Didomi CMP documentation + example (rebase) (#22730)
  • Add OT link in amp-script documentation (#22464)
  • Making sure the consent UI AMP element is upgraded before calling whenBuilt. (#22724)
  • Use css.js for autoplay styles (#22713)
  • Bypass xhr interceptor for amp-worker invocation (#22600)
  • 🐛Make handling of history state responses more robust. (#22546)
  • Install Timer service directly instead of adopting (#22604)
  • Remove AMP-Access-Control-Allow-Source-Origin from test server (#22645)
  • 🐛amp-brightcove: Redispatch loadedmetadata event (#22720)
  • Analytics trigger when opening/closing the story page attachment. (#22710)
  • Make sure SR reads index of list options in amp-autocomplete (#22649)
  • Linker: change default behavior to decorate all subdomains (if can be found) (#22712)
  • Validator rollup (#22687)
  • Move private amp-accordion CSS into the extension (#22660)
  • Remove verification of the AMP-Access-Control-Allow-Source-Origin (#22630)
  • Add remaining chai properties and refactor (#22707)
  • FEATURE: record form field's submitted value (#22671)
  • amp-ad doubleclick SRA - combine common key/values into single parameter (#22695)
  • 🐛Fix broken cookie writer test (#22696)
  • amp-subscriptions-google "smartbox" support (#22670)
  • Override global scrollY/pageYOffset in iOS embed cases (#22657)

Breakdown by component

ads Added Strossle to AMP solutions (#22615) 🐛Fix zucks ad return timing (#22719)
amp-a4a Remove verification of the AMP-Access-Control-Allow-Source-Origin (#22630)
amp-access Validator rollup (#22687) Remove verification of the AMP-Access-Control-Allow-Source-Origin (#22630)
amp-accordion Make sure SR reads index of list options in amp-autocomplete (#22649) Validator rollup (#22687) Move private amp-accordion CSS into the extension (#22660)
amp-ad Added Strossle to AMP solutions (#22615)
amp-ad-exit Validator rollup (#22687)
amp-ad-network-doubleclick-impl amp-ad doubleclick SRA - combine common key/values into single parameter (#22695)
amp-addthis Change Addthis teaser metadata (#22646)
amp-analytics Linker: fix handling of fragments (#22753) Linker: change default behavior to decorate all subdomains (if can be found) (#22712) Validator rollup (#22687) Remove verification of the AMP-Access-Control-Allow-Source-Origin (#22630) Removes uses of "AMP Project" (#22622) 🐛Fix broken cookie writer test (#22696)
amp-anim Validator rollup (#22687)
amp-animation Validator rollup (#22687)
amp-apester-media Remove verification of the AMP-Access-Control-Allow-Source-Origin (#22630)
amp-app-banner Remove verification of the AMP-Access-Control-Allow-Source-Origin (#22630)
amp-auto-ads Remove verification of the AMP-Access-Control-Allow-Source-Origin (#22630)
amp-autocomplete Cleanup `amp-autocomplete` experiment. (#22708) Make sure SR reads index of list options in amp-autocomplete (#22649) Validator rollup (#22687) 📖 Add frontmatter key to experimental components (#22669)
amp-base-carousel 📖 Add frontmatter key to experimental components (#22669)
amp-bind Validator rollup (#22687)
amp-brightcove 🐛amp-brightcove: Redispatch loadedmetadata event (#22720)
amp-carousel Validator rollup (#22687)
amp-consent Adding 'allow-popups' to the consent prompt UI iframe (#22760) 📖amp-consent: Add Didomi CMP documentation + example (rebase) (#22730) Making sure the consent UI AMP element is upgraded before calling whenBuilt. (#22724) Validator rollup (#22687) Remove verification of the AMP-Access-Control-Allow-Source-Origin (#22630)
amp-experiment Validator rollup (#22687)
amp-form Integrate `amp-form-dirty` into AMP form (#22709) Remove verification of the AMP-Access-Control-Allow-Source-Origin (#22630) FEATURE: record form field's submitted value (#22671)
amp-geo Validator rollup (#22687) Removes uses of "AMP Project" (#22622)
amp-google-vrview-image 📖 Add frontmatter key to experimental components (#22669)
amp-link-rewriter Validator rollup (#22687)
amp-list amp-list-load-more validator rules change (#22702) Validator rollup (#22687) Remove verification of the AMP-Access-Control-Allow-Source-Origin (#22630)
amp-live-list Remove verification of the AMP-Access-Control-Allow-Source-Origin (#22630)
amp-mustache Validator rollup (#22687)
amp-next-page Remove verification of the AMP-Access-Control-Allow-Source-Origin (#22630) 📖 Add frontmatter key to experimental components (#22669)
amp-pan-zoom 📖 Add frontmatter key to experimental components (#22669)
amp-payment-google-button Validator rollup (#22687)
amp-payment-google-inline Validator rollup (#22687)
amp-payment-google-inline-async Validator rollup (#22687)
amp-pinterest Remove verification of the AMP-Access-Control-Allow-Source-Origin (#22630)
amp-script 📖 Add frontmatter key to experimental components (#22669)
amp-sidebar Fix amp-sidebar scrolling on open/close in UIWebView (#22738)
amp-story Update story viewport size styles in prerender. (#22754) ♻️ Analytics and variable service refactoring (#22729) Analytics trigger when opening/closing the story page attachment. (#22710) Validator rollup (#22687) Remove verification of the AMP-Access-Control-Allow-Source-Origin (#22630)
amp-story-auto-ads Validator rollup (#22687)
amp-subscriptions Validator rollup (#22687)
amp-subscriptions-google amp-subscriptions-google "smartbox" support (#22670)
amp-truncate-text 📖 Add frontmatter key to experimental components (#22669)
amp-user-location Validator rollup (#22687) 📖 Add frontmatter key to experimental components (#22669)
amp-user-notification Remove verification of the AMP-Access-Control-Allow-Source-Origin (#22630)
amp-viewer-assistance Validator rollup (#22687)
amp-viz-vega Remove verification of the AMP-Access-Control-Allow-Source-Origin (#22630) 📖 Add frontmatter key to experimental components (#22669)
validator amp-list-load-more validator rules change (#22702) Fixes #22666 Validator rollup (#22687)

amp-subscriptions-google "smartbox" support (#22670)

Preliminary smartbox support, doc to follow when experimat flag is removed from swg.js

Assets 2

Version: 1906051812580

Baseline: 1905292322390

  • Squash commits for: tap to next/previous Story. (#22684)
  • Viewer messaging to select the next/previous document. (#22684)
  • Add second visual test for amp-autocomplete (#22047)
  • ♻️Cleanup e2e test endpoints and remove unused screenshot calls (#22674)
  • Add custom cookie expiration (#22483)

Breakdown by component

amp-analytics Add custom cookie expiration (#22483)
amp-base-carousel ♻️Cleanup e2e test endpoints and remove unused screenshot calls (#22674)
amp-form ♻️Cleanup e2e test endpoints and remove unused screenshot calls (#22674)
amp-list ♻️Cleanup e2e test endpoints and remove unused screenshot calls (#22674)
amp-story Viewer messaging to select the next/previous document. (#22684)
Assets 2

@ampprojectbot ampprojectbot released this Jun 4, 2019

Version: 1906042041510

Baseline: 1905292322390

  • Viewer messaging to select the next/previous document. (#22684)
  • Add second visual test for amp-autocomplete (#22047)
  • ♻️Cleanup e2e test endpoints and remove unused screenshot calls (#22674)
  • Add custom cookie expiration (#22483)
  • 🏗 Create gulp integration (#22673)
  • Remove special casing for tests from amp-mustache extension registration (#22598)
  • Adds refs for amp-twitter (#21508)
  • add browsers option to e2e task (#22471)
  • Adds generator for JSON version of the validator spec (#22528)
  • getHighestAvailableDomain helper method (#22510)
  • 🐛 Fix sauce (#22680)
  • 🐛Fix broken args in expander. (#22508)
  • ♻️ Replace usage of pagesCount with page_ids.length (#22655)
  • FEATURE: AMP form dirtiness indicator class (#22640)
  • amp-experiment 1.0: Allow an #amp-x_disable_all_experiments_ to disable all experiments (#22419)
  • 🏗♻️ Refactor / clean up the watch logic used for extensions (#22659)
  • 🏗 Create gulp unit (#22606)
  • 🚮Remove autosuggest examples and assets (#22653)
  • 🏗 Fix code coverage logging on Travis (#22634)
  • Attachment theme validation. (#22643)
  • Remove onBodyAvailable from doc-state service. Start deprecation. (#22580)
  • Replacing story attachment data-dark-mode with theme. (#22642)
  • Handling the lifecycle of AMP components within an attachment. (#22603)
  • Adding a label for the "line" share provider. (#22639)
  • 🐛amp-call-tracking: Made the 'phoneNumber' field optional (#22613)
  • 🏗♻️ Refactor and speed up unminified builds (#22635)
  • Add services to overridekeys for addthis (#22588)
  • 🐛 Fix .codecov.yaml (#22633)
  • Move shared CSS from ampdoc.css to ampelement.css (#22494)
  • Pure renaming PR: ampelement.css -> ampshared.css (#22628)
  • Include userActivation in the 3p iframe postMessage (#22627)
  • Add trailing newlines to validator files. (#22625)
  • Validator Rollup (#22620)
  • 🏗 Consolidate AMP's code coverage PR statuses (#22567)
  • Add isFieldEmpty helper (#22584)
  • 🐛 Copy sourcemap file for aliased bundles (#22605)
  • 🐛 Fixed spelling inconsistency in extensions/amp-animation/0.1/css-expr-impl.js (#22590)
  • 🐛 Enable type checking for 3p/environment.js (#22589)
  • 🐛 Suppress expected LGTM alerts that can't be fixed (#22596)
  • 🖍 Make story page viewport units public, for usage in publisher styles (#22591)
  • 🏗 Report test status for integration tests on stable browsers on SauceLabs (#22268)
  • Fix amp-img integration test on IE 11 (#22557)
  • integration ADOP(3p) <> amp-ad (#22428)
  • Fix friendly embedding on amp-ad, and reenable test-amp-ad-fake.js (#22504)
  • Story render service for amp-story 0.1. (#22575)
  • Adds button when new update is available (#22519)
  • Enable typeahead with a suggest-first attribute on amp-autocomplete. (#22213)
  • Revert deferment of local data [src] render until layout. (#22559)
  • Fix sidebar opening for Firefox. (#22563)
  • SwG 0.1.22.53 (#22560)
  • Revert deferral of [src] local data render until layout (#22559)
  • Fix sidebar opening for Firefox. (#22563)
  • 📦 Update dependency jsdom to v15.1.1 (#22523)
  • 📦 Update dependency eslint-plugin-jsdoc to v7.2.0 (#22522)
  • 📦 Update dependency express to v4.17.1 (#22513)
  • 📦 Update dependency nodemon to v1.19.1 (#22512)
  • ♻️ Extract isFieldDefault helper (#22541)
  • SwG 0.1.22.53 (#22560)
  • 🏗 Upload codecov reports only for runtime changes (#22549)
  • ♻️ Export isDisabled helper (#22536)
  • Validator rollup (#22548)
  • Fix invisible amp-sidebar in AMP4EMAIL (#22539)
  • amp-experiment 1.0: Created the Base Allow List for Attribute Mutations (#22349)
  • Run amp-mustache-0.1 integration tests. (#22314)
  • 🐛Improvements to Permutive amp-analytics config (#22521)
  • Make sure amp-autocomplete example validates (#22537)
  • Support multi entitlement pingback in amp-subscriptions (#22469)
  • 🐛 Page layout improvements (#22369)
  • Implement (#22302)
  • Bold partial user input in suggested items (amp-autocomplete). (#21466)
  • Story page attachment dark mode. (#22505)
  • 🏗 Add new task gulp codecov-upload to upload coverage reports (#22515)
  • applyFillContent on amp-ad-custom (#22516)
  • Display fallback on error in amp-autocomplete (#21443)
  • Remove "ampdoc-shell" experimental code (#22275)
  • 🐛 FIX: Allow empty string as rendered template (#22503)
  • Updating the story amp-sidebar animations. (#22495)
  • 📦 Update dependency puppeteer to v1.17.0 (#22486)
  • 🏗 test-status app refactors + report e2e tests (#22501)
  • 📦 Update dependency bluebird to v3.5.5 (#22492)
  • 📦 Update dependency @octokit/rest to v16.27.0 (#22484)
  • 📦 Update dependency eslint-plugin-jsdoc to v7 (#22489)
  • Support lightbox gallery crop animation. (#22476)
  • 🏗 Enable noDefaults: true for jsdoc/check-types (#22498)
  • 🐛 Fix LGTM alerts in AMP codebase (#22488)
  • Allow input tags in amp-autocomplete to have no "type" attribute. (#22470)
  • Replacing the data-text-background-color img examples to add cats. (#22497)
  • Split amp.css to ampdoc.css & ampelement.css (#22458)
  • 🚀Optimize svgs used in lightbox gallery. (#22487)
  • Ban getServiceForDoc() in extensions/* paths. (#22468)
  • Validate and document text background color attribute for amp-story (#22472)
  • 🏗 Turn E2E tests into BLOCKING MODE in our CI build (#22477)
  • Make amp-autocomplete more accessible via aria labels (#22316)
  • Fix hardcoded CSS filename in closure compiler code. (#22485)
  • Fix up sample HTML syntax in doc (#22460)
  • 🏗 Allow gulp to run from amphtml/node_modules (#22479)
  • SwG crypto: decryption implementation (#22285)
  • 🏗 Add a check for the default gulp executable path (#22459)
  • add firefox option for e2e tests (#22225)
  • Use connect URL for activate iframe in amp-access-scroll (#22387)
  • 🏗🐛 Don't run clean during build, check-types, or dist (#22455)
  • Add two inabox visual diff tests (#22130)
  • Add fuzzy client-side filter option on amp-autocomplete (#22240)
  • Clean up: remove copies of CSS files under /build/. (#22457)
  • Remove duplicated polyfill import. (#22377)
  • Remove the confusing "force3p" string in a4a envelope. (#22444)
  • ♻️ Refactor lightbox controls (#22442)
  • fix typo in ssr handling request example (#22434)
  • 📦 Update babel monorepo to v7.4.5 (#22416)
  • 🐛Fix $SUBSTR macro (#22443)
  • 🔥 Fix pubmine ads (#22431)
  • Update docs/template for new cherry pick approvers (#22453)
  • 🏗 Upgrade closure compiler to v20190513 (#22446)
  • 🔥 Fix pubmine ads (#22431)
  • 🏗 Use minified build for e2e tests (#22397)
  • 📦 Update dependency jest-dot-reporter to v1.0.8 (#22448)
  • 📦 Update dependency gzip-size to v5.1.1 (#22407)
  • 📦 Update dependency express to v4.17.0 (#22350)
  • 📦 Update dependency @octokit/rest to v16.26.0 (#22261)
  • 📦 Update dependency eslint-plugin-eslint-plugin to v2.1.0 (#22203)
  • SwG release 0.1.22.51.1 (#22445)
  • Revert "Add new (#22417)" (#22447)
  • 🐛Fix $SUBSTR macro (#22443)
  • 📦 Update dependency google-closure-compiler to v20190513 (#22368)
  • 🏗 Log Karma results when zero tests are detected (#22439)
  • Add animate-in-timing-function attribute to the amp-story documentation. (#22436)
  • 🐛 amp-carousel: hide next/prev in type=carousel for screen readers (#22405)
  • 🐛Don't report error when amp-google-client-id-api is set to gtag (#21970)
  • Update progress bar when new page is appended by the LiveStoryManager (#22367)
  • Implementation for amp-user-location component (#22182)
  • 🏗 Run unit tests on Firefox (#22420)
  • amp-experiment 1.0: Implemented a maximum number of mutations (#22176)
  • Removed the no mutations limitation (#22395)
  • ♻️Added comment on generating .out files for validator (#22374)
  • Add new (#22417)

Breakdown by component

amp-3q-player Add trailing newlines to validator files. (#22625)
amp-a4a applyFillContent on amp-ad-custom (#22516)
amp-accordion Add trailing newlines to validator files. (#22625)
amp-ad Add trailing newlines to validator files. (#22625)
amp-ad-custom Add trailing newlines to validator files. (#22625)
amp-addthis Add services to overridekeys for addthis (#22588)
amp-analytics Add custom cookie expiration (#22483) 🐛Fix broken args in expander. (#22508) Remove onBodyAvailable from doc-state service. Start deprecation. (#22580) 🐛Improvements to Permutive amp-analytics config (#22521)
amp-animation 🐛 Fixed spelling inconsistency in extensions/amp-animation/0.1/css-expr-impl.js (#22590)
amp-autocomplete Add trailing newlines to validator files. (#22625) 📖Update amp-autocomplete md file to be more concise (#22529) Make sure amp-autocomplete example validates (#22537)
amp-base-carousel ♻️Cleanup e2e test endpoints and remove unused screenshot calls (#22674) Add trailing newlines to validator files. (#22625)
amp-bind 🚮Remove autosuggest examples and assets (#22653) Add trailing newlines to validator files. (#22625) Fix friendly embedding on amp-ad, and reenable test-amp-ad-fake.js (#22504)
amp-bodymovin-animation Add trailing newlines to validator files. (#22625)
amp-brightcove Add trailing newlines to validator files. (#22625)
amp-byside-content Add trailing newlines to validator files. (#22625)
amp-call-tracking 🐛amp-call-tracking: Made the 'phoneNumber' field optional (#22613)
amp-carousel Validator rollup (#22548)
amp-dailymotion Add trailing newlines to validator files. (#22625)
amp-date-countdown Add trailing newlines to validator files. (#22625)
amp-date-display Add trailing newlines to validator files. (#22625)
amp-delight-player Add trailing newlines to validator files. (#22625)
amp-embedly-card Add trailing newlines to validator files. (#22625)
amp-experiment Add trailing newlines to validator files. (#22625)
amp-facebook Add trailing newlines to validator files. (#22625)
amp-form ♻️Cleanup e2e test endpoints and remove unused screenshot calls (#22674) FEATURE: AMP form dirtiness indicator class (#22640) ♻️ Extract `isFieldDefault` helper (#22541)
amp-google-document-embed Add trailing newlines to validator files. (#22625)
amp-gwd-animation Fix friendly embedding on amp-ad, and reenable test-amp-ad-fake.js (#22504)
amp-ima-video Add trailing newlines to validator files. (#22625)
amp-jwplayer Add trailing newlines to validator files. (#22625)
amp-lightbox Add trailing newlines to validator files. (#22625)
amp-lightbox-gallery 🚀Optimize svgs used in lightbox gallery. (#22487)
amp-link-rewriter Add trailing newlines to validator files. (#22625)
amp-list ♻️Cleanup e2e test endpoints and remove unused screenshot calls (#22674) Add trailing newlines to validator files. (#22625) Revert deferral of [src] local data render until layout (#22559) 🐛 FIX: Allow empty string as rendered template (#22503)
amp-mowplayer Add trailing newlines to validator files. (#22625)
amp-mustache Remove special casing for tests from amp-mustache extension registration (#22598) Add trailing newlines to validator files. (#22625)
amp-sidebar Fix sidebar opening for Firefox. (#22563)
amp-story Viewer messaging to select the next/previous document. (#22684) ♻️ Replace usage of pagesCount with page_ids.length (#22655) Attachment theme validation. (#22643) Remove onBodyAvailable from doc-state service. Start deprecation. (#22580) Replacing story attachment data-dark-mode with theme. (#22642) Handling the lifecycle of AMP components within an attachment. (#22603) Adding a label for the "line" share provider. (#22639) Documentation for story page attachments dark mode. (#22506) 🖍 Make story page viewport units public, for usage in publisher styles (#22591) Story render service for amp-story 0.1. (#22575) Adds button when new update is available (#22519) Story page attachment dark mode. (#22505) Updating the story amp-sidebar animations. (#22495) Replacing the data-text-background-color img examples to add cats. (#22497)
amp-story-auto-ads Remove onBodyAvailable from doc-state service. Start deprecation. (#22580)
amp-vimeo 🐛 Fix LGTM alerts in AMP codebase (#22488)
validator Adds generator for JSON version of the validator spec (#22528) This makes it easier to consume by scripts to e.g. pull the list of all tags allowed by a specific format or generate autocomplete definitions for playground.amp.dev. Validator Rollup (#22620) Fix #22535 where the validator considers a document with 1,000+ bytes of inline CSS as valid. 🐛 Suppress expected LGTM alerts that can't be fixed (#22596) In #22488, we fixed all the security, correctness, and maintainability issues in our code detected via static analysis from LGTM.com.

This PR suppresses the remaining issues that are expected and can't be fixed.

Files:

Rules that were suppressed:

Fixed:

Left alone:

Assets 2

Version: 1905292322390

Baseline: 1905211840370

  • Fix friendly embedding on amp-ad, and reenable test-amp-ad-fake.js (#22504)
  • Story render service for amp-story 0.1. (#22575)
  • Adds button when new update is available (#22519)
  • Enable typeahead with a suggest-first attribute on amp-autocomplete. (#22213)
  • Revert deferment of local data [src] render until layout. (#22559)
  • Fix sidebar opening for Firefox. (#22563)
  • SwG 0.1.22.53 (#22560)
  • Revert deferral of [src] local data render until layout (#22559)
  • Fix sidebar opening for Firefox. (#22563)
  • 📦 Update dependency jsdom to v15.1.1 (#22523)
  • 📦 Update dependency eslint-plugin-jsdoc to v7.2.0 (#22522)
  • 📦 Update dependency express to v4.17.1 (#22513)
  • 📦 Update dependency nodemon to v1.19.1 (#22512)
  • ♻️ Extract isFieldDefault helper (#22541)
  • SwG 0.1.22.53 (#22560)
  • 🏗 Upload codecov reports only for runtime changes (#22549)
  • ♻️ Export isDisabled helper (#22536)
  • Validator rollup (#22548)
  • Fix invisible amp-sidebar in AMP4EMAIL (#22539)
  • amp-experiment 1.0: Created the Base Allow List for Attribute Mutations (#22349)
  • Run amp-mustache-0.1 integration tests. (#22314)
  • 🐛Improvements to Permutive amp-analytics config (#22521)
  • Make sure amp-autocomplete example validates (#22537)
  • Support multi entitlement pingback in amp-subscriptions (#22469)
  • 🐛 Page layout improvements (#22369)
  • Implement (#22302)
  • Bold partial user input in suggested items (amp-autocomplete). (#21466)
  • Story page attachment dark mode. (#22505)
  • 🏗 Add new task gulp codecov-upload to upload coverage reports (#22515)
  • applyFillContent on amp-ad-custom (#22516)
  • Display fallback on error in amp-autocomplete (#21443)
  • Remove "ampdoc-shell" experimental code (#22275)
  • 🐛 FIX: Allow empty string as rendered template (#22503)
  • Updating the story amp-sidebar animations. (#22495)
  • 📦 Update dependency puppeteer to v1.17.0 (#22486)
  • 🏗 test-status app refactors + report e2e tests (#22501)
  • 📦 Update dependency bluebird to v3.5.5 (#22492)
  • 📦 Update dependency @octokit/rest to v16.27.0 (#22484)
  • 📦 Update dependency eslint-plugin-jsdoc to v7 (#22489)
  • Support lightbox gallery crop animation. (#22476)
  • 🏗 Enable noDefaults: true for jsdoc/check-types (#22498)
  • 🐛 Fix LGTM alerts in AMP codebase (#22488)
  • Allow input tags in amp-autocomplete to have no "type" attribute. (#22470)
  • Replacing the data-text-background-color img examples to add cats. (#22497)
  • Split amp.css to ampdoc.css & ampelement.css (#22458)
  • 🚀Optimize svgs used in lightbox gallery. (#22487)
  • Ban getServiceForDoc() in extensions/* paths. (#22468)
  • Validate and document text background color attribute for amp-story (#22472)
  • 🏗 Turn E2E tests into BLOCKING MODE in our CI build (#22477)
  • Make amp-autocomplete more accessible via aria labels (#22316)
  • Fix hardcoded CSS filename in closure compiler code. (#22485)
  • 🏗 Allow gulp to run from amphtml/node_modules (#22479)
  • SwG crypto: decryption implementation (#22285)
  • 🏗 Add a check for the default gulp executable path (#22459)
  • add firefox option for e2e tests (#22225)
  • Use connect URL for activate iframe in amp-access-scroll (#22387)
  • 🏗🐛 Don't run clean during build, check-types, or dist (#22455)
  • Add two inabox visual diff tests (#22130)
  • Add fuzzy client-side filter option on amp-autocomplete (#22240)
  • Clean up: remove copies of CSS files under /build/. (#22457)
  • Remove duplicated polyfill import. (#22377)
  • Remove the confusing "force3p" string in a4a envelope. (#22444)
  • ♻️ Refactor lightbox controls (#22442)
  • fix typo in ssr handling request example (#22434)
  • 📦 Update babel monorepo to v7.4.5 (#22416)
  • 🐛Fix $SUBSTR macro (#22443)
  • 🔥 Fix pubmine ads (#22431)
  • 🏗 Upgrade closure compiler to v20190513 (#22446)
  • 🔥 Fix pubmine ads (#22431)
  • 🏗 Use minified build for e2e tests (#22397)
  • 📦 Update dependency jest-dot-reporter to v1.0.8 (#22448)
  • 📦 Update dependency gzip-size to v5.1.1 (#22407)
  • 📦 Update dependency express to v4.17.0 (#22350)
  • 📦 Update dependency @octokit/rest to v16.26.0 (#22261)
  • 📦 Update dependency eslint-plugin-eslint-plugin to v2.1.0 (#22203)
  • SwG release 0.1.22.51.1 (#22445)
  • Revert " Add new " (#22447)
  • 🐛Fix $SUBSTR macro (#22443)
  • 📦 Update dependency google-closure-compiler to v20190513 (#22368)
  • 🏗 Log Karma results when zero tests are detected (#22439)
  • 🐛 amp-carousel: hide next/prev in type=carousel for screen readers (#22405)
  • 🐛Don't report error when amp-google-client-id-api is set to gtag (#21970)
  • Update progress bar when new page is appended by the LiveStoryManager (#22367)
  • Implementation for amp-user-location component (#22182)
  • 🏗 Run unit tests on Firefox (#22420)
  • amp-experiment 1.0: Implemented a maximum number of mutations (#22176)
  • amp-experiment 1.0: Removed the "No mutations" limitation (#22395)
  • ♻️Added comment on generating .out files for validator (#22374)
  • Add new (#22417)

Breakdown by component

ads 🔥 Fix pubmine ads (#22431)
amp-a4a applyFillContent on amp-ad-custom (#22516)
amp-ad-network-doubleclick-impl 📖 Fix up sample HTML syntax in doc (#22460)
amp-analytics 🐛Improvements to Permutive amp-analytics config (#22521) 🐛Fix $SUBSTR macro (#22443)
amp-autocomplete 📖Update amp-autocomplete md file to be more concise (#22529) Make sure amp-autocomplete example validates (#22537) Allow input tags in amp-autocomplete to have no "type" attribute. (#22470) Split amp.css to ampdoc.css & ampelement.css (#22458)
amp-bind Fix friendly embedding on amp-ad, and reenable test-amp-ad-fake.js (#22504) 🏗 Upgrade closure compiler to v20190513 (#22446)
amp-carousel Validator rollup (#22548) 🐛 amp-carousel: hide next/prev in type=carousel for screen readers (#22405)
amp-experiment amp-experiment 1.0: Removed the "No mutations" limitation (#22395)
amp-form ♻️ Extract `isFieldDefault` helper (#22541)
amp-gwd-animation Fix friendly embedding on amp-ad, and reenable test-amp-ad-fake.js (#22504) 🏗 Upgrade closure compiler to v20190513 (#22446)
amp-lightbox-gallery Support lightbox gallery crop animation. (#22476) 🚀Optimize svgs used in lightbox gallery. (#22487) ♻️ Refactor lightbox controls (#22442)
amp-list Revert deferral of [src] local data render until layout (#22559) 🐛 FIX: Allow empty string as rendered template (#22503) 🏗 Use minified build for e2e tests (#22397)
amp-live-list Split amp.css to ampdoc.css & ampelement.css (#22458)
amp-recaptcha-input Split amp.css to ampdoc.css & ampelement.css (#22458)
amp-sidebar Fix sidebar opening for Firefox. (#22563)
amp-story Story render service for amp-story 0.1. (#22575) Adds button when new update is available (#22519) Story page attachment dark mode. (#22505) Updating the story amp-sidebar animations. (#22495) Replacing the data-text-background-color img examples to add cats. (#22497) Split amp.css to ampdoc.css & ampelement.css (#22458) Validate and document text background color attribute for amp-story (#22472) Add animate-in-timing-function attribute to the amp-story documentation. (#22436)
amp-subscriptions Support multi entitlement pingback in amp-subscriptions (#22469) 🏗 Upgrade closure compiler to v20190513 (#22446)
amp-subscriptions-google Support multi entitlement pingback in amp-subscriptions (#22469)
amp-vimeo 🐛 Fix LGTM alerts in AMP codebase (#22488)
validator Validator rollup (#22548) - cl/250386704 Revision bump for #22488 - cl/250316079 Revision bump for #22470 - cl/249558901 Revision bump for #22447 - cl/249525181 Revision bump for #22182 - cl/249465797 Revision bump for #22417 - cl/249302791 Remove non-AMP formats for carousel reference points. 🐛 Fix LGTM alerts in AMP codebase (#22488) This PR fixes a few of the security, correctness, and maintainability [issues](https://lgtm.com/projects/g/ampproject/amphtml/alerts/?mode=tree) in our code detected via static analysis from LGTM.com.

Fixed:

Left alone:

Revert " Add new " (#22447)
Reverts #22417

Per #21931 (comment), we've decided not to offer a page level opt-out.
Add new (#22417)
Certain experiments are will be enabled by default (eg, the new blurry image placeholders). This provides a way for publishers to opt-out of the experiment.

We considered whether to reuse the amp-experiments-opt-in meta tag, but we found opting-out using an opt-in was confusing. This provides a more natural way.

Assets 2

Version: 1905291911450

Baseline: 1905222334000

  • Revert deferment of local data [src] render until layout. (#22559)
  • Fix sidebar opening for Firefox. (#22563)
  • SwG 0.1.22.53 (#22560)

Breakdown by component

Assets 2

Version: 1905222334000

Baseline: 1905211840370

  • 🐛Fix $SUBSTR macro (#22443)
  • 🔥 Fix pubmine ads (#22431)
  • Fix story render service during prerendering. (#22346)
  • 🏗 Restore text coloring in Travis logs (#22415)
  • "AMP Cache Guidelines" update (#21786)
  • Validator rollup (#22413)
  • 🏗 Clean up .eslintignore (#22411)
  • Add referrer presence signals to the config rewriter varGroups. (#22365)
  • allow cookie writer macros (#22388)
  • 🏗 Use minified build for visual diff tests (#22402)
  • ♻️ Refactor math utils in extensions (#21876)
  • 🐛Fix variable service race. (#22375)
  • fix wrong data event Select amp-date-picker range (#22408)
  • 🐛Fix flicker when opening an animated accordion. (#22399)
  • amp-experiment 1.0: Added a 15KB limit on amp-experiment JSON (#22372)
  • 🏗 Run local integration tests on minified builds by default (#22380)
  • Reformat beaverads contribution (#22396)
  • 🐛Fix sidebar open animation. (#22324)
  • Intent To Implement: BeaverAds support for amp-ads (#22281)
  • updates size according to guidance (#20618)
  • Update AMPHTML validator version (#17940)
  • Use passive events for carousel. (#22004)
  • 🐛 amp-script Remove AMP cors requirement for author code (#22389)
  • Differentiate 'render-start' msg and RENDER_START signal (#22305)
  • 🏗🐛 Fix logic used to determine the branch creation point on Travis (#22355)
  • 🏗 Skip failing e2e tests and set retry to 2 (#22390)
  • 🐛 Don't overwrite browserify transform config (#22386)
  • 🏗 Update the build target logic used during PR checks (#22348)
  • Add separate iframe transport URLs for Canary (#22296)
  • ♻️Move VariableService to doc level #2 (#22300)
  • Enable linker for AMP.navigateTo (#22361)
  • 🏗♻️ Move test configuration out of package json (#22362)
  • 🏗 Appropriately handle async E2E test error (#22366)
  • Ensure that the waitForBody yields at the earliest possible time when body is opened (#22343)
  • 🏗🐛 Fixes for gulp pr-check (#22364)
  • 🐛 Support RTL for base carousel (#21994)
  • Rename waitForBody to waitForBodyOpen (#22347)
  • 🐛 Add safe zone in screen edges to prevent blocking navigation (#22116)
  • Remove unnecessary service stubs in linker-manager-test (#22356)
  • Introduce LiveStoryManager (#22273)
  • [AoG] Fix two race conditions in amp-bind/amp-list when backgrounded (#22227)
  • Use DOMReady (bodyComplete) signal where necessary (#22344)
  • ♻️Lightbox refactoring. (#22232)
  • Force build additional components during prerendering if needed. (#22326)
  • 📦 Update dependency @ampproject/animations to v0.2.0 (#22228)
  • 📦 Update dependency fs-extra to v8 (#22259)
  • 📦 Update dependency eslint-plugin-jsdoc to v5 (#22313)
  • 📦 Update dependency eslint-config-prettier to v4.3.0 (#22333)
  • Create custom attribute for text background color in stories (#22138)
  • 📦 Update dependency jsdom to v15.1.0 (#22262)
  • 📦 Update dependency puppeteer to v1.16.0 (#22276)
  • 📦 Update dependency codecov to v3.5.0 (#22304)
  • 📦 Update dependency eslint-plugin-prettier to v3.1.0 (#22336)
  • 🐛 Add max width to amp-twitter (#22334)
  • Documentation for story page attachments CTA label and title. (#21989)
  • 🏗Switch to .prettierrc to avoid breaking IDE extensions (#22332)
  • Update feature deprecation/removal process (#22114)
  • 🏗 Adopt prettier for code formatting (#21212)
  • 🏗Enable passing viewer caps as hashparam (#22317)
  • Remove amp-consent experimental flag (#22306)
  • Handling video visibility updates. (#22140)
  • amp-next-page: Fetch failure should be a user error (#22293)
  • 🏗🐛 Mark --local-changes test status as skipped for large refactors (#22323)
  • amp-consent: Allowed passing the consent string through a macro (#22299)
  • New amp-ad for aniview (#20884)
  • 🏗♻️🚮🐛 Refactor gulp pr-check (#22319)
  • 🏗 Don't run unit tests on local changes for large refactors (#22320)
  • 🏗 Altered Safari Preconnect Polyfill Endpoint (#21138)
  • amp-form: Reduce typecasts, clean up (#22298)
  • Fix messenger command typo in web-push service worker (#20245)
  • SwG release 0.1.22.51 (#22301)
  • 🏗🚮 Simplify the way gulp lint works on Travis (#22294)
  • Add validation rules for (#22289)
  • amp-embed support for opinary (#22195)
  • Validator Rollup (#22286)
  • Fix usage of getElementsByTagName on ShadowRoot. (#22290)
  • 🐛 Fix broken links in AMP4Email spec. (#22044)
  • 🐛 Fix lint error in 3p/integration.js (#22284)
  • Add shadow integration test for amp analytics (#22252)
  • Add Intent-to-Deprecate and Intent-to-Remove templates (#22283)
  • amp form submit-error action fix (#22221)
  • 🏗 End e2e task with grace (#22164)
  • 🐛 amp inabox: Removed margin: auto !important for the amp4ads use case (#22274)
  • swg Crypto naming change keys -> cryptokeys (#22272)
  • Rename Chargeads to Newsroom AI (#20860)
  • Add dirtyBit support to stored consent value (#22257)
  • Write cookies to eTLD+1 (#22255)
  • 🏗🐛 Run tests against minified code during PR checks (#22263)
  • Remove position: absolute when measuring fluid creative height. (#22242)
  • Store the native getBoundingClientRect before patching (#22269)
  • 🏗♻️ Refactor post-compilation config writes (#22256)
  • Override global scrollTo in iOS embed cases (#22244)
  • 🚮 Remove support for xhr identity attribute "cross-origin". (#21909)
  • 🚀 Use a multislot request for pubmine ads (#21781)
  • 🏗♻️🚮🐛 Refactor compile() in build-system/tasks/helpers.js (#22254)
  • 🐛 web-worker: Set error reporter (#21855)
  • Support dynamically added lists and add configuration options (#21778)
  • Support for Idealmedia (#22102)
  • 🐛 Update failing autocomplete e2e test (#22250)
  • amp-consent: Added support for allowing CMPs to add their own documentation and examples for amp-consent (#21752)
  • 🏗 Re add IE11 to our CI in blocking mode (#22248)
  • Support for Lentainform (#22101)
  • Support for MGID (#22100)
  • 🏗 Clean up describes-e2e (#22206)
  • Validator rollup (#22236)
  • Rename version to internalRuntimeVersion in AmpPass.java (#22234)
  • validator.amp.dev is live, update links (#22231)
  • 🏗🚮 Use compiler.jar instead of runner.jar for single pass, remove unnecessary code (#22056)
  • repace version() calls with the version string literal (#22216)
  • 🖍🐛 Lightbox captions changes. (#22189)
  • Config for ios-fixed-no-transfer experiment (#22224)
  • Experiment to disable transfer layer in 12.2 and above (#22223)
  • 📦 Update dependency gulp to v4.0.2 (#22157)
  • 📦 Update dependency codecov to v3.4.0 (#22211)
  • 📦 Update dependency @octokit/rest to v16.25.3 (#22190)
  • SwG Release 0.1.22.50 (#22226)
  • Add allow-blocked-end-date flag and e2e test (#22029)
  • 🏗 Retry tests before failing them on Travis (#22210)
  • 🏗 Enable integration testing on IE11 (#21667)
  • Implementing subscriptions encryption to work with the Viewer (#22058)
  • Revert "♻️Move VariableService to doc level (#22137)" (#22218)
  • Revert "♻️Move VariableService to doc level (#22137)" (#22218)
  • amp-bind: Update textarea initial value via [defaultText] (#22205)
  • toggleAutoplay is an action, not an event. (#22202)
  • Delete auto ads responsive experiment from experiments.js (#22191)
  • Skip flaky A4A test (#22165)
  • amp-consent: consent-ui Allow passing in the reason for prompt in the iframe name attribute (#21647)
  • 🏗♻️ Refactor compileJs into smaller functions (#22147)
  • 🐞Fix dev server shadow mode. (#22207)
  • amp-script: Share size limit across elements (#22083)
  • updated documentation on sizes attribute behavior on amp-img (#22166)
  • 🍎 🐛 amp-lightbox: prevent iOS scroll freeze in both directions. (#22199)
  • 🌐 Support RTL inputs and datasets on amp-autocomplete (#22128)
  • added note about ads and flying carpets (#22186)
  • Add support for mask-trim-zeros attribute on amp-inputmask. (#22175)
  • Update validator output due to changed message. (#22196)
  • Delete auto ads responsive experiment from config (#22192)
  • Allow SVG elements in stories. (#22187)
  • Validator rollup (#22188)
  • Skip all amp-skimlinks integration tests. (#22181)
  • 🖍🚀🐛support for CAaja ads network (#21671)
  • Docs: remove "experimental" (overloaded term) (#21943)
  • For AdSense, expect checksum to be a 32-bit integer that is not base-64 encoded. (#21716)
  • 🐛Propagate data-ad-host attribute to ad url param for amp-auto-ads (#22092)
  • 📖 amp-recaptcha-input: Added amp.dev example (#21834)

Breakdown by component

ads Reformat beaverads contribution (#22396)
amp-a4a Remove amp-consent experimental flag (#22306) amp-consent: Allowed passing the consent string through a macro (#22299)
amp-access Fixes typo in amp-access and amp-subscriptions docs (#22363)
amp-accordion 🐛Fix flicker when opening an animated accordion. (#22399)
amp-ad Differentiate 'render-start' msg and RENDER_START signal (#22305)
amp-analytics Add referrer presence signals to the config rewriter varGroups. (#22365) allow cookie writer macros (#22388) 🐛Fix variable service race. (#22375) Add separate iframe transport URLs for Canary (#22296) ♻️Move VariableService to doc level #2 (#22300) Enable linker for AMP.navigateTo (#22361) Remove unnecessary service stubs in linker-manager-test (#22356) 📖 AMP analytics docs: Correct format support (-email, +stories) (#22338)
amp-autocomplete 📖 Fix formatting issues in extension docs and add missing front-matter (#22351)
amp-base-carousel 🏗 Skip failing e2e tests and set retry to 2 (#22390)
amp-connatix-player 📖 Connatix Player extension: fix broken documentation page (#22311)
amp-consent Rename consentState to consentStateValue (#22308)
amp-date-picker fix wrong data event Select amp-date-picker range (#22408)
amp-dynamic-css-classes Rename waitForBody to waitForBodyOpen (#22347)
amp-experiment amp-experiment 1.0: Added a 15KB limit on amp-experiment JSON (#22372) Rename waitForBody to waitForBodyOpen (#22347) Use DOMReady (bodyComplete) signal where necessary (#22344)
amp-form 🏗 Skip failing e2e tests and set retry to 2 (#22390) 📖 Fix formatting issues in extension docs and add missing front-matter (#22351) amp-form: Reduce typecasts, clean up (#22298)
amp-geo Rename waitForBody to waitForBodyOpen (#22347) Use DOMReady (bodyComplete) signal where necessary (#22344)
amp-gist 📖 Fix formatting issues in extension docs and add missing front-matter (#22351)
amp-gwd-animation Rename waitForBody to waitForBodyOpen (#22347) Use DOMReady (bodyComplete) signal where necessary (#22344)
amp-inputmask 📖 Fix formatting issues in extension docs and add missing front-matter (#22351)
amp-lightbox 📖 Add email to amp-lightbox supported formats (#22330)
amp-lightbox-gallery 📖amp-lightbox-gallery: update the broken example link (#22310)
amp-link-rewriter 📖 Fix formatting issues in extension docs and add missing front-matter (#22351) Use DOMReady (bodyComplete) signal where necessary (#22344)
amp-list 🏗 Skip failing e2e tests and set retry to 2 (#22390)
amp-mraid 📖 Fix formatting issues in extension docs and add missing front-matter (#22351)
amp-next-page amp-next-page: Fetch failure should be a user error (#22293)
amp-recaptcha-input 🐛amp-recaptcha-input: Removed the experimental blurb in the recaptcha reference docs (#22307)
amp-script Validator rollup (#22413) 🐛 `amp-script` Remove AMP cors requirement for author code (#22389)
amp-sidebar 🐛Fix sidebar open animation. (#22324)
amp-skimlinks Rename waitForBody to waitForBodyOpen (#22347)
amp-smartlinks 📖 Fix formatting issues in extension docs and add missing front-matter (#22351) Use DOMReady (bodyComplete) signal where necessary (#22344)
amp-sticky-ad Rename waitForBody to waitForBodyOpen (#22347)
amp-story Fix story render service during prerendering. (#22346) Use DOMReady (bodyComplete) signal where necessary (#22344) 🐛 Add max width to amp-twitter (#22334)
amp-subscriptions Fixes typo in amp-access and amp-subscriptions docs (#22363)
amp-viewer-integration 🏗 Clean up `.eslintignore` (#22411)
validator Validator rollup (#22413) - cl/249265307 Revision bump for #22372 - cl/249156543 Allow amp-script with an experiment token. - cl/248381896 Revision bump for #22289

🏗🚮 Simplify the way gulp lint works on Travis (#22294)
Over the past year, various lint rules were added to improve AMP's code correctness. For example, #14742, #12748, #15255, #14761. In addition, lint checks were enabled for the code in validator/, which is developed in a different repo and periodically synced to amphtml. See #18601 and #13966.

As a result, gulp lint is run only against the files edited by a PR during PR builds, while hundreds of linter warnings are printed during push builds.

This PR does the following:

  • Silences 200+ outstanding linter warnings for amphtml-internal/prefer-deferred-promise, amphtml-internal/unused-private-field, and amphtml-internal/vsync, and for the validator/ directory
  • Updates lint.js to lint all files during Travis PR and push builds
  • Paves the way for #21212 by starting with a clean slate of linter errors

Follow up tasks:

  • Fix remaining amphtml-internal/prefer-deferred-promise, amphtml-internal/unused-private-field, and amphtml-internal/vsync errors and re-enable the rules in error mode (#14742, #12748)
  • Fix lint errors in validator/ and re-enable all rules in validator/.eslintrc (#18601, #13966)
Assets 2
Pre-release
Pre-release

@ampprojectbot ampprojectbot released this May 22, 2019

Version: 1905211840370

Baseline: 1905140117570

  • Fix story render service during prerendering. (#22346)
  • 🏗 Restore text coloring in Travis logs (#22415)
  • "AMP Cache Guidelines" update (#21786)
  • Validator rollup (#22413)
  • 🏗 Clean up .eslintignore (#22411)
  • Add referrer presence signals to the config rewriter varGroups. (#22365)
  • allow cookie writer macros (#22388)
  • 🏗 Use minified build for visual diff tests (#22402)
  • ♻️ Refactor math utils in extensions (#21876)
  • 🐛Fix variable service race. (#22375)
  • fix wrong data event Select amp-date-picker range (#22408)
  • 🐛Fix flicker when opening an animated accordion. (#22399)
  • amp-experiment 1.0: Added a 15KB limit on amp-experiment JSON (#22372)
  • 🏗 Run local integration tests on minified builds by default (#22380)
  • Reformat beaverads contribution (#22396)
  • 🐛Fix sidebar open animation. (#22324)
  • Intent To Implement: BeaverAds support for amp-ads (#22281)
  • updates size according to guidance (#20618)
  • Update AMPHTML validator version (#17940)
  • Use passive events for carousel. (#22004)
  • 🐛 amp-script Remove AMP cors requirement for author code (#22389)
  • Differentiate 'render-start' msg and RENDER_START signal (#22305)
  • 🏗🐛 Fix logic used to determine the branch creation point on Travis (#22355)
  • 🏗 Skip failing e2e tests and set retry to 2 (#22390)
  • 🐛 Don't overwrite browserify transform config (#22386)
  • 🏗 Update the build target logic used during PR checks (#22348)
  • Add separate iframe transport URLs for Canary (#22296)
  • ♻️Move VariableService to doc level #2 (#22300)
  • Enable linker for AMP.navigateTo (#22361)
  • 🏗♻️ Move test configuration out of package json (#22362)
  • 🏗 Appropriately handle async E2E test error (#22366)
  • Ensure that the waitForBody yields at the earliest possible time when body is opened (#22343)
  • 🏗🐛 Fixes for gulp pr-check (#22364)
  • 🐛 Support RTL for base carousel (#21994)
  • Rename waitForBody to waitForBodyOpen (#22347)
  • 🐛 Add safe zone in screen edges to prevent blocking navigation (#22116)
  • Remove unnecessary service stubs in linker-manager-test (#22356)
  • Introduce LiveStoryManager (#22273)
  • [AoG] Fix two race conditions in amp-bind/amp-list when backgrounded (#22227)
  • Use DOMReady (bodyComplete) signal where necessary (#22344)
  • ♻️Lightbox refactoring. (#22232)
  • Force build additional components during prerendering if needed. (#22326)
  • 📦 Update dependency @ampproject/animations to v0.2.0 (#22228)
  • 📦 Update dependency fs-extra to v8 (#22259)
  • 📦 Update dependency eslint-plugin-jsdoc to v5 (#22313)
  • 📦 Update dependency eslint-config-prettier to v4.3.0 (#22333)
  • Create custom attribute for text background color in stories (#22138)
  • 📦 Update dependency jsdom to v15.1.0 (#22262)
  • 📦 Update dependency puppeteer to v1.16.0 (#22276)
  • 📦 Update dependency codecov to v3.5.0 (#22304)
  • 📦 Update dependency eslint-plugin-prettier to v3.1.0 (#22336)
  • 🐛 Add max width to amp-twitter (#22334)
  • Documentation for story page attachments CTA label and title. (#21989)
  • 🏗Switch to .prettierrc to avoid breaking IDE extensions (#22332)
  • Update feature deprecation/removal process (#22114)
  • 🏗 Adopt prettier for code formatting (#21212)
  • 🏗Enable passing viewer caps as hashparam (#22317)
  • Remove amp-consent experimental flag (#22306)
  • Handling video visibility updates. (#22140)
  • amp-next-page: Fetch failure should be a user error (#22293)
  • 🏗🐛 Mark --local-changes test status as skipped for large refactors (#22323)
  • amp-consent: Allowed passing the consent string through a macro (#22299)
  • New amp-ad for aniview (#20884)
  • 🏗♻️🚮🐛 Refactor gulp pr-check (#22319)
  • 🏗 Don't run unit tests on local changes for large refactors (#22320)
  • 🏗 Altered Safari Preconnect Polyfill Endpoint (#21138)
  • amp-form: Reduce typecasts, clean up (#22298)
  • Fix messenger command typo in web-push service worker (#20245)
  • SwG release 0.1.22.51 (#22301)
  • 🏗🚮 Simplify the way gulp lint works on Travis (#22294)
  • Add validation rules for (#22289)
  • amp-embed support for opinary (#22195)
  • Validator Rollup (#22286)
  • 🐛Fix usage of getElementsByTagName on ShadowRoot. (#22290)
  • 🐛 Fix broken links in AMP4Email spec. (#22044)
  • 🐛 Fix lint error in 3p/integration.js (#22284)
  • Add shadow integration test for amp analytics (#22252)
  • amp form submit-error action fix (#22221)
  • 🏗 End e2e task with grace (#22164)
  • 🐛 amp inabox: Removed margin: auto !important for the amp4ads use case (#22274)
  • ♻️ SwG Crypto naming change: "keys" -> "cryptokeys" (#22272)
  • Rename Chargeads to Newsroom AI (#20860)
  • Add dirtyBit support to stored consent value (#22257)
  • Write cookies to eTLD+1 (#22255)
  • 🏗🐛 Run tests against minified code during PR checks (#22263)
  • Remove position: absolute when measuring fluid creative height. (#22242)
  • 🐛 Store the native getBoundingClientRect before patching (#22269)
  • 🏗♻️ Refactor post-compilation config writes (#22256)
  • Override global scrollTo in iOS embed cases (#22244)
  • 🚮 Remove support for xhr identity attribute "cross-origin". (#21909)
  • 🚀 Use a multislot request for pubmine ads (#21781)
  • 🏗♻️🚮🐛 Refactor compile() in build-system/tasks/helpers.js (#22254)
  • 🐛 web-worker: Set error reporter (#21855)
  • Support dynamically added lists and add configuration options (#21778)
  • Support for Idealmedia (#22102)
  • 🐛Update failing autocomplete e2e test (#22250)
  • amp-consent: Added support for allowing CMPs to add their own documentation and examples for amp-consent (#21752)
  • 🏗 Re add IE11 to our CI in blocking mode (#22248)
  • Support for Lentainform (#22101)
  • Support for MGID (#22100)
  • 🏗 Clean up describes-e2e (#22206)
  • Validator rollup (#22236)
  • Rename version to internalRuntimeVersion in AmpPass.java (#22234)
  • validator.amp.dev is live, update links (#22231)
  • 🏗🚮 Use compiler.jar instead of runner.jar for single pass, remove unnecessary code (#22056)
  • repace version() calls with the version string literal (#22216)
  • 🖍🐛 Lightbox captions changes. (#22189)
  • Config for ios-fixed-no-transfer experiment (#22224)
  • Experiment to disable transfer layer in 12.2 and above (#22223)
  • 📦 Update dependency gulp to v4.0.2 (#22157)
  • 📦 Update dependency codecov to v3.4.0 (#22211)
  • 📦 Update dependency @octokit/rest to v16.25.3 (#22190)
  • SwG Release 0.1.22.50 (#22226)
  • Add allow-blocked-end-date flag and e2e test (#22029)
  • 🏗 Retry tests before failing them on Travis (#22210)
  • 🏗 Enable integration testing on IE11 (#21667)
  • Implementing subscriptions encryption to work with the Viewer (#22058)
  • Revert "♻️Move VariableService to doc level (#22137)" (#22218)
  • Revert "♻️Move VariableService to doc level (#22137)" (#22218)
  • amp-bind: Update textarea initial value via [defaultText] (#22205)
  • toggleAutoplay is an action, not an event. (#22202)
  • Delete auto ads responsive experiment from experiments.js (#22191)
  • Skip flaky A4A test (#22165)
  • amp-consent: consent-ui Allow passing in the reason for prompt in the iframe name attribute (#21647)
  • 🏗♻️ Refactor compileJs into smaller functions (#22147)
  • 🐞Fix dev server shadow mode. (#22207)
  • amp-script: Share size limit across elements (#22083)
  • updated documentation on sizes attribute behavior on amp-img (#22166)
  • 🍎 🐛 amp-lightbox: prevent iOS scroll freeze in both directions. (#22199)
  • 🌐 Support RTL inputs and datasets on amp-autocomplete (#22128)
  • added note about ads and flying carpets (#22186)
  • Add support for mask-trim-zeros attribute on amp-inputmask. (#22175)
  • Update validator output due to changed message. (#22196)
  • Delete auto ads responsive experiment from config (#22192)
  • Allow SVG elements in stories. (#22187)
  • Validator rollup (#22188)
  • Skip all amp-skimlinks integration tests. (#22181)
  • 🖍🚀🐛support for CAaja ads network (#21671)
  • Docs: remove "experimental" (overloaded term) (#21943)
  • For AdSense, expect checksum to be a 32-bit integer that is not base-64 encoded. (#21716)
  • 🐛Propagate data-ad-host attribute to ad url param for amp-auto-ads (#22092)
  • 📖 amp-recaptcha-input: Added amp.dev example (#21834)

Breakdown by component

ads Reformat beaverads contribution (#22396) Intent To Implement: BeaverAds support for amp-ads (#22281)
amp-a4a Remove amp-consent experimental flag (#22306) amp-consent: Allowed passing the consent string through a macro (#22299)
amp-access Fixes typo in amp-access and amp-subscriptions docs (#22363)
amp-accordion 🐛Fix flicker when opening an animated accordion. (#22399)
amp-ad Intent To Implement: BeaverAds support for amp-ads (#22281) Differentiate 'render-start' msg and RENDER_START signal (#22305)
amp-ad-custom Add validation rules for (#22289)
amp-ad-network-doubleclick-impl Remove position: absolute when measuring fluid creative height. (#22242)
amp-analytics Add referrer presence signals to the config rewriter varGroups. (#22365) allow cookie writer macros (#22388) 🐛Fix variable service race. (#22375) Add separate iframe transport URLs for Canary (#22296) ♻️Move VariableService to doc level #2 (#22300) Enable linker for AMP.navigateTo (#22361) Remove unnecessary service stubs in linker-manager-test (#22356) 📖 AMP analytics docs: Correct format support (-email, +stories) (#22338) Write cookies to eTLD+1 (#22255)
amp-auto-ads 🐛Fix usage of `getElementsByTagName` on ShadowRoot. (#22290)
amp-autocomplete 📖 Fix formatting issues in extension docs and add missing front-matter (#22351) 🐛Update failing autocomplete e2e test (#22250)
amp-base-carousel 🏗 Skip failing e2e tests and set retry to 2 (#22390)
amp-connatix-player 📖 Connatix Player extension: fix broken documentation page (#22311)
amp-consent Rename consentState to consentStateValue (#22308) Add dirtyBit support to stored consent value (#22257)
amp-date-picker fix wrong data event Select amp-date-picker range (#22408)
amp-dynamic-css-classes Rename waitForBody to waitForBodyOpen (#22347)
amp-experiment amp-experiment 1.0: Added a 15KB limit on amp-experiment JSON (#22372) Rename waitForBody to waitForBodyOpen (#22347) Use DOMReady (bodyComplete) signal where necessary (#22344)
amp-form 🏗 Skip failing e2e tests and set retry to 2 (#22390) 📖 Fix formatting issues in extension docs and add missing front-matter (#22351) amp-form: Reduce typecasts, clean up (#22298)
amp-geo Rename waitForBody to waitForBodyOpen (#22347) Use DOMReady (bodyComplete) signal where necessary (#22344)
amp-gist 📖 Fix formatting issues in extension docs and add missing front-matter (#22351)
amp-gwd-animation Rename waitForBody to waitForBodyOpen (#22347) Use DOMReady (bodyComplete) signal where necessary (#22344)
amp-inputmask 📖 Fix formatting issues in extension docs and add missing front-matter (#22351)
amp-lightbox 📖 Add email to amp-lightbox supported formats (#22330)
amp-lightbox-gallery 📖amp-lightbox-gallery: update the broken example link (#22310)
amp-link-rewriter 📖 Fix formatting issues in extension docs and add missing front-matter (#22351) Use DOMReady (bodyComplete) signal where necessary (#22344)
amp-list 🏗 Skip failing e2e tests and set retry to 2 (#22390)
amp-mraid 📖 Fix formatting issues in extension docs and add missing front-matter (#22351)
amp-next-page amp-next-page: Fetch failure should be a user error (#22293)
amp-recaptcha-input 🐛amp-recaptcha-input: Removed the experimental blurb in the recaptcha reference docs (#22307)
amp-script Validator rollup (#22413) 🐛 `amp-script` Remove AMP cors requirement for author code (#22389)
amp-sidebar 🐛Fix sidebar open animation. (#22324)
amp-skimlinks Rename waitForBody to waitForBodyOpen (#22347)
amp-smartlinks 📖 Fix formatting issues in extension docs and add missing front-matter (#22351) Use DOMReady (bodyComplete) signal where necessary (#22344)
amp-sticky-ad Rename waitForBody to waitForBodyOpen (#22347)
amp-story Fix story render service during prerendering. (#22346) Introduce LiveStoryManager (#22273) Use DOMReady (bodyComplete) signal where necessary (#22344) 🐛 Add max width to amp-twitter (#22334)
amp-subscriptions Fixes typo in amp-access and amp-subscriptions docs (#22363) ♻️ SwG Crypto naming change: "keys" -> "cryptokeys" (#22272)
amp-viewer-integration 🏗 Clean up `.eslintignore` (#22411)
validator Validator rollup (#22413) - cl/249265307 Revision bump for #22372 - cl/249156543 Allow amp-script with an experiment token. - cl/248381896 Revision bump for #22289

🏗🚮 Simplify the way gulp lint works on Travis (#22294)
Over the past year, various lint rules were added to improve AMP's code correctness. For example, #14742, #12748, #15255, #14761. In addition, lint checks were enabled for the code in validator/, which is developed in a different repo and periodically synced to amphtml. See #18601 and #13966.

As a result, gulp lint is run only against the files edited by a PR during PR builds, while hundreds of linter warnings are printed during push builds.

This PR does the following:

  • Silences 200+ outstanding linter warnings for amphtml-internal/prefer-deferred-promise, amphtml-internal/unused-private-field, and amphtml-internal/vsync, and for the validator/ directory
  • Updates lint.js to lint all files during Travis PR and push builds
  • Paves the way for #21212 by starting with a clean slate of linter errors

Follow up tasks:

  • Fix remaining amphtml-internal/prefer-deferred-promise, amphtml-internal/unused-private-field, and amphtml-internal/vsync errors and re-enable the rules in error mode (#14742, #12748)
  • Fix lint errors in validator/ and re-enable all rules in validator/.eslintrc (#18601, #13966)
    Validator Rollup (#22286)
    cl/248060156 Revision bump for #21909
Assets 2

@ampprojectbot ampprojectbot released this May 14, 2019

Version: 1905140117570

Baseline: 1905071607430

  • Add dirtyBit support to stored consent value (#22257)
  • Write cookies to eTLD+1 (#22255)
  • 🏗🐛 Run tests against minified code during PR checks (#22263)
  • Remove position: absolute when measuring fluid creative height. (#22242)
  • 🐛 Store the native getBoundingClientRect before patching (#22269)
  • 🏗♻️ Refactor post-compilation config writes (#22256)
  • Override global scrollTo in iOS embed cases (#22244)
  • 🚮 Remove support for xhr identity attribute "cross-origin". (#21909)
  • 🚀 Use a multislot request for pubmine ads (#21781)
  • 🏗♻️🚮🐛 Refactor compile() in build-system/tasks/helpers.js (#22254)
  • 🐛 web-worker: Set error reporter (#21855)
  • Support dynamically added lists and add configuration options (#21778)
  • Support for Idealmedia (#22102)
  • 🐛Update failing autocomplete e2e test (#22250)
  • amp-consent: Added support for allowing CMPs to add their own documentation and examples for amp-consent (#21752)
  • 🏗 Re add IE11 to our CI in blocking mode (#22248)
  • Support for Lentainform (#22101)
  • Support for MGID (#22100)
  • 🏗 Clean up describes-e2e (#22206)
  • Validator rollup (#22236)
  • 🏗🐛 Rename version to internalRuntimeVersion in AmpPass.java (#22234)
  • validator.amp.dev is live, update links (#22231)
  • 🏗🚮 Use compiler.jar instead of runner.jar for single pass, remove unnecessary code (#22056)
  • repace version() calls with the version string literal (#22216)
  • 🖍🐛 Lightbox captions changes. (#22189)
  • Experiment to disable transfer layer in 12.2 and above (#22223)
  • 📦 Update dependency gulp to v4.0.2 (#22157)
  • 📦 Update dependency codecov to v3.4.0 (#22211)
  • 📦 Update dependency @octokit/rest to v16.25.3 (#22190)
  • SwG Release 0.1.22.50 (#22226)
  • Add allow-blocked-end-date flag and e2e test (#22029)
  • 🏗 Retry tests before failing them on Travis (#22210)
  • 🏗 Enable integration testing on IE11 (#21667)
  • Implementing subscriptions encryption to work with the Viewer (#22058)
  • Revert "♻️Move VariableService to doc level (#22137)" (#22218)
  • Revert "♻️Move VariableService to doc level" (#22218)
  • amp-bind: Update textarea initial value via [defaultText] (#22205)
  • 🚮 Delete auto ads responsive experiment from experiments.js (#22191)
  • Skip flaky A4A test (#22165)
  • amp-consent: consent-ui Allow passing in the reason for prompt in the iframe name attribute (#21647)
  • 🏗♻️Refactor compileJs into smaller functions (#22147)
  • 🐞Fix dev server shadow mode. (#22207)
  • amp-script: Share size limit across elements (#22083)
  • 🍎 🐛 amp-lightbox: prevent iOS scroll freeze in both directions. (#22199)
  • 🌐 Support RTL inputs and datasets on amp-autocomplete (#22128)
  • Add support for mask-trim-zeros attribute on amp-inputmask. (#22175)
  • Update validator output due to changed message. (#22196)
  • Allow SVG elements in Stories. (#22187)
  • Validator rollup (#22188)
  • Skip all amp-skimlinks integration tests. (#22181)
  • 🖍🚀🐛support for CAaja ads network (#21671)
  • Docs: remove "experimental" (overloaded term) (#21943)
  • For AdSense, expect checksum to be a 32-bit integer that is not base-64 encoded. (#21716)
  • 🐛Propagate data-ad-host attribute to ad url param for amp-auto-ads (#22092)
  • 📖 amp-recaptcha-input: Added amp.dev example (#21834)

Breakdown by component

ads Support for Idealmedia (#22102) Support for Lentainform (#22101) Support for MGID (#22100)
amp-3d-gltf Validator rollup (#22188)
amp-3q-player Validator rollup (#22188)
amp-access Validator rollup (#22188)
amp-accordion Validator rollup (#22188)
amp-action-macro Validator rollup (#22188)
amp-ad Support for Idealmedia (#22102) Support for Lentainform (#22101) Support for MGID (#22100) Validator rollup (#22188)
amp-ad-exit Validator rollup (#22188)
amp-ad-network-doubleclick-impl Remove position: absolute when measuring fluid creative height. (#22242)
amp-analytics Write cookies to eTLD+1 (#22255) repace version() calls with the version string literal (#22216) Revert "♻️Move VariableService to doc level" (#22218) Validator rollup (#22188)
amp-anim Validator rollup (#22188)
amp-animation Validator rollup (#22188)
amp-apester-media Validator rollup (#22188)
amp-app-banner Validator rollup (#22188)
amp-audio Validator rollup (#22188)
amp-auto-ads Validator rollup (#22188) 🐛Propagate data-ad-host attribute to ad url param for amp-auto-ads (#22092)
amp-autocomplete 🐛Update failing autocomplete e2e test (#22250) 🌐 Support RTL inputs and datasets on amp-autocomplete (#22128) Validator rollup (#22188)
amp-base-carousel Validator rollup (#22188)
amp-bind amp-bind: Update textarea initial value via [defaultText] (#22205) Validator rollup (#22188)
amp-bodymovin-animation Validator rollup (#22188)
amp-brid-player Validator rollup (#22188)
amp-brightcove Validator rollup (#22188)
amp-consent Add dirtyBit support to stored consent value (#22257)
amp-fx-flying-carpet Added note about ads and flying carpets (#22186)
amp-inputmask Add support for mask-trim-zeros attribute on amp-inputmask. (#22175)
amp-lightbox 🍎 🐛 amp-lightbox: prevent iOS scroll freeze in both directions. (#22199)
amp-lightbox-gallery 🖍🐛 Lightbox captions changes. (#22189)
amp-recaptcha-input repace version() calls with the version string literal (#22216)
amp-story Update validator output due to changed message. (#22196) Allow SVG elements in Stories. (#22187)
amp-viewer-integration validator.amp.dev is live, update links (#22231)
validator Validator rollup (#22236) - cl/247510905 Revision bump for #22205 - cl/247285377 Revision bump for #22175 - cl/247283168 Revision bump for #22187 validator.amp.dev is live, update links (#22231) Update validation links for the Validator Web UI from validator.ampproject.org to validator.amp.dev now that validator.amp.dev is live. amp-bind: Update textarea initial value via [defaultText] (#22205) Fixes #21053.
Assets 2
You can’t perform that action at this time.