Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sitemap 404 #2262

Merged
merged 2 commits into from Jun 7, 2019
Merged

Fix sitemap 404 #2262

merged 2 commits into from Jun 7, 2019

Conversation

tharders
Copy link
Collaborator

@tharders tharders commented Jun 5, 2019

The sitemap.xml which is mentioned in the robots.txt results in a 404
https://amp.dev/sitemap.xml
Also the grow generated sitemap is not served.
https://amp.dev/sitemap_grow.xml

This PR fixes those issues.

Copy link
Collaborator

@sebastianbenz sebastianbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow - that's bad! Good that you discovered this!

One comment.

platform/lib/routers/pages.js Outdated Show resolved Hide resolved
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Jun 7, 2019
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@sebastianbenz sebastianbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One nit!

platform/lib/routers/pages.js Outdated Show resolved Hide resolved
@tharders tharders merged commit 18d7300 into future Jun 7, 2019
@matthiasrohmer matthiasrohmer deleted the fix/sitemap-404 branch June 23, 2019 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants