Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: AMP element limits #4

Open
johnbarr opened this issue Jun 18, 2019 · 3 comments

Comments

@johnbarr
Copy link

@johnbarr johnbarr commented Jun 18, 2019

As discussed in the June 14 2019 WG meeting we would like to add element limits to the AMP validator.

In accordance with how other AMP validator changes are made we should begin restrictive and become more permissive over time. As such we propose the following AMP element limits which permit the vast majority of AMP4Email in Gmail today:

Element Proposed limit
amp-state 5
amp-form 20
amp-anim 200
amp-img 200
amp-list 20

Also we should combine amp-anim and amp-img limits together as they're basically the same element.

@fstanis

This comment has been minimized.

Copy link

@fstanis fstanis commented Jun 18, 2019

  1. Is it fair to assume elements not listed here have no limits?

  2. Is there a "rule of thumb" to decide the limits we'll impose on new elements we add in the future? Or should this be strictly case by case basis?

@johnbarr

This comment has been minimized.

Copy link
Author

@johnbarr johnbarr commented Jun 18, 2019

  1. Correct.

  2. Limit elements which require a lot of resources to "reasonable" limits. Mostly network resources right now. You could also expect limits on other intensive AMP components which get added later (hypothetically amp-video, etc...).

@choumx

This comment has been minimized.

Copy link
Collaborator

@choumx choumx commented Jul 17, 2019

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.