Skip to content
This repository has been archived by the owner on Nov 16, 2021. It is now read-only.

wg-bento Status Update 2020-11-23 #47

caroqliu opened this issue Nov 23, 2020 · 0 comments

wg-bento Status Update 2020-11-23 #47

caroqliu opened this issue Nov 23, 2020 · 0 comments


Copy link

What was accomplished

  • amp-accordion:
    • external API restructure
    • accessibility attributes
  • amp-base-carousel snap-align feature to view slides either at start or center of carousel viewport
  • amp-lightbox initial implementation
  • amp-selector:
    • keyboard-select-mode feature for Arrow key navigation and selection configuration
    • Preact unit tests
  • Ongoing fixes for resource loaders and intersection observers
  • Imperative API design and discussion
  • Documentation written for amp-instagram, amp-youtube, amp-lightbox
  • Removed viewportCallback from BaseElement
  • PR deploy bot integration with Storybook

Lessons learned

  • You can run Preact Devtools in Storybook by adding import 'preact/debug'; to the start of the story.
  • We make sure hidden is display:none in AMP but it is much more fragile (overridable) to use it in Bento mode.

What's next

  • Finalizing dev preview feature set and planning for beta
  • Continued progress on imperative API
  • amp-accordion:
    • display locking
    • final touches
  • amp-base-carousel:
    • e2e tests
    • orientation feature to configure the carousel as horizontal or vertical scrolling
    • dir="rtl" support
  • amp-selector integration with forms
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

No branches or pull requests

2 participants