Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wg-ui-and-a11y Status Update 2020-12-02 #68

rbeckthomas opened this issue Dec 2, 2020 · 4 comments

wg-ui-and-a11y Status Update 2020-12-02 #68

rbeckthomas opened this issue Dec 2, 2020 · 4 comments


Copy link

What was accomplished

  • Design doc for amp-render completed, design review on 12/02
  • Code complete for Serving NPA ads (publishing in Q1 2021
  • amp-ima-video bugfixes
  • amp-fit-text accessibility fix in review

What's next

  • Begin implementing amp-render after getting feedback from design review
  • Begin design for amp-list v2
  • Working on finalizing design for granular consent
  • Working on e2e test for amp-fit-text a11y update
  • Update from GA4 team coming 12/4
Copy link

Any chance to influence amp-list v2? We have a previously reported issue that might be a candidate for resolution in V2.

Copy link

samouri commented Dec 7, 2020

We have a previously reported issue that might be a candidate for resolution in V2.

Which issue? Can you link to it? Is it a candidate for being fixed in V1 as well?

Copy link

@samouri Here it is: ampproject/amphtml#23675
The WaPo link is broken. But the idea is simple. Think this way: a dictionary of terms, one endpoint for each term. Then, for a given page, use only the term needed for (a paragraph). We might use one structure on many pages. The WaPo implementation was an image and the player performance stats. Rather than managing one structure of all players, and then using a hop operator to localize the specific player for display (via amp-mustache), the WaPo design was one player : one end-point. This approach is similar to the PubChem approach for chemicals. I can fetch the specific chemical i need; do not have to load the entire PubChem endpoint and then hop to the target chemical. But amp-list cannot be used inline (e.g. in a span) as it forces a line break.

Our request: remove the line-break caused by amp-list. Then we can build dictionaries of terms, not have to have a dictionary of all terms.

Copy link

@samouri Here is another (suspect) issue with amp/state/list/mustache: ampproject/amphtml#31532
It appears that some CSS can break amp/state/list/mustache injection and formatting. Do you see a user error in the third example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

No branches or pull requests

4 participants