Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update METADATA.yaml #64

Closed
wants to merge 4 commits into from
Closed

Update METADATA.yaml #64

wants to merge 4 commits into from

Conversation

robinvanopstal
Copy link
Contributor

No description provided.

Copy link

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhouyx for approval.

METADATA.yaml Outdated Show resolved Hide resolved
Co-authored-by: Raghu Simha <rsimha@amp.dev>
@google-cla
Copy link

google-cla bot commented Oct 14, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@kristoferbaxter
Copy link
Contributor

The Google bot is confused by the Github suggestions tool. I'll merge this since I (a Googler with signed CLAs) was the one to merge this suggestion.

METADATA.yaml Outdated Show resolved Hide resolved
METADATA.yaml Outdated Show resolved Hide resolved
@google-cla
Copy link

google-cla bot commented Oct 16, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Oct 16, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@robinvanopstal
Copy link
Contributor Author

@googlebot I fixed it.

@CLAassistant
Copy link

CLAassistant commented Oct 22, 2020

CLA assistant check
All committers have signed the CLA.

@rsimha
Copy link

rsimha commented Oct 22, 2020

@robinvanopstal Sorry about the CLA noise. We recently switched from Google to OpenJS. If you respond to the last comment and sign the CLA, all your PRs should be in good shape.

@robinvanopstal
Copy link
Contributor Author

@googlebot I fixed it.

Copy link

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up!

login: nainar
name: Naina Raisinghani
login: zhouyx
name: Yuxuan Zhou
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yuxuan has left the team. The updated membership can be found at https://github.com/ampproject/wg-components.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The facilitator listed for the group at the link above is @micajuine-ho FYI

title: Components
merged:
- ui-and-a11y
description: wg-components Working Group is responsible for AMP components, the overall health of AMP Pages, analytics features, and integrations with partner technologies. For overall accessibility, this group is also the first point of contact, however each WG is responsbile for ensuring accessibility within their areas of responsibility.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: wg-components Working Group is responsible for AMP components, the overall health of AMP Pages, analytics features, and integrations with partner technologies. For overall accessibility, this group is also the first point of contact, however each WG is responsbile for ensuring accessibility within their areas of responsibility.
description: wg-components Working Group is responsible for AMP components, the overall health of AMP Pages, analytics features, and integrations with partner technologies.

- item: "UI Working Group will post **Quarterly Roadmap** as an issue labeled with `Type: Roadmap` in this repository."
- item: "Components Working Group will post **Status Updates** every two weeks as an issue labeled with `Type: Status Update` in this repository."
- item: "Components Working Group will post **Announcements and Notices** regarding events as an issue labeled with `Type: Event` in this repository."
- item: "Components Working Group will post **Quarterly Roadmap** as an issue labeled with `Type: Roadmap` in this repository."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- item: "Components Working Group will post **Quarterly Roadmap** as an issue labeled with `Type: Roadmap` in this repository."
- item: "Components Working Group will post **Quarterly Roadmap** as an issue labeled with `Type: Roadmap` in this repository."
- item: "Components Working Group will post **Monthly Office Hours** as an issue labeled with `Type: Meeting` in this repository."

Comment on lines -9 to -10
- login: alanorozco
name: Alan Orozco
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep Alan here.

name: Daniel Young
- login: joneleven
name: Jonathan Leventhal
- login: micajuine-ho
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- login: micajuine-ho
- login: caroqliu
name: Caroline Liu
- login: dmanek
name: Dhruv Manek
- login: micajuine-ho

@caroqliu
Copy link

caroqliu commented Jun 7, 2021

@micajuine-ho Can you please review/merge when this is ready? Doesn't look like I have the permissions :)

@micajuine-ho
Copy link

I don't have write permission either. @kristoferbaxter Can you take a look?

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants