Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wg-infra Status Update 2020-08-31 #40

Open
rsimha opened this issue Aug 31, 2020 · 2 comments
Open

wg-infra Status Update 2020-08-31 #40

rsimha opened this issue Aug 31, 2020 · 2 comments

Comments

@rsimha
Copy link
Collaborator

rsimha commented Aug 31, 2020

What was accomplished

  • Improvements to guts of visual testing
  • Improvements to workflow for generating github releases
  • AMP can now be built and tested on Windows
  • Discovered cause of test flakes on Safari (incomplete iframe cleanup)
  • Investigated code coverage for minified builds

What's next

  • Planning for improvements to CI pipeline
  • Instrument minified builds, augment dev server middleware
  • Continue work on in-flight projects mentioned above
@jaygray0919
Copy link

jaygray0919 commented Sep 1, 2020

What does this mean:

AMP can now be built and tested on Windows

Is there an explanatory link?

@rsimha
Copy link
Collaborator Author

rsimha commented Sep 1, 2020

@jaygray0919 Doing a minified compilation of AMP (gulp dist) and running tests (gulp unit, gulp integration, etc.) on Windows was never properly tested / supported. This has changed, and we now build code and run tests on Windows for every PR. You can find details and usage examples in ampproject/amphtml#29115 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants