Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

wg-stories Status Update 2022-02-14 #96

Open
processprocess opened this issue Feb 14, 2022 · 0 comments
Open

wg-stories Status Update 2022-02-14 #96

processprocess opened this issue Feb 14, 2022 · 0 comments

Comments

@processprocess
Copy link

processprocess commented Feb 14, 2022

What was accomplished

Story video

  • 馃殌 Use the inlined video response instead of issuing an XHR request, for the 1st video of the 1st web story page #37499

Story documentation

  • 馃摉 Fix page attachment docs location #37669

amp story page attachment

  • 馃枍锔 Box shadow on header #37579
  • 馃悰 fix attribute typo on CTA active toggle #37633

amp story shopping

  • Product tag functionality #36734
  • Attachment template logic #36735
  • PLP template logic #36736
  • PDP template logic #36738
  • PDP carousel #37091
  • 馃悰 Do not render shopping CTA if no shopping tags are on the page #37503
  • 鉁 Move i18n CTA label logic into shopping-attachment component #37515
  • 鈾伙笍 Rename tag-id to product-id #37527

Others

  • 馃枍 Added shopping tag flip on too far position to the right #37195
  • 鉁╝dded camelCase to amp-story-shoppping component #37533
  • 馃悰 amp-story-shopping Added correct margins for RTL mode #37568

What's next

  • Shopping Dev Preview
  • Amp story subscriptions (paywall)
  • Performance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant