capture :status_code and :raw_body #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API request errors are not returning the body of the response when it is not in JSON format. I reordered the lines so that the status code and raw body are captured before attempting to parse the json
|
And thanks for catching this |
|
I'll merge this as is for now. If you feel inclined, please to send another PR w/ a test case. Otherwise I'll try to add one later. |
amro
added a commit
that referenced
this pull request
Mar 16, 2016
capture :status_code and :raw_body
|
@amro @shayfrendt will look into as soon as I get a chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API request errors are not returning the body of the response when it is not in JSON format.
I reordered the lines so that the status code and raw body are captured before attempting to parse the json