New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

midi.h has midi cc bank select msb and lsb numbers reversed #116

Closed
msg opened this Issue Dec 30, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@msg

msg commented Dec 30, 2017

Expected behavior

From https://www.midi.org/specifications/item/table-3-control-change-messages-data-bytes-2

CC Bank Select MSB is number 0x00 and CC Bank Select LSB is number 0x20. In midi.h:

enum {
MIDI_CC_BANK_SELECT_LSB = 0x00,
MIDI_CC_MODULATION_WHEEL = 0x01,
MIDI_CC_DATA_ENTRY_MSB = 0x06,
MIDI_CC_PAN_MSB = 0x0A,
MIDI_CC_BANK_SELECT_MSB = 0x20,
...

These numbers are opposite of the midi specification.

Information

  • Which version of amsynth are you using? Latest github version.
  • Which build of amsynth are you using? stand-alone
  • If using amsynth as a plugin, which host application are you using?
  • Which operating system & version are you using? archlinux current

@nickdowell nickdowell self-assigned this Dec 31, 2017

@nickdowell

This comment has been minimized.

Show comment
Hide comment
@nickdowell

nickdowell Dec 31, 2017

Contributor

Well spotted - thanks!

Contributor

nickdowell commented Dec 31, 2017

Well spotted - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment