-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a parameter for ContentDialog.ShowAsync() to specify the target window #248
Conversation
How does that look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit, otherwise looks good, thanks!
Also, I'll do a formal deprecation/removal of ContentDialogPlacement
later in a separate PR so I won't worry here about preserving the optional parameter.
Could we also backport this to 1.4.4? So we could use this feature with our current version? |
This *should* be possible since its a fairly straight-forward change - but |
I thought the code for 1.4.4 for ContentDialog is the same as for master right now, so cherry-picking that commit should work, but if it's different and I'm misremembering then I'm not sure what the best approach would be. Thank you for helping us! :D |
#242 is the most recent change to ContentDialog which are v2 fixes only (theres a couple breaking changes and new APIs that rely on stuff added only in the v2 stuff), and there were a couple changes within |
Thank you very much! |
We are currently running into Linux specific issues with
ContentDialog
at Ryujinx, because for some reason our overlay window still hasIsActive == false
when ShowAsync() is called. On Windows it works fine, but on Linux we couldn't find a way to forceIsActive == true
even tho we were able to make sure it's true before we call ShowAsync().This is why I created this method. Using this method we get consistent behavior across all platforms and don't need to worry about
IsActive
. Usually we would just use a subclass ofContentDialog
for this, but since it accesses a lot of private variables, this wasn't really easy to do.I bet this method also has other usecases, but I figured it might be best to explain why this was needed in the first place.