Skip to content

Ios support #9

Closed
wants to merge 21 commits into from

3 participants

@Daij-Djan

restructured project to have 3 folders
common
=> the platform independent core: sources & resources

ios
=> iPhone/iPad App. And KissXML lib as a drop-in replacement for NSXMLDoc

osx
=> OSX App. And PTHotKey as before and original growl (btw 2.0 works fine here later. will send all to nc)


I made SubmitRadar a TAD easier to debug by splitting the MEGA method into four BIG methods

I 'tested' iOS and osx and they work as before and you can submit radars just fine. The most trouble was to get KissXML to parse the NSData to xml correctly. libxml2 is more strict on the iPhone and I had to implement some html fallbacks which I contributed to KissXML

Daij-Djan added some commits Jun 21, 2012
@Daij-Djan Daij-Djan app icon from @MichaelStache added
Signed-off-by: Dominik Pich <Dominik@pich.info>
1ea45f4
@Daij-Djan Daij-Djan @MichaelStache
Signed-off-by: Dominik Pich <Dominik@pich.info>
a4a4a3e
@Daij-Djan Daij-Djan restructure project and readied the data model for cross compilation …
…and added two apps (osx&ios)

I have added all functionality to iOS but haven't done any UI work

Signed-off-by: Dominik Pich <Dominik@pich.info>
0cdb2c8
@Daij-Djan Daij-Djan fixed a space in config.plist, moved file, added IOS IPAD Only GUI an…
…d included CTidy which is needed for html parsing on ios

Signed-off-by: Dominik Pich <Dominik@pich.info>
888b5b7
@Daij-Djan Daij-Djan broke up the MEGA method into 4 parts to make it a TAD more understan…
…dable to me.

Signed-off-by: Dominik Pich <Dominik@pich.info>
758cb58
@Daij-Djan Daij-Djan compensate for NSXMLDocuments that are in fact not errors but only wa…
…rnings

Signed-off-by: Dominik Pich <Dominik@pich.info>
f864b33
@Daij-Djan Daij-Djan KissXML extended to fallback to HTML
Signed-off-by: Dominik Pich <Dominik@pich.info>
2593e64
@Daij-Djan Daij-Djan path working on iOS.
both apps ready

Signed-off-by: Dominik Pich <Dominik@pich.info>
60e0269
@Daij-Djan Daij-Djan removed testing code
Signed-off-by: Dominik Pich <Dominik@pich.info>
c84b34d
@Daij-Djan Daij-Djan reverted to radar icon
Signed-off-by: Dominik Pich <Dominik@pich.info>
6121132
@Daij-Djan Daij-Djan Merge branch 'refs/heads/master' into IOS_support
Conflicts:
	osx/App/MenubarTemplate.png

Signed-off-by: Dominik Pich <Dominik@pich.info>
cf42615
@Daij-Djan Daij-Djan reverted icon credits
Signed-off-by: Dominik Pich <Dominik@pich.info>
05a3e00
@Daij-Djan Daij-Djan Merge branch 'refs/heads/master' into IOS_support 419e9e1
@Daij-Djan Daij-Djan made credits better markup and reverted icon
Signed-off-by: Dominik Pich <Dominik@pich.info>
04770cf
@Daij-Djan Daij-Djan added third party license files
Signed-off-by: Dominik Pich <Dominik@pich.info>
b2fa816
@Daij-Djan Daij-Djan 3rd party license file
Signed-off-by: Dominik Pich <Dominik@pich.info>
0ad535c
@Daij-Djan Daij-Djan repository icon
Signed-off-by: Dominik Pich <Dominik@pich.info>
04719cb
@Daij-Djan Daij-Djan Merge branch 'refs/heads/master' into IOS_support 913c5c7
@Daij-Djan Daij-Djan added missing tif
Signed-off-by: Dominik Pich <Dominik@pich.info>
870b055
@Daij-Djan Daij-Djan we should exclude this. sorry
Signed-off-by: Dominik Pich <Dominik@pich.info>
be5eaf3
@amyworrall
Owner

Heya! I've just been taking a look at this and it looks great, but I'm afraid it's going to take me a little more time before I can get it into the repository. This is partly because I'm not currently using beta Xcodes, so I can't work with the dictionary literals (something I intend to remedy soon, but I'm waiting until after the app I'm working on ships).

PDKeychainBindingsController and KissXML look really useful, especially the latter: being able to use the same NSXMLDocument methods on iOS will make things quite easy. I've done cross platform stuff before with just libXML, and it's somewhat painful!

I'm sorry my progress has slowed somewhat — it's a combination of job stuff (we're near to shipping an app) and trying to do a bit of a rewrite of the internals.

@Daij-Djan

bump ;) install the GM -- or I can remove the literals if you want :)

@tonyarnold

I know this was quite some time ago and this PR is probably invalid now (clloooossse it), but it's not good form to change the copyright to your name — legally, the copyright resides with Amy until she says otherwise, regardless of the size of the contribution.

@Daij-Djan

a) I don't care about the copyright - I didn't even pay attention - it is set to whoever created the file at first -- don't know why I renamed the license in later commit.
b) I think you can't really give away your copyright anyways (at least not under german law so I guess I could even write blabla .. but Im no lawyer (see a))
c) I just tried to help and don't appreciate your attitude (especially as nobody cared about this in the last year)

@tonyarnold

I feel pretty strongly about attribution — especially in OSS — and this PR caught my eye when I was scanning through last night. I didn't intend to insult you, so I'm sorry if I have.

@Daij-Djan Daij-Djan closed this Sep 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.