Semir Patel
analogue

Organizations

@Yelp
Jul 7, 2016
analogue commented on pull request Yelp/fido#38
@analogue

Fix-n-ship 👍

Jul 7, 2016
analogue commented on pull request Yelp/fido#38
@analogue

This all sounds good to me. I'm on the fence about the base class - it would help if you actually called out in the comments of the base class that…

Jul 7, 2016
analogue commented on pull request Yelp/fido#38
@analogue

Thanks for clarifying!

Jul 7, 2016
analogue commented on pull request Yelp/fido#38
@analogue

Having "Connection" in the name is potentially confusing with "Connect" and "HTTP" used in the same context. TBH, YAGNI - I see it isn't used in th…

Jul 7, 2016
analogue commented on pull request Yelp/fido#38
@analogue

Can you update the wording of this error since it covers more than just connection timeouts?

Jul 6, 2016
analogue commented on pull request Yelp/fido#38
@analogue

If the mapping is 1:1 between the twisted error and the fido error, why even have the fido error? It is no secret as to the dependency chain: Fido …

Jul 6, 2016
analogue commented on pull request Yelp/fido#38
@analogue

What is the difference between twisted.internet.error.ConnectError and https://github.com/twisted/twisted/blob/8c25f2c86652276474dfdc8fee70f159369b…

Jul 6, 2016
analogue commented on pull request Yelp/fido#38
@analogue

@sjaensch I'd consider this a non-backwards compatible change in interface. Shouldn't a major version bump be necessary here?

Jul 6, 2016
analogue commented on pull request Yelp/fido#38
@analogue

Can you speak a little to the need for these exceptions and why the current code (except for the more specific chance to use TwistedConnectError) d…

Jun 23, 2016
analogue commented on pull request striglia/pyramid_swagger#169
@analogue

This is a sticky problem to solve in a sustainable way. I wouldn't want to rely on the old behaviour unless you have no other option. Note that thi…

Jun 9, 2016
analogue commented on issue Yelp/paasta#376
@analogue

Why not focus resources on adding this support to marathon? Will this work be obviated when marathon eventually supports maintenance mode primitives?

Jun 3, 2016
analogue commented on issue Yelp/bravado#229
@analogue

fyi, @jnb and @prat0318 discussed something similar (or was it exactly the same) with reasons for/against. maybe their findings were documented som…

May 29, 2016
@analogue
  • @analogue d47649e
    Add requirements.txt; Download blocklists on startup; update to be co…
May 24, 2016
@analogue

I believe this is only used in the context of a parameter_object_spec. https://github.com/Yelp/bravado-core/search?utf8=%E2%9C%93&q=is_required Fee…

May 24, 2016
analogue pushed to master at Yelp/fido
@analogue
May 24, 2016
analogue merged pull request Yelp/fido#35
@analogue
Correctly conditional depend on futures
1 commit with 8 additions and 12 deletions
May 24, 2016
analogue commented on pull request Yelp/fido#35
@analogue

lgtm

May 24, 2016
@analogue
May 24, 2016
analogue merged pull request Yelp/bravado#224
@analogue
Pinpoint fido version
1 commit with 1 addition and 1 deletion
May 24, 2016
analogue commented on pull request Yelp/bravado-core#95
@analogue

Would be awesome if you could add a unit test for this here.

May 24, 2016
analogue commented on pull request Yelp/bravado-core#93
@analogue

Sorry for the delay, I'm not getting my github email notifications for some reason :frown:

May 24, 2016
@analogue
May 24, 2016
analogue merged pull request Yelp/bravado-core#93
@analogue
Update README to reference OpenAPI instead of Swagger.
1 commit with 3 additions and 2 deletions
May 16, 2016
@analogue

Agreed that the validation process should not mutate the passed in spec_dict. Will have to make sure that this has no adverse effects on the librar…

May 16, 2016
analogue opened issue Yelp/bravado#221
@analogue
Make it super easy to wrap SwaggerClient to add new features
May 16, 2016
analogue closed issue Yelp/bravado#215
@analogue
$ref to local files
May 16, 2016
analogue commented on issue Yelp/bravado#217
@analogue

Good idea. We can create an alias in a backward-compatible minor point release with SwaggerClient marked as deprecated. Then, remove SwaggerClient

May 16, 2016
analogue commented on issue Yelp/bravado#220
@analogue

Wrap SwaggerClient to return a wrapped Resource that injects the headers via _request_options when the service call is made.

Apr 27, 2016
analogue commented on issue Yelp/bravado#215
@analogue

Yes, multiple files are supported. See https://github.com/OAI/OpenAPI-Specification/blob/master/guidelines/REUSE.md for examples.