feat: Working ably connections #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace custom WebSocket SignallingClient with Ably Realtime implementation - Remove heartbeat logic as Ably handles connection health automatically - Update ClientConfigResponse to use ablyToken and ablyChannel - Hardcode Ably channel rewind parameter to 100 messages - Defer connection initialization to connect() method for better resource management - Add proper error handling for uninitialized connections - Remove message buffering in favor of explicit connection errors - Add Ably SDK v2.9.0 dependency 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
…for new signalling channel
ao-anam
previously approved these changes
Jul 21, 2025
ao-anam
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Other PRs have been merged into Alpha that comprised a subset of this functionality.
This PR switches the signalling method to use Ably rather than a direct websocket connection to our datacentre.
This gives us greater reliability, potential connection speed increases, and http fallback in cases where web-sockets are inaccessible.
Signalling methods follow the existing patterns and event emitters, tokens to connect to Ably are passed from the Anam backend.