Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for authoring TypeScript targeted for Deno #381

Closed
zeusdeux opened this issue May 27, 2020 · 8 comments · Fixed by #382
Closed

Support for authoring TypeScript targeted for Deno #381

zeusdeux opened this issue May 27, 2020 · 8 comments · Fixed by #382

Comments

@zeusdeux
Copy link
Contributor

zeusdeux commented May 27, 2020

Given that Deno v1 is out which supports typescript natively, is there a plan to add support for the way things are imported in a typescript file meant for the Deno runtime? (I.e., file extension for for imports and http imports)

@zeusdeux zeusdeux changed the title Support for bare url imports Support for authoring TypeScript targeted for Deno May 27, 2020
@ananthakumaran
Copy link
Owner

ananthakumaran commented May 27, 2020

Tide depends on tsserver for all editor functionalities. The feature request should be made to typescript repo

@zeusdeux
Copy link
Contributor Author

zeusdeux commented May 27, 2020

I believe the version of tsserver internal to deno supports it. That’s what the vscode deno plugin uses. Same could be leveraged here right?

@zeusdeux
Copy link
Contributor Author

zeusdeux commented May 28, 2020

Wait, nope I’m wrong. It uses the typescript-deno-plugin to power autocomplete, etc.

@ananthakumaran
Copy link
Owner

ananthakumaran commented May 28, 2020

@zeusdeux
Copy link
Contributor Author

zeusdeux commented May 28, 2020

Yeah, lemme give that go tonight! Will post here after.

@zeusdeux
Copy link
Contributor Author

zeusdeux commented May 28, 2020

So, it Just Works!!

Wrote about it here -> https://til.mudit.xyz/47

@zeusdeux
Copy link
Contributor Author

zeusdeux commented May 28, 2020

PR-Ed on deno docs as well.

Edit: landed

@josteink
Copy link
Collaborator

josteink commented May 29, 2020

Nice work!

To make it more discoverable for regular users, maybe you could open a PR for our readme here, add a Deno-section and make that link to the official docs you talk about?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants