Leave company-backends for the user to setup

[alanpearce]

Loading tide.el has the side-effect of adding the completion backend to company-backends with no configuration option. The user may however not wish to use company-tide, or not have it as the first backend.

Other company packages do not mangle company-backends, instead documenting the code to add their backend, to allow the user to add the backends in their preferred order (examples: 1, 2, 3). I therefore propose this change to follow this convention.

[josteink]

This will be a breaking change/upgrade for most tide-users, which (for me personally) makes it a no-go.

While I can't speak for the other contributors, but if you could come up with some suggestions for how we can eliminate this causing breaking changes, that would definitely increase the chance of this getting merged.

[ananthakumaran]

company-mode/company-mode#923 (comment) from this comment, it seems like updating company-backends from third party package is not the correct approach. But unfortunately, as @josteink pointed out, this code has been there from the beginning and going to break nearly all the existing users' setup which I prefer not to do. We can't merge this PR unless we come up with a solution that doesn't break the existing setup.

[josteink]

This looks good to me. What do you think, @ananthakumaran ?

[ananthakumaran]

LGTM

…

On Sun, Mar 28, 2021, 12:21 AM Jostein Kjønigsen ***@***.***> wrote: ***@***.**** approved this pull request. This looks good to me. What do you think, @ananthakumaran <https://github.com/ananthakumaran> ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#384 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABEN5TJ7H6QDK6RAJ7CH2LTFYSJVANCNFSM4OQMYBKQ> .

[josteink]

Merged!

[alanpearce]

Thanks for re-reviewing and merging so quickly! Sorry I didn't get around to addressing your feedback for... a while.

[josteink]

Np. A patch is a patch, and GitHub makes sure we can pick it up anytime, even 9 months later 😀