Fix tide-rename-file bug on new buffer name;#409
Merged
ananthakumaran merged 1 commit intoananthakumaran:masterfrom Dec 23, 2020
Merged
Fix tide-rename-file bug on new buffer name;#409ananthakumaran merged 1 commit intoananthakumaran:masterfrom
ananthakumaran merged 1 commit intoananthakumaran:masterfrom
Conversation
fixes ananthakumaran#408: If the new name of a buffer clashes with an opened buffer then tide-rename-file stops and doesn't apply after-rename-edits. Especially problematic because tide leaves buffers open as it applies code edits.
Owner
|
Thanks for debugging the issue. I have uniquify buffer enabled, which seem to do this automatically, because I never ran into the problem while testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #408:
If the new name of a buffer clashes with an opened buffer then
tide-rename-file stops and doesn't apply after-rename-edits.
Especially problematic because tide leaves buffers open as it applies
code edits.