Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Improve styling of code elements (for benefit of README.md backtick (… 
…code) markup)

Fix Bug420462
--Signed-off-by: Adrian Aichner <adrian.aichner@gmail.com>
  • Loading branch information
@anaran
anaran committed Nov 3, 2013
1 parent 16cc563 commit 661c2f9
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions bundles/org.eclipse.orion.client.ui/web/css/ide.css
View file
Expand Up @@ -49,6 +49,14 @@ button::-moz-focus-inner {
padding: 0;
}

pre>code {
display: inline-block;

This comment has been minimized.

Sign in to view

Copy link
@mamacdon

mamacdon Nov 4, 2013

I would prefer display:block here, to make the border occupy the entire width of the container (similar to GitHub's styling of fenced code blocks).
}

code {
border: 1px solid;

This comment has been minimized.

Sign in to view

Copy link
@mamacdon

mamacdon Nov 4, 2013

Let's add #D6EBF0 to make the border color match the container's border. A few px of padding might help also.
}

.navlink {
display: inline-block;
padding: 2px;
Expand Down

1 comment on commit 661c2f9

@mamacdon
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, 2 general things that I would like to see changed:

  1. Prefix the 2 selectors with .orionMarkdown. (We want these styles to target only the Orion Markdown viewer.)
  2. Move the 2 selectors to somewhere near lines 900-930 of ide.css, so they are near the other Markdown-related CSS rules.

Please sign in to comment.