anarcat / rt Public

This causes unneeded spam to the owner when we block access to a user
through the web interface.

This reverts commit 03d0af9.

Otherwise, "today" would be parsed as current real date instead of the
one set by Test::MockTime in RT::Date, which was loaded earlier than
Test::MockTime.

As it's already 2020, "2020-01-01" was not a future date any more
because of the above issue, which failed tests.

Remove the associated ObjectCustomFields entry instead of the CF.

Without the multipart/form-data encoding custom fields such as file uploads
will not be submitted, resulting in no change to the field.

We need to switch operator to "IS" or "IS NOT" for NULL values.

_HasModifyWatcherRight previously checked known rights cases
and returned false when the user didn't have rights for the
corresponding change. If nothing matched, the fall through return
value was true, which meant that any watcher change that didn't
match was allowed. All new custom roles won't match the existing
watcher type checks, so users could by default edit custom roles
even without ModifyTicket or ModifyQueueWatchers.

Reverse the logic to return true for know rights and types and
default to 0 for any unknown cases. At this point, ModifyTicket
is required to modify custom roles on tickets and
ModifyQueueWatchers on queues.

Tests custom role watchers on tickets and queues.

Especially to test if old values are correctly removed when necessary.

…of it

In cases where the $current_values iterator would run out of values
and return undef, the id call on $extra_item would cause an
"undefined value" exception. When called by a scrip, this causes
the scrip to die. It also left a dangling transaction when the Rollback
was not called, and this could cause the outer ticket transaction
to not commit properly.

Only remove extra CF values when $extra_values is positive.
Previously, $extra_values would often be negative when the
number of values is less than MaxValues, but the code to remove
values would still run. It would exit the loop only on error
when $extra_item was eventually undef.

We noticed that recent Outlook 365 for web automatically converts things
that look like a domain from example.com to http://example.com in
subject, which breaks our parsing ticket id logic.

This commit tolerates related regexes to allow http:// prefix.

Add some other values that might be useful in a callback also.

Fixes: I#34733