Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#9 HTTP 401 with preflight requests #15

Merged
merged 2 commits into from
Jan 19, 2024
Merged

#9 HTTP 401 with preflight requests #15

merged 2 commits into from
Jan 19, 2024

Conversation

geoffreyfourmis
Copy link
Contributor

@geoffreyfourmis geoffreyfourmis commented Jan 19, 2024 •
edited
Loading

resolve #9

anarsultanov
anarsultanov reviewed Jan 19, 2024
View reviewed changes
Copy link
Owner

@anarsultanov anarsultanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Looks great, just a few minor comments.

src/main/java/dev/sultanov/keycloak/multitenancy/resource/CorsResource.java Outdated Show resolved Hide resolved
src/main/java/dev/sultanov/keycloak/multitenancy/resource/CorsResource.java Outdated Show resolved Hide resolved
@geoffreyfourmis
Copy link
Contributor Author

Thx for your comments, I made the corrections

@anarsultanov
Copy link
Owner

Thanks for the prompt update @geoffreyfourmis!

@anarsultanov anarsultanov merged commit bd494eb into anarsultanov:main Jan 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anarsultanov anarsultanov anarsultanov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CORS issue when calling endpoints directly from my app
2 participants
@geoffreyfourmis @anarsultanov