Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spelling fixes #713

Merged

Conversation

Projects
None yet
3 participants
@maschmann
Copy link
Contributor

commented Sep 23, 2014

No description provided.

@CraigChilds94

This comment has been minimized.

Copy link
Member

commented Sep 23, 2014

Thank you haha

CraigChilds94 added a commit that referenced this pull request Sep 23, 2014

@CraigChilds94 CraigChilds94 merged commit 077ee46 into anchorcms:master Sep 23, 2014

@systimotic

This comment has been minimized.

Copy link

commented Sep 23, 2014

Why am I not getting any credit for this 😉

@CraigChilds94

This comment has been minimized.

Copy link
Member

commented Sep 23, 2014

Oh sorry, you get 90% for finding them ;)

@maschmann

This comment has been minimized.

Copy link
Contributor Author

commented Sep 23, 2014

I just read your comments before and thought to cause the least additional fuzz by just fixing my mistakes ;-)
Hopefully the guideline stuff is ok with you!

@systimotic

This comment has been minimized.

Copy link

commented Sep 23, 2014

Definitely, good guidelines make for good code, but I think you shouldn't be to strict.

@CraigChilds94

This comment has been minimized.

Copy link
Member

commented Sep 23, 2014

I agree 100%

@CraigChilds94

This comment has been minimized.

Copy link
Member

commented Sep 23, 2014

@maschmann Yeah the guideline stuff Is cool, I don't like pushing people to code like me, just as long as everyone can work with it

@maschmann

This comment has been minimized.

Copy link
Contributor Author

commented Sep 23, 2014

In my expirience so far, it's best to enforce one standard and stick with it. Normally it keeps the code at a minimum consistency level and therefore also more attractive for contributors.
Using an accepted standard also supports that ;-) Sometimes it's really annoying to point out styleguide violations, but in the end it's really rewarding.
ProTip: Local PHPCS, set to PSR-1/PSR-2 at level "warning" keeps the whole story at a good compromise level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.