From 73c56bb346688e9869882698d70d6d63c5902483 Mon Sep 17 00:00:00 2001 From: Alex Goodman Date: Thu, 9 Mar 2023 09:52:09 -0500 Subject: [PATCH] add more helpful wording around quality gate evaluations (#108) Signed-off-by: Alex Goodman --- .github/workflows/pr-quality-gate.yaml | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/.github/workflows/pr-quality-gate.yaml b/.github/workflows/pr-quality-gate.yaml index 687259bd..f76429f4 100644 --- a/.github/workflows/pr-quality-gate.yaml +++ b/.github/workflows/pr-quality-gate.yaml @@ -77,13 +77,18 @@ jobs: steps: - run: | echo "Validations Status: ${{ needs.validate-provider.result }}" - echo "Providers Changed: ${{ needs.select-providers.outputs.providers }}" + echo "Providers that require testing: ${{ needs.select-providers.outputs.providers }}" + echo if [ '${{ needs.select-providers.outputs.providers }}' == '[]' ]; then - echo "Quality gate not required: no providers changed" + echo "🟢 Quality gate passed! (no providers changed)" exit 0 fi if [ "${{ needs.validate-provider.result }}" != "success" ]; then - echo "Quality gate failed!" + echo "🔴 Quality gate FAILED! 😭" + echo + echo "This could happen for a couple of reasons:" + echo " - A provider test failed, in which case see the logs in previous jobs for more details" + echo " - A required provider test was skipped. You might need to add the 'run-pr-quality-gate' label to your PR to prevent skipping the test. exit 1 fi - echo "Quality gate passed!" + echo "🟢 Quality gate passed! (all tests passed)"