-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: short-lived grype-db cache #348
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Keith Zantow <kzantow@gmail.com>
e20e6c2
to
a944310
Compare
} | ||
|
||
// Add tool to path for this and future actions to use | ||
core.addPath(grypePath); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not technically a breaking change, since we did not advertise putting grype on the path, but I suspect it will break a number of users of the action who are expecting this behavior: particularly users of the download-action
, and if we remove this we should probably publish a new major version.
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
An update: we have deployed an updated CDN solution which we believe should have fixed database download issues. Please read more about it on Discourse |
This PR implements a short-lived cache of the grype database using the Github workflow cache.
If there are a substantial number of users of the action, this may help to spread out checks for grype-db over the day, and alleviate the overall number of requests, to help alleviate the sporadic issues we have seen lately with the CDN.
NOTE: Grype has another change which will result in some type of update interval check, this PR could/should leverage instead of having multiple ways to specify the update interval: anchore/grype#2005
Example runs (with cache in this repo):