Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove file noqa from rhel oval parser #361

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

willmurphyscode
Copy link
Contributor

This way, changes to this file will still get linted.

See #310

Switch to linter suppressions on individual lines so that the set of
suppressed rules stops growing. Accept some automatic fixes.

Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
@willmurphyscode willmurphyscode added the run-pr-quality-gate Triggers running of quality gate on PRs label Oct 24, 2023
@willmurphyscode willmurphyscode requested a review from a team October 25, 2023 12:58
Copy link
Contributor

@spiffcs spiffcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to get these files down to the direct issues that we can clean up eventually - thanks for the PR!

@willmurphyscode willmurphyscode merged commit c03bf3c into main Oct 25, 2023
9 checks passed
@willmurphyscode willmurphyscode deleted the chore/remove-file-noqa-rhel-oval-parser branch October 25, 2023 14:45
@wagoodman wagoodman removed the run-pr-quality-gate Triggers running of quality gate on PRs label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants