fix: respect GitHub rate limiting #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the client would repeatedly attempt requests until getting actually rate limited by GitHub. Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
willmurphyscode
added
the
run-pr-quality-gate
wagoodman
reviewed
Oct 30, 2023
| logger.debug(f"github rate limit has {remaining} requests left {reset_time}") | ||
| if remaining < 10: | ||
| current_time = int(time.time()) | ||
| sleep_time = reset_time - current_time |
There was a problem hiding this comment.
we should have a sensible cap here since we're sleeping based on user data (e.g. a min of 1 a max of 1 hour?)
wagoodman
approved these changes
Oct 30, 2023
Signed-off-by: Will Murphy <will.murphy@anchore.com>
…hub-rate-limit-headers
willmurphyscode
added
bug
|
Sorry for the label spam - I was experimenting with the changelog generator. |
willmurphyscode
removed
the
run-pr-quality-gate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the client would repeatedly attempt requests until getting actually rate limited by GitHub.
We saw a failure in the quality gate run for another PR that changed the GitHub provider: https://github.com/anchore/vunnel/actions/runs/6693756704/job/18185629045?pr=376#step:4:1530
GitHub's docs mention that failing to abide by these limits can result in escalated responses: https://docs.github.com/en/rest/guides/best-practices-for-using-the-rest-api?ref=retool-blog.ghost.io&apiVersion=2022-11-28#dealing-with-rate-limits