From 4c75c85729c4a60941025930c0487aef3637724a Mon Sep 17 00:00:00 2001
From: Arthur Belkhayat <arthur.belkhayat@gmail.com>
Date: Tue, 19 Dec 2023 15:08:14 +0100
Subject: [PATCH] =?UTF-8?q?fix:=20s=C3=A9mantique=20du=20code=20est=20resp?=
 =?UTF-8?q?ect=C3=A9e=20(#403)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* fix: change button and link for accessibilite

* fix: reverse data config

* fix: use span instead of bold beacon
---
 .../boutons-action/boutons-action.component.html             | 5 +++--
 .../erreur-form-modal/erreur-form-modal.component.html       | 2 +-
 .../send-by-email-modal/send-by-email-modal.component.html   | 5 ++++-
 .../orientation/pages/accessibilite/accessibilite.page.html  | 2 +-
 .../orientation/pages/localisation/localisation.page.html    | 2 +-
 5 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/src/features/cartographie/components/lieux-mediation-numerique-details/boutons-action/boutons-action.component.html b/src/features/cartographie/components/lieux-mediation-numerique-details/boutons-action/boutons-action.component.html
index aa780025..c0c0c8b5 100644
--- a/src/features/cartographie/components/lieux-mediation-numerique-details/boutons-action/boutons-action.component.html
+++ b/src/features/cartographie/components/lieux-mediation-numerique-details/boutons-action/boutons-action.component.html
@@ -37,7 +37,8 @@
     </button>
   </div>
   <div class="col">
-    <button
+    <a
+      role="button"
       type="button"
       class="btn btn-tile px-md-0 py-md-4 p-2 d-flex flex-md-column flex-row"
       (click)="sendByEmail.emit($event)">
@@ -45,6 +46,6 @@
         <span role="img" class="ri-mail-send-line" aria-hidden="true"></span>
       </span>
       <span class="mt-md-2 mb-md-0 ms-md-0 ms-2 fw-bold">Envoyer par mail</span>
-    </button>
+    </a>
   </div>
 </div>
diff --git a/src/features/cartographie/components/lieux-mediation-numerique-details/erreur-form-modal/erreur-form-modal.component.html b/src/features/cartographie/components/lieux-mediation-numerique-details/erreur-form-modal/erreur-form-modal.component.html
index 38274d8a..5432d25b 100644
--- a/src/features/cartographie/components/lieux-mediation-numerique-details/erreur-form-modal/erreur-form-modal.component.html
+++ b/src/features/cartographie/components/lieux-mediation-numerique-details/erreur-form-modal/erreur-form-modal.component.html
@@ -54,7 +54,7 @@
       Webinaires : Mettre à jour vos données
     </span>
   </a>
-  <button slot="footer" type="submit" form="erreurGroup" class="btn btn-primary">
+  <button role="link" slot="footer" type="submit" form="erreurGroup" class="btn btn-primary">
     <span role="img" class="ri-mail-send-line" aria-hidden="true"></span>
     Signaler l'erreur
   </button>
diff --git a/src/features/cartographie/components/lieux-mediation-numerique-details/send-by-email-modal/send-by-email-modal.component.html b/src/features/cartographie/components/lieux-mediation-numerique-details/send-by-email-modal/send-by-email-modal.component.html
index 9acb4dae..47087ed4 100644
--- a/src/features/cartographie/components/lieux-mediation-numerique-details/send-by-email-modal/send-by-email-modal.component.html
+++ b/src/features/cartographie/components/lieux-mediation-numerique-details/send-by-email-modal/send-by-email-modal.component.html
@@ -34,5 +34,8 @@
       </div>
     </div>
   </form>
-  <button slot="footer" type="submit" form="sendByEmailForm" class="btn btn-primary">Envoyer</button>
+  <button role="link" slot="footer" type="submit" form="sendByEmailForm" class="btn btn-primary">
+    <i class="ri-mail-send-line" aria-hidden="true"></i>
+    Envoyer
+  </button>
 </app-modal>
diff --git a/src/features/orientation/pages/accessibilite/accessibilite.page.html b/src/features/orientation/pages/accessibilite/accessibilite.page.html
index 06df6828..5254d3b9 100644
--- a/src/features/orientation/pages/accessibilite/accessibilite.page.html
+++ b/src/features/orientation/pages/accessibilite/accessibilite.page.html
@@ -73,7 +73,7 @@ <h1 class="h2 text-center fw-bold mt-sm-5 mt-3">
       </fieldset>
     </form>
     <div class="text-center mt-4">
-      <a class="btn btn-primary mx-3" [routerLink]="['..', 'disponibilite']" queryParamsHandling="preserve">
+      <a role="button" class="btn btn-primary mx-3" [routerLink]="['..', 'disponibilite']" queryParamsHandling="preserve">
         Suivant
         <span role="img" class="ri-arrow-right-s-line" aria-hidden="true"></span>
       </a>
diff --git a/src/features/orientation/pages/localisation/localisation.page.html b/src/features/orientation/pages/localisation/localisation.page.html
index 4088e58d..f71842ad 100644
--- a/src/features/orientation/pages/localisation/localisation.page.html
+++ b/src/features/orientation/pages/localisation/localisation.page.html
@@ -88,7 +88,7 @@ <h1 class="h2 text-center fw-bold mt-sm-5 mt-3">
       </div>
     </form>
     <div class="text-center mt-4">
-      <a class="btn btn-primary mx-3" [routerLink]="['..', 'accessibilite']" queryParamsHandling="preserve">
+      <a role="button" class="btn btn-primary mx-3" [routerLink]="['..', 'accessibilite']" queryParamsHandling="preserve">
         Suivant
         <span role="img" class="ri-arrow-right-s-line" aria-hidden="true"></span>
       </a>