Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#167807720 Fix Enables Social User to be verified by default #38

Merged
merged 1 commit into from
Aug 13, 2019
Merged

#167807720 Fix Enables Social User to be verified by default #38

merged 1 commit into from
Aug 13, 2019

Conversation

Adekoreday
Copy link
Contributor

@Adekoreday Adekoreday commented Aug 9, 2019 •
edited
Loading

What does this PR do?

This Fix Enables a social user to be verified by default

Description of Task proposed in this pull request?

The create SocialUser helper was adjusted to verify social user by default

How should this be manually tested (Quality Assurance)?

localhost:5000/api/v1/auth/google
localhost:5000/api/v1/auth/twitter
localhost:5000/api/v1/auth/facebook

What are the relevant pivotal tracker stories?

What I have learned working on this feature:

  • I learned how identify and raise a bug fix

Screenshots:

Screenshot 2019-08-09 at 2 25 51 PM

@Adekoreday Adekoreday force-pushed the bg-user-verified-on-socialSignup-167190554 branch from f7e958b to db6b623 Compare August 9, 2019 13:40
@Adekoreday Adekoreday changed the title #167190554 Fix Enables Social User to be verified by default #167807720 Fix Enables Social User to be verified by default Aug 9, 2019
JuwonAbiola
JuwonAbiola reviewed Aug 12, 2019
View reviewed changes
Copy link
Contributor

@JuwonAbiola JuwonAbiola left a comment •
edited by Adekoreday
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, rebase this branch so that we can pull and test.
Alright done

@Adekoreday Adekoreday force-pushed the bg-user-verified-on-socialSignup-167190554 branch from db6b623 to 4c4731a Compare August 12, 2019 13:42
hound[bot]
hound bot reviewed Aug 12, 2019
View reviewed changes
test/auth/index.js Show resolved Hide resolved
test/auth/index.js Show resolved Hide resolved
@Adekoreday Adekoreday force-pushed the bg-user-verified-on-socialSignup-167190554 branch 2 times, most recently from 84800eb to db5ab52 Compare August 12, 2019 14:12
ayodejiAA
ayodejiAA previously approved these changes Aug 12, 2019
View reviewed changes
Copy link
Contributor

@ayodejiAA ayodejiAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix

@Adekoreday Adekoreday added pr:review This is PR is currently under review by team type:fix A bug fix labels Aug 12, 2019
chialuka
chialuka previously approved these changes Aug 12, 2019
View reviewed changes
Copy link
Contributor

@chialuka chialuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dinobi
dinobi previously approved these changes Aug 12, 2019
View reviewed changes
@Adekoreday Adekoreday temporarily deployed to authors-haven-rambo August 13, 2019 08:53 Inactive
bug(socialUser verified): Enables social User to be verified by default
e84d935 
Enables social User to be verified by default

[Fixes #167807720 ]
@Adekoreday Adekoreday dismissed stale reviews from dinobi, chialuka, and ayodejiAA via e84d935 August 13, 2019 09:00
@Adekoreday Adekoreday force-pushed the bg-user-verified-on-socialSignup-167190554 branch from db5ab52 to e84d935 Compare August 13, 2019 09:00
hound[bot]
hound bot reviewed Aug 13, 2019
View reviewed changes
test/auth/verifySocialUser.test.js
@@ -0,0 +1,47 @@
import chai from 'chai';
import sinon from 'sinon';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'sinon' is defined but never used. Allowed unused vars must match /should|expect/ no-unused-vars

@Adekoreday Adekoreday temporarily deployed to authors-haven-development August 13, 2019 09:16 Inactive
@dinobi dinobi merged commit d08d200 into develop Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hound Hound Hound left review comments

@JuwonAbiola JuwonAbiola JuwonAbiola left review comments

@dinobi dinobi dinobi approved these changes

@chialuka chialuka chialuka left review comments

@ayodejiAA ayodejiAA ayodejiAA left review comments

@abdulfatai360 abdulfatai360 Awaiting requested review from abdulfatai360

@henryade henryade Awaiting requested review from henryade

Assignees
No one assigned
Labels
pr:review This is PR is currently under review by team type:fix A bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Adekoreday @dinobi @JuwonAbiola @chialuka @ayodejiAA