From f889984f7a130b5acc68bce553bd55f990740688 Mon Sep 17 00:00:00 2001 From: Macheza Dzabala Date: Wed, 4 Dec 2019 12:05:12 +0200 Subject: [PATCH] CH:(Update Social Login) - Update Social Login Strategies for frontend interaction [finishes #170097534] --- package-lock.json | 149 ++++++++++-------- package.json | 1 + src/config/social/config.js | 17 +- .../auth/socialAuthenticationController.js | 10 +- src/routes/api/auth/social/facebook.js | 13 +- src/routes/api/auth/social/google.js | 12 +- src/tests/socialAuthTests.spec.js | 138 +++++----------- src/utils/secure/socialAuthKeys.js | 2 +- 8 files changed, 159 insertions(+), 183 deletions(-) diff --git a/package-lock.json b/package-lock.json index eb63e988..185ac353 100644 --- a/package-lock.json +++ b/package-lock.json @@ -3751,25 +3751,25 @@ "dependencies": { "abbrev": { "version": "1.1.1", - "resolved": "https://registry.npmjs.org/abbrev/-/abbrev-1.1.1.tgz", + "resolved": false, "integrity": "sha512-nne9/IiQ/hzIhY6pdDnbBtz7DjPTKrY00P/zvPSm5pOFkl6xuGrGnXn/VtTNNfNtAfZ9/1RtehkszU9qcTii0Q==", "optional": true }, "ansi-regex": { "version": "2.1.1", - "resolved": "https://registry.npmjs.org/ansi-regex/-/ansi-regex-2.1.1.tgz", + "resolved": false, "integrity": "sha1-w7M6te42DYbg5ijwRorn7yfWVN8=", "optional": true }, "aproba": { "version": "1.2.0", - "resolved": "https://registry.npmjs.org/aproba/-/aproba-1.2.0.tgz", + "resolved": false, "integrity": "sha512-Y9J6ZjXtoYh8RnXVCMOU/ttDmk1aBjunq9vO0ta5x85WDQiQfUF9sIPBITdbiiIVcBo03Hi3jMxigBtsddlXRw==", "optional": true }, "are-we-there-yet": { "version": "1.1.5", - "resolved": "https://registry.npmjs.org/are-we-there-yet/-/are-we-there-yet-1.1.5.tgz", + "resolved": false, "integrity": "sha512-5hYdAkZlcG8tOLujVDTgCT+uPX0VnpAH28gWsLfzpXYm7wP6mp5Q/gYyR7YQ0cKVJcXJnl3j2kpBan13PtQf6w==", "optional": true, "requires": { @@ -3779,13 +3779,13 @@ }, "balanced-match": { "version": "1.0.0", - "resolved": "https://registry.npmjs.org/balanced-match/-/balanced-match-1.0.0.tgz", + "resolved": false, "integrity": "sha1-ibTRmasr7kneFk6gK4nORi1xt2c=", "optional": true }, "brace-expansion": { "version": "1.1.11", - "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-1.1.11.tgz", + "resolved": false, "integrity": "sha512-iCuPHDFgrHX7H2vEI/5xpz07zSHB00TpugqhmYtVmMO6518mCuRMoOYFldEBl0g187ufozdaHgWKcYFb61qGiA==", "optional": true, "requires": { @@ -3795,37 +3795,37 @@ }, "chownr": { "version": "1.1.1", - "resolved": "https://registry.npmjs.org/chownr/-/chownr-1.1.1.tgz", + "resolved": false, "integrity": "sha512-j38EvO5+LHX84jlo6h4UzmOwi0UgW61WRyPtJz4qaadK5eY3BTS5TY/S1Stc3Uk2lIM6TPevAlULiEJwie860g==", "optional": true }, "code-point-at": { "version": "1.1.0", - "resolved": "https://registry.npmjs.org/code-point-at/-/code-point-at-1.1.0.tgz", + "resolved": false, "integrity": "sha1-DQcLTQQ6W+ozovGkDi7bPZpMz3c=", "optional": true }, "concat-map": { "version": "0.0.1", - "resolved": "https://registry.npmjs.org/concat-map/-/concat-map-0.0.1.tgz", + "resolved": false, "integrity": "sha1-2Klr13/Wjfd5OnMDajug1UBdR3s=", "optional": true }, "console-control-strings": { "version": "1.1.0", - "resolved": "https://registry.npmjs.org/console-control-strings/-/console-control-strings-1.1.0.tgz", + "resolved": false, "integrity": "sha1-PXz0Rk22RG6mRL9LOVB/mFEAjo4=", "optional": true }, "core-util-is": { "version": "1.0.2", - "resolved": "https://registry.npmjs.org/core-util-is/-/core-util-is-1.0.2.tgz", + "resolved": false, "integrity": "sha1-tf1UIgqivFq1eqtxQMlAdUUDwac=", "optional": true }, "debug": { "version": "4.1.1", - "resolved": "https://registry.npmjs.org/debug/-/debug-4.1.1.tgz", + "resolved": false, "integrity": "sha512-pYAIzeRo8J6KPEaJ0VWOh5Pzkbw/RetuzehGM7QRRX5he4fPHx2rdKMB256ehJCkX+XRQm16eZLqLNS8RSZXZw==", "optional": true, "requires": { @@ -3834,25 +3834,25 @@ }, "deep-extend": { "version": "0.6.0", - "resolved": "https://registry.npmjs.org/deep-extend/-/deep-extend-0.6.0.tgz", + "resolved": false, "integrity": "sha512-LOHxIOaPYdHlJRtCQfDIVZtfw/ufM8+rVj649RIHzcm/vGwQRXFt6OPqIFWsm2XEMrNIEtWR64sY1LEKD2vAOA==", "optional": true }, "delegates": { "version": "1.0.0", - "resolved": "https://registry.npmjs.org/delegates/-/delegates-1.0.0.tgz", + "resolved": false, "integrity": "sha1-hMbhWbgZBP3KWaDvRM2HDTElD5o=", "optional": true }, "detect-libc": { "version": "1.0.3", - "resolved": "https://registry.npmjs.org/detect-libc/-/detect-libc-1.0.3.tgz", + "resolved": false, "integrity": "sha1-+hN8S9aY7fVc1c0CrFWfkaTEups=", "optional": true }, "fs-minipass": { "version": "1.2.5", - "resolved": "https://registry.npmjs.org/fs-minipass/-/fs-minipass-1.2.5.tgz", + "resolved": false, "integrity": "sha512-JhBl0skXjUPCFH7x6x61gQxrKyXsxB5gcgePLZCwfyCGGsTISMoIeObbrvVeP6Xmyaudw4TT43qV2Gz+iyd2oQ==", "optional": true, "requires": { @@ -3861,13 +3861,13 @@ }, "fs.realpath": { "version": "1.0.0", - "resolved": "https://registry.npmjs.org/fs.realpath/-/fs.realpath-1.0.0.tgz", + "resolved": false, "integrity": "sha1-FQStJSMVjKpA20onh8sBQRmU6k8=", "optional": true }, "gauge": { "version": "2.7.4", - "resolved": "https://registry.npmjs.org/gauge/-/gauge-2.7.4.tgz", + "resolved": false, "integrity": "sha1-LANAXHU4w51+s3sxcCLjJfsBi/c=", "optional": true, "requires": { @@ -3883,7 +3883,7 @@ }, "glob": { "version": "7.1.3", - "resolved": "https://registry.npmjs.org/glob/-/glob-7.1.3.tgz", + "resolved": false, "integrity": "sha512-vcfuiIxogLV4DlGBHIUOwI0IbrJ8HWPc4MU7HzviGeNho/UJDfi6B5p3sHeWIQ0KGIU0Jpxi5ZHxemQfLkkAwQ==", "optional": true, "requires": { @@ -3897,13 +3897,13 @@ }, "has-unicode": { "version": "2.0.1", - "resolved": "https://registry.npmjs.org/has-unicode/-/has-unicode-2.0.1.tgz", + "resolved": false, "integrity": "sha1-4Ob+aijPUROIVeCG0Wkedx3iqLk=", "optional": true }, "iconv-lite": { "version": "0.4.24", - "resolved": "https://registry.npmjs.org/iconv-lite/-/iconv-lite-0.4.24.tgz", + "resolved": false, "integrity": "sha512-v3MXnZAcvnywkTUEZomIActle7RXXeedOR31wwl7VlyoXO4Qi9arvSenNQWne1TcRwhCL1HwLI21bEqdpj8/rA==", "optional": true, "requires": { @@ -3912,7 +3912,7 @@ }, "ignore-walk": { "version": "3.0.1", - "resolved": "https://registry.npmjs.org/ignore-walk/-/ignore-walk-3.0.1.tgz", + "resolved": false, "integrity": "sha512-DTVlMx3IYPe0/JJcYP7Gxg7ttZZu3IInhuEhbchuqneY9wWe5Ojy2mXLBaQFUQmo0AW2r3qG7m1mg86js+gnlQ==", "optional": true, "requires": { @@ -3921,7 +3921,7 @@ }, "inflight": { "version": "1.0.6", - "resolved": "https://registry.npmjs.org/inflight/-/inflight-1.0.6.tgz", + "resolved": false, "integrity": "sha1-Sb1jMdfQLQwJvJEKEHW6gWW1bfk=", "optional": true, "requires": { @@ -3931,19 +3931,19 @@ }, "inherits": { "version": "2.0.3", - "resolved": "https://registry.npmjs.org/inherits/-/inherits-2.0.3.tgz", + "resolved": false, "integrity": "sha1-Yzwsg+PaQqUC9SRmAiSA9CCCYd4=", "optional": true }, "ini": { "version": "1.3.5", - "resolved": "https://registry.npmjs.org/ini/-/ini-1.3.5.tgz", + "resolved": false, "integrity": "sha512-RZY5huIKCMRWDUqZlEi72f/lmXKMvuszcMBduliQ3nnWbx9X/ZBQO7DijMEYS9EhHBb2qacRUMtC7svLwe0lcw==", "optional": true }, "is-fullwidth-code-point": { "version": "1.0.0", - "resolved": "https://registry.npmjs.org/is-fullwidth-code-point/-/is-fullwidth-code-point-1.0.0.tgz", + "resolved": false, "integrity": "sha1-754xOG8DGn8NZDr4L95QxFfvAMs=", "optional": true, "requires": { @@ -3952,13 +3952,13 @@ }, "isarray": { "version": "1.0.0", - "resolved": "https://registry.npmjs.org/isarray/-/isarray-1.0.0.tgz", + "resolved": false, "integrity": "sha1-u5NdSFgsuhaMBoNJV6VKPgcSTxE=", "optional": true }, "minimatch": { "version": "3.0.4", - "resolved": "https://registry.npmjs.org/minimatch/-/minimatch-3.0.4.tgz", + "resolved": false, "integrity": "sha512-yJHVQEhyqPLUTgt9B83PXu6W3rx4MvvHvSUvToogpwoGDOUQ+yDrR0HRot+yOCdCO7u4hX3pWft6kWBBcqh0UA==", "optional": true, "requires": { @@ -3967,13 +3967,13 @@ }, "minimist": { "version": "0.0.8", - "resolved": "https://registry.npmjs.org/minimist/-/minimist-0.0.8.tgz", + "resolved": false, "integrity": "sha1-hX/Kv8M5fSYluCKCYuhqp6ARsF0=", "optional": true }, "minipass": { "version": "2.3.5", - "resolved": "https://registry.npmjs.org/minipass/-/minipass-2.3.5.tgz", + "resolved": false, "integrity": "sha512-Gi1W4k059gyRbyVUZQ4mEqLm0YIUiGYfvxhF6SIlk3ui1WVxMTGfGdQ2SInh3PDrRTVvPKgULkpJtT4RH10+VA==", "optional": true, "requires": { @@ -3983,7 +3983,7 @@ }, "minizlib": { "version": "1.2.1", - "resolved": "https://registry.npmjs.org/minizlib/-/minizlib-1.2.1.tgz", + "resolved": false, "integrity": "sha512-7+4oTUOWKg7AuL3vloEWekXY2/D20cevzsrNT2kGWm+39J9hGTCBv8VI5Pm5lXZ/o3/mdR4f8rflAPhnQb8mPA==", "optional": true, "requires": { @@ -3992,7 +3992,7 @@ }, "mkdirp": { "version": "0.5.1", - "resolved": "https://registry.npmjs.org/mkdirp/-/mkdirp-0.5.1.tgz", + "resolved": false, "integrity": "sha1-MAV0OOrGz3+MR2fzhkjWaX11yQM=", "optional": true, "requires": { @@ -4001,13 +4001,13 @@ }, "ms": { "version": "2.1.1", - "resolved": "https://registry.npmjs.org/ms/-/ms-2.1.1.tgz", + "resolved": false, "integrity": "sha512-tgp+dl5cGk28utYktBsrFqA7HKgrhgPsg6Z/EfhWI4gl1Hwq8B/GmY/0oXZ6nF8hDVesS/FpnYaD/kOWhYQvyg==", "optional": true }, "needle": { "version": "2.3.0", - "resolved": "https://registry.npmjs.org/needle/-/needle-2.3.0.tgz", + "resolved": false, "integrity": "sha512-QBZu7aAFR0522EyaXZM0FZ9GLpq6lvQ3uq8gteiDUp7wKdy0lSd2hPlgFwVuW1CBkfEs9PfDQsQzZghLs/psdg==", "optional": true, "requires": { @@ -4018,7 +4018,7 @@ }, "node-pre-gyp": { "version": "0.12.0", - "resolved": "https://registry.npmjs.org/node-pre-gyp/-/node-pre-gyp-0.12.0.tgz", + "resolved": false, "integrity": "sha512-4KghwV8vH5k+g2ylT+sLTjy5wmUOb9vPhnM8NHvRf9dHmnW/CndrFXy2aRPaPST6dugXSdHXfeaHQm77PIz/1A==", "optional": true, "requires": { @@ -4036,7 +4036,7 @@ }, "nopt": { "version": "4.0.1", - "resolved": "https://registry.npmjs.org/nopt/-/nopt-4.0.1.tgz", + "resolved": false, "integrity": "sha1-0NRoWv1UFRk8jHUFYC0NF81kR00=", "optional": true, "requires": { @@ -4046,13 +4046,13 @@ }, "npm-bundled": { "version": "1.0.6", - "resolved": "https://registry.npmjs.org/npm-bundled/-/npm-bundled-1.0.6.tgz", + "resolved": false, "integrity": "sha512-8/JCaftHwbd//k6y2rEWp6k1wxVfpFzB6t1p825+cUb7Ym2XQfhwIC5KwhrvzZRJu+LtDE585zVaS32+CGtf0g==", "optional": true }, "npm-packlist": { "version": "1.4.1", - "resolved": "https://registry.npmjs.org/npm-packlist/-/npm-packlist-1.4.1.tgz", + "resolved": false, "integrity": "sha512-+TcdO7HJJ8peiiYhvPxsEDhF3PJFGUGRcFsGve3vxvxdcpO2Z4Z7rkosRM0kWj6LfbK/P0gu3dzk5RU1ffvFcw==", "optional": true, "requires": { @@ -4062,7 +4062,7 @@ }, "npmlog": { "version": "4.1.2", - "resolved": "https://registry.npmjs.org/npmlog/-/npmlog-4.1.2.tgz", + "resolved": false, "integrity": "sha512-2uUqazuKlTaSI/dC8AzicUck7+IrEaOnN/e0jd3Xtt1KcGpwx30v50mL7oPyr/h9bL3E4aZccVwpwP+5W9Vjkg==", "optional": true, "requires": { @@ -4074,19 +4074,19 @@ }, "number-is-nan": { "version": "1.0.1", - "resolved": "https://registry.npmjs.org/number-is-nan/-/number-is-nan-1.0.1.tgz", + "resolved": false, "integrity": "sha1-CXtgK1NCKlIsGvuHkDGDNpQaAR0=", "optional": true }, "object-assign": { "version": "4.1.1", - "resolved": "https://registry.npmjs.org/object-assign/-/object-assign-4.1.1.tgz", + "resolved": false, "integrity": "sha1-IQmtx5ZYh8/AXLvUQsrIv7s2CGM=", "optional": true }, "once": { "version": "1.4.0", - "resolved": "https://registry.npmjs.org/once/-/once-1.4.0.tgz", + "resolved": false, "integrity": "sha1-WDsap3WWHUsROsF9nFC6753Xa9E=", "optional": true, "requires": { @@ -4095,19 +4095,19 @@ }, "os-homedir": { "version": "1.0.2", - "resolved": "https://registry.npmjs.org/os-homedir/-/os-homedir-1.0.2.tgz", + "resolved": false, "integrity": "sha1-/7xJiDNuDoM94MFox+8VISGqf7M=", "optional": true }, "os-tmpdir": { "version": "1.0.2", - "resolved": "https://registry.npmjs.org/os-tmpdir/-/os-tmpdir-1.0.2.tgz", + "resolved": false, "integrity": "sha1-u+Z0BseaqFxc/sdm/lc0VV36EnQ=", "optional": true }, "osenv": { "version": "0.1.5", - "resolved": "https://registry.npmjs.org/osenv/-/osenv-0.1.5.tgz", + "resolved": false, "integrity": "sha512-0CWcCECdMVc2Rw3U5w9ZjqX6ga6ubk1xDVKxtBQPK7wis/0F2r9T6k4ydGYhecl7YUBxBVxhL5oisPsNxAPe2g==", "optional": true, "requires": { @@ -4117,19 +4117,19 @@ }, "path-is-absolute": { "version": "1.0.1", - "resolved": "https://registry.npmjs.org/path-is-absolute/-/path-is-absolute-1.0.1.tgz", + "resolved": false, "integrity": "sha1-F0uSaHNVNP+8es5r9TpanhtcX18=", "optional": true }, "process-nextick-args": { "version": "2.0.0", - "resolved": "https://registry.npmjs.org/process-nextick-args/-/process-nextick-args-2.0.0.tgz", + "resolved": false, "integrity": "sha512-MtEC1TqN0EU5nephaJ4rAtThHtC86dNN9qCuEhtshvpVBkAW5ZO7BASN9REnF9eoXGcRub+pFuKEpOHE+HbEMw==", "optional": true }, "rc": { "version": "1.2.8", - "resolved": "https://registry.npmjs.org/rc/-/rc-1.2.8.tgz", + "resolved": false, "integrity": "sha512-y3bGgqKj3QBdxLbLkomlohkvsA8gdAiUQlSBJnBhfn+BPxg4bc62d8TcBW15wavDfgexCgccckhcZvywyQYPOw==", "optional": true, "requires": { @@ -4141,7 +4141,7 @@ "dependencies": { "minimist": { "version": "1.2.0", - "resolved": "https://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz", + "resolved": false, "integrity": "sha1-o1AIsg9BOD7sH7kU9M1d95omQoQ=", "optional": true } @@ -4149,7 +4149,7 @@ }, "readable-stream": { "version": "2.3.6", - "resolved": "https://registry.npmjs.org/readable-stream/-/readable-stream-2.3.6.tgz", + "resolved": false, "integrity": "sha512-tQtKA9WIAhBF3+VLAseyMqZeBjW0AHJoxOtYqSUZNJxauErmLbVm2FW1y+J/YA9dUrAC39ITejlZWhVIwawkKw==", "optional": true, "requires": { @@ -4164,7 +4164,7 @@ }, "rimraf": { "version": "2.6.3", - "resolved": "https://registry.npmjs.org/rimraf/-/rimraf-2.6.3.tgz", + "resolved": false, "integrity": "sha512-mwqeW5XsA2qAejG46gYdENaxXjx9onRNCfn7L0duuP4hCuTIi/QO7PDK07KJfp1d+izWPrzEJDcSqBa0OZQriA==", "optional": true, "requires": { @@ -4173,43 +4173,43 @@ }, "safe-buffer": { "version": "5.1.2", - "resolved": "https://registry.npmjs.org/safe-buffer/-/safe-buffer-5.1.2.tgz", + "resolved": false, "integrity": "sha512-Gd2UZBJDkXlY7GbJxfsE8/nvKkUEU1G38c1siN6QP6a9PT9MmHB8GnpscSmMJSoF8LOIrt8ud/wPtojys4G6+g==", "optional": true }, "safer-buffer": { "version": "2.1.2", - "resolved": "https://registry.npmjs.org/safer-buffer/-/safer-buffer-2.1.2.tgz", + "resolved": false, "integrity": "sha512-YZo3K82SD7Riyi0E1EQPojLz7kpepnSQI9IyPbHHg1XXXevb5dJI7tpyN2ADxGcQbHG7vcyRHk0cbwqcQriUtg==", "optional": true }, "sax": { "version": "1.2.4", - "resolved": "https://registry.npmjs.org/sax/-/sax-1.2.4.tgz", + "resolved": false, "integrity": "sha512-NqVDv9TpANUjFm0N8uM5GxL36UgKi9/atZw+x7YFnQ8ckwFGKrl4xX4yWtrey3UJm5nP1kUbnYgLopqWNSRhWw==", "optional": true }, "semver": { "version": "5.7.0", - "resolved": "https://registry.npmjs.org/semver/-/semver-5.7.0.tgz", + "resolved": false, "integrity": "sha512-Ya52jSX2u7QKghxeoFGpLwCtGlt7j0oY9DYb5apt9nPlJ42ID+ulTXESnt/qAQcoSERyZ5sl3LDIOw0nAn/5DA==", "optional": true }, "set-blocking": { "version": "2.0.0", - "resolved": "https://registry.npmjs.org/set-blocking/-/set-blocking-2.0.0.tgz", + "resolved": false, "integrity": "sha1-BF+XgtARrppoA93TgrJDkrPYkPc=", "optional": true }, "signal-exit": { "version": "3.0.2", - "resolved": "https://registry.npmjs.org/signal-exit/-/signal-exit-3.0.2.tgz", + "resolved": false, "integrity": "sha1-tf3AjxKH6hF4Yo5BXiUTK3NkbG0=", "optional": true }, "string-width": { "version": "1.0.2", - "resolved": "https://registry.npmjs.org/string-width/-/string-width-1.0.2.tgz", + "resolved": false, "integrity": "sha1-EYvfW4zcUaKn5w0hHgfisLmxB9M=", "optional": true, "requires": { @@ -4220,7 +4220,7 @@ }, "string_decoder": { "version": "1.1.1", - "resolved": "https://registry.npmjs.org/string_decoder/-/string_decoder-1.1.1.tgz", + "resolved": false, "integrity": "sha512-n/ShnvDi6FHbbVfviro+WojiFzv+s8MPMHBczVePfUpDJLwoLT0ht1l4YwBCbi8pJAveEEdnkHyPyTP/mzRfwg==", "optional": true, "requires": { @@ -4229,7 +4229,7 @@ }, "strip-ansi": { "version": "3.0.1", - "resolved": "https://registry.npmjs.org/strip-ansi/-/strip-ansi-3.0.1.tgz", + "resolved": false, "integrity": "sha1-ajhfuIU9lS1f8F0Oiq+UJ43GPc8=", "optional": true, "requires": { @@ -4238,13 +4238,13 @@ }, "strip-json-comments": { "version": "2.0.1", - "resolved": "https://registry.npmjs.org/strip-json-comments/-/strip-json-comments-2.0.1.tgz", + "resolved": false, "integrity": "sha1-PFMZQukIwml8DsNEhYwobHygpgo=", "optional": true }, "tar": { "version": "4.4.8", - "resolved": "https://registry.npmjs.org/tar/-/tar-4.4.8.tgz", + "resolved": false, "integrity": "sha512-LzHF64s5chPQQS0IYBn9IN5h3i98c12bo4NCO7e0sGM2llXQ3p2FGC5sdENN4cTW48O915Sh+x+EXx7XW96xYQ==", "optional": true, "requires": { @@ -4259,13 +4259,13 @@ }, "util-deprecate": { "version": "1.0.2", - "resolved": "https://registry.npmjs.org/util-deprecate/-/util-deprecate-1.0.2.tgz", + "resolved": false, "integrity": "sha1-RQ1Nyfpw3nMnYvvS1KKJgUGaDM8=", "optional": true }, "wide-align": { "version": "1.1.3", - "resolved": "https://registry.npmjs.org/wide-align/-/wide-align-1.1.3.tgz", + "resolved": false, "integrity": "sha512-QGkOQc8XL6Bt5PwnsExKBPuMKBxnGxWWW3fU55Xt4feHozMUhdUMaBCk290qpm/wG5u/RSKzwdAC4i51YigihA==", "optional": true, "requires": { @@ -4274,13 +4274,13 @@ }, "wrappy": { "version": "1.0.2", - "resolved": "https://registry.npmjs.org/wrappy/-/wrappy-1.0.2.tgz", + "resolved": false, "integrity": "sha1-tSQ9jz7BqjXxNkYFvA0QNuMKtp8=", "optional": true }, "yallist": { "version": "3.0.3", - "resolved": "https://registry.npmjs.org/yallist/-/yallist-3.0.3.tgz", + "resolved": false, "integrity": "sha512-S+Zk8DEWE6oKpV+vI3qWkaK+jSbIK86pCwe2IF/xwIpQ8jEuxpw9NyaGjmp9+BoJv5FV2piqCDcoCtStppiq2A==", "optional": true } @@ -6698,6 +6698,23 @@ "passport-oauth": "1.0.0" } }, + "passport-google-oauth": { + "version": "2.0.0", + "resolved": "https://registry.npmjs.org/passport-google-oauth/-/passport-google-oauth-2.0.0.tgz", + "integrity": "sha512-JKxZpBx6wBQXX1/a1s7VmdBgwOugohH+IxCy84aPTZNq/iIPX6u7Mqov1zY7MKRz3niFPol0KJz8zPLBoHKtYA==", + "requires": { + "passport-google-oauth1": "1.x.x", + "passport-google-oauth20": "2.x.x" + } + }, + "passport-google-oauth1": { + "version": "1.0.0", + "resolved": "https://registry.npmjs.org/passport-google-oauth1/-/passport-google-oauth1-1.0.0.tgz", + "integrity": "sha1-r3SoA99R7GRvZqRNgigr5vEI4Mw=", + "requires": { + "passport-oauth1": "1.x.x" + } + }, "passport-google-oauth20": { "version": "2.0.0", "resolved": "https://registry.npmjs.org/passport-google-oauth20/-/passport-google-oauth20-2.0.0.tgz", diff --git a/package.json b/package.json index 96e06823..0996b572 100755 --- a/package.json +++ b/package.json @@ -77,6 +77,7 @@ "passport": "^0.4.0", "passport-facebook": "^3.0.0", "passport-facebook-token": "^3.3.0", + "passport-google-oauth": "^2.0.0", "passport-google-oauth20": "^2.0.0", "passport-google-plus-token": "^2.1.0", "passport-local": "^1.0.0", diff --git a/src/config/social/config.js b/src/config/social/config.js index eedbe293..0ed75bfc 100644 --- a/src/config/social/config.js +++ b/src/config/social/config.js @@ -1,15 +1,24 @@ import 'regenerator-runtime'; import passport from 'passport'; -import GooglePlusTokenStrategy from 'passport-google-plus-token'; -import FacebookTokenStrategy from 'passport-facebook-token'; +import GoogleOAuth from 'passport-google-oauth'; +import FacebookStrategy from 'passport-facebook'; import utilities from '../../utils/index'; import services from '../../services/userServices'; async function getUser(query, done, scope = null) { done(null, await services.findOrCreate(query, scope)); } +passport.serializeUser((user, done) => { + done(null, user); +}); -passport.use(new GooglePlusTokenStrategy( +passport.deserializeUser((user, done) => { + done(null, user); +}); + +const GoogleStrategy = GoogleOAuth.OAuth2Strategy; + +passport.use(new GoogleStrategy( utilities.strategy( utilities.keys.google.clientID, utilities.keys.google.clientSecret, @@ -26,7 +35,7 @@ passport.use(new GooglePlusTokenStrategy( ) )); -passport.use(new FacebookTokenStrategy( +passport.use(new FacebookStrategy( utilities.strategy( utilities.keys.facebook.clientID, utilities.keys.facebook.clientSecret, diff --git a/src/controllers/auth/socialAuthenticationController.js b/src/controllers/auth/socialAuthenticationController.js index 24b39a94..7cf089c7 100644 --- a/src/controllers/auth/socialAuthenticationController.js +++ b/src/controllers/auth/socialAuthenticationController.js @@ -1,13 +1,7 @@ /* eslint-disable no-underscore-dangle */ -import Utilities from '../../utils/index'; - export default class SocialAuthController { static authenticateUser({ user }, res) { - return Utilities.responseHelper( - res, - Utilities.stringsHelper.auth.social.SUCCESSFULLY_AUTHENTICATED, - user, - user._options.isNewRecord ? 201 : 200 - ); + const clientUrl = `${process.env.FRONT_END_PATH}`; + return res.redirect(`${clientUrl}/users/auth/success?user=${JSON.stringify(user.dataValues)}`); } } diff --git a/src/routes/api/auth/social/facebook.js b/src/routes/api/auth/social/facebook.js index f150d09e..e489f372 100644 --- a/src/routes/api/auth/social/facebook.js +++ b/src/routes/api/auth/social/facebook.js @@ -41,10 +41,17 @@ const router = new Router(); * '200': * description: Authenticated User Successfully */ -router.post( - '/', passport.authenticate('facebook-token', { session: false, scope: 'email' }), +router.get( + '/', passport.authenticate('facebook', { session: false, scope: 'email' }), tokenMiddleware, - socialAuthenticationController.authenticateUser, errorHandler ); + + +router.get( + '/callback', + passport.authenticate('facebook'), + tokenMiddleware, + socialAuthenticationController.authenticateUser +); export default router; diff --git a/src/routes/api/auth/social/google.js b/src/routes/api/auth/social/google.js index 052558e1..33a4a80e 100644 --- a/src/routes/api/auth/social/google.js +++ b/src/routes/api/auth/social/google.js @@ -42,11 +42,17 @@ const router = new Router(); * description: Authenticated User Successfully */ -router.post( - '/', passport.authenticate('google-plus-token', { session: false, scope: ['profile', 'email'] }), +router.get( + '/', passport.authenticate('google', { session: false, scope: ['profile', 'email'] }), tokenMiddleware, - socialAuthenticationController.authenticateUser, errorHandler ); +router.get( + '/callback', + passport.authenticate('google'), + tokenMiddleware, + socialAuthenticationController.authenticateUser +); + export default router; diff --git a/src/tests/socialAuthTests.spec.js b/src/tests/socialAuthTests.spec.js index 31cdce23..9f19aefb 100644 --- a/src/tests/socialAuthTests.spec.js +++ b/src/tests/socialAuthTests.spec.js @@ -1,103 +1,45 @@ import chai from 'chai'; -import chaiHttp from 'chai-http'; -import app from '../index'; - -chai.use(chaiHttp); +import userServiceHelper from '../services/serviceHelpers/userServiceHelpers'; +import socialAuthController from './../controllers/auth/socialAuthenticationController'; const { expect } = chai; -const googleAccessToken = process.env.GOOGLE_ACCESS_TOKEN; -const facebookAccessToken = process.env.FACEBOOK_ACCESS_TOKEN; - -describe('login using social sites', () => { - it('Should authenticate with GooglePlus Successfully. New users return 201 status code', done => { - chai.request(app) - .post('/api/v1/auth/google/') - .send({ access_token: googleAccessToken }) - .end((err, res) => { - expect(res.status).to.be.eql(201, 'Incorrect Status Code Returned'); - expect(res.body.data).to.be.a('object', 'Incorrect Data Type Returned'); - expect(res.body.data).to.have.property('token'); - expect(res.body.data).to.have.property('id'); - expect(res.body.data).to.have.property('username'); - expect(res.body.data).to.have.property('email'); - expect(res.body.data).to.have.property('createdAt'); - expect(res.body.data).to.have.property('updatedAt'); - done(); - }); - }).timeout(4000); - - it('Should authenticate with GooglePlus Successfully. Existing users return 200 status code.', done => { - chai.request(app) - .post('/api/v1/auth/google/') - .send({ access_token: googleAccessToken }) - .end((err, res) => { - expect(res.status).to.be.eql(200, 'Incorrect Status Code Returned'); - expect(res.body.data).to.be.a('object', 'Incorrect Data Type Returned'); - expect(res.body.data).to.have.property('token'); - expect(res.body.data).to.have.property('id'); - expect(res.body.data).to.have.property('username'); - expect(res.body.data).to.have.property('email'); - expect(res.body.data).to.have.property('createdAt'); - expect(res.body.data).to.have.property('updatedAt'); - done(); - }); - }).timeout(4000); - it('Should not authenticate with Google successfully, Bad Access Token', done => { - chai.request(app) - .post('/api/v1/auth/google/') - .send({ access_token: 'mdmdmd92n' }) - .end((err, res) => { - expect(res.status).to.be.eql(401, 'Incorrect Status Code Returned'); - expect(res.body.data).to.be.a('object', 'Incorrect Data Type Returned'); - done(); - }); - }).timeout(4000); - - - it('Should authenticate with Facebook Successfully. New users return 201 status code', done => { - chai.request(app) - .post('/api/v1/auth/facebook/') - .send({ access_token: facebookAccessToken }) - .end((err, res) => { - expect(res.status).to.be.eql(201, 'Incorrect Status Code Returned'); - expect(res.body.data).to.be.a('object', 'Incorrect Data Type Returned'); - expect(res.body.data).to.have.property('token'); - expect(res.body.data).to.have.property('id'); - expect(res.body.data).to.have.property('username'); - expect(res.body.data).to.have.property('email'); - expect(res.body.data).to.have.property('createdAt'); - expect(res.body.data).to.have.property('updatedAt'); - done(); - }); - }).timeout(4000); - - it('Should authenticate with Facebook Successfully. Existing users return 200 status code', done => { - chai.request(app) - .post('/api/v1/auth/facebook/') - .send({ access_token: facebookAccessToken }) - .end((err, res) => { - expect(res.status).to.be.eql(200, 'Incorrect Status Code Returned'); - expect(res.body.data).to.be.a('object', 'Incorrect Data Type Returned'); - expect(res.body.data).to.have.property('token'); - expect(res.body.data).to.have.property('id'); - expect(res.body.data).to.have.property('username'); - expect(res.body.data).to.have.property('email'); - expect(res.body.data).to.have.property('createdAt'); - expect(res.body.data).to.have.property('updatedAt'); - done(); - }); - }).timeout(4000); - - it('Should not authenticate with Facebook successfully, Bad Access Token', done => { - chai.request(app) - .post('/api/v1/auth/facebook/') - .send({ access_token: 'mdmdmd92n' }) - .end((err, res) => { - expect(res.status).to.be.eql(400, 'Incorrect Status Code Returned'); - expect(res.body.data).to.be.a('object', 'Incorrect Data Type Returned'); - expect(res.body).to.have.property('message', 'Failed to fetch user profile'); - done(); - }); - }).timeout(4000); +const user = { + dataValues: { + password: 'Hello', + isVerified: false, + facebookId: '0040', + googleId: '0039', + } +} + +it('Should Delete User Keys', () => { + try { + const result = userServiceHelper.deleteUserKeys(user); + expect(result).to.be.eql(null); + } catch (err) { + + } }); + +it('Should Redirect a user properly', () => { + + const clientUrl = process.env.FRONT_END_PATH; + + const data = { + user + } + const response = { + redirect: (path) => { + return path; + } + } + + try { + const res = socialAuthController.authenticateUser(data, response); + console.log(res); + expect(res).to.be.eql(`${clientUrl}/users/auth/success?user={}`); + } catch (err) { + console.log(err); + } +}); \ No newline at end of file diff --git a/src/utils/secure/socialAuthKeys.js b/src/utils/secure/socialAuthKeys.js index ee3ec525..79f77716 100644 --- a/src/utils/secure/socialAuthKeys.js +++ b/src/utils/secure/socialAuthKeys.js @@ -7,7 +7,7 @@ const socialAuthKeys = { google: { clientID: process.env.GOOGLE_CLIENT_ID, clientSecret: process.env.GOOGLE_CLIENT_SECRET, - callbackUrl: `${baseUrl}/api/v1/auth/google/callback/` + callbackUrl: `${baseUrl}/api/v1/auth/google/callback` }, facebook: {