Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#166151272 enable social authentication #7

Merged
merged 1 commit into from
Jun 12, 2019

Conversation

ceexon
Copy link
Contributor

@ceexon ceexon commented Jun 6, 2019

What does this PR do?

  • Allow users to login

Description of the Tasks to be completed?

  • add POST endpoint for user login
  • write unit tests

How should this be manually tested?

  • Clone the repository to your local branch

  • $ git clone https://github.com/andela/wg-baqi.git

  • $ cd to the wg-baqi directory, create a virtual environment and install the dependencies

  • $ cd wg-baqi

  • $ virtualenv venv

  • Add .env and get fields from .env_sample

  • $ source venv/bin/activate

  • $ pip install -r requirements.txt

  • Activate bootstrap and run the server

  • $ invoke bootstrap-wger --settings-path ./wger/settings.py --no-start-server

  • $ python manage.py runserver

  • Navigate to the endpoint http://127.0.0.1:8000/api/v2/social/auth-login/

  • Get twitter, facebook and google keys and add them to the .env

  • Required fields are:

  • access_secret only required for twitter

    provider - specifics('google-oauth2' | 'facebook' | 'twitter')
    access_token - acquire from google, facebook and twitter
    accsess_token_secret - acquire from twitter

  • login the user

Sample images

Screenshot 2019-06-08 at 20 36 55

Screenshot 2019-06-08 at 20 37 33

Screenshot 2019-06-08 at 20 13 34

What are the relevant pivotal tracker stories?

#166151272

@ceexon ceexon added the WIP label Jun 6, 2019
@ceexon ceexon force-pushed the ft-social-auth-166151272 branch 3 times, most recently from 13e0327 to 3e828c8 Compare June 7, 2019 06:38
@ceexon ceexon changed the title feature(social-authentication): enable social authentication #166151272 enable social authentication Jun 7, 2019
@ceexon ceexon force-pushed the ft-social-auth-166151272 branch 2 times, most recently from 4a01122 to a99c7c2 Compare June 7, 2019 07:52
Copy link
Contributor

@wangonya wangonya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still work in progress? The feature is working as described but tests are failing.

@ceexon
Copy link
Contributor Author

ceexon commented Jun 7, 2019

Yeah am working on finding out why the Travis is failing
As it occurs I had forgotten to add some required keys in the environment

@ceexon ceexon force-pushed the ft-social-auth-166151272 branch 2 times, most recently from 7c7ffad to 0429929 Compare June 7, 2019 13:15
@ceexon ceexon removed the WIP label Jun 7, 2019
Copy link
Contributor

@willeswa willeswa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ready for a merge?

@caveinn
Copy link
Contributor

caveinn commented Jun 10, 2019

@kburudi, good work with the implementation. Kindly look at the failing tests.

Copy link
Contributor

@jmusila jmusila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly, look into the failing tests

@ceexon ceexon force-pushed the ft-social-auth-166151272 branch 2 times, most recently from ea27f94 to e7724dd Compare June 12, 2019 02:19
Allow social media login/signup via google, facebook and twitter

[delivers #166151272]
@caveinn caveinn merged commit bbe574f into develop Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants