Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canonicalize file paths from walker #33

Merged
merged 1 commit into from Dec 19, 2018

Conversation

Projects
None yet
2 participants
@ajpaverd
Copy link
Contributor

commented Dec 19, 2018

On Windows 10, the tool does not count files that are actually used in the build, due to a mismatch in the file path representations.

For example, cargo geiger -v gives:

Used by build (sorted): \\?\C:\Users\ajpaverd\rust0\src\main.rs
Metric output format: x/y
x = unsafe code used by the build
y = total unsafe code found in the crate
Functions  Expressions  Impls  Traits  Methods  Dependency
Not used in build: C:\Users\ajpaverd\rust0\src\main.rs
0/1        0/1          0/0    0/0     0/0        rust0 v0.1.0 (file:///C:/Users/ajpaverd/rust0)
WARNING: Dependency file was never scanned: \\?\C:\Users\ajpaverd\rust0\src\main.rs

I've tested the fixed version on:

  • Windows 10
  • Windows Subsystem for Linux (Ubuntu 18.04)
  • Ubuntu 18.04

I think the fix is quite simple, but please let me know if anything needs to be changed. Thanks!

@anderejd

This comment has been minimized.

Copy link
Owner

commented Dec 19, 2018

Excellent, thanks!

I'll test and merge it later today.

@anderejd

This comment has been minimized.

Copy link
Owner

commented Dec 19, 2018

Wow, this project hasn't been working at all on Windows for quite a while. I really need to add #36

Thank you again!

Merging.

@anderejd anderejd merged commit e0e074f into anderejd:master Dec 19, 2018

@anderejd

This comment has been minimized.

Copy link
Owner

commented Dec 19, 2018

This bugfix has been released as part of 0.4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.