Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify forbid unsafe #52

Merged
merged 11 commits into from Feb 20, 2019

Added a comment about refactoring.

  • Loading branch information...
anderejd committed Feb 19, 2019
commit 26de768c088a37f89dd292a162382eeb24c7ed02
@@ -786,13 +786,18 @@ fn print_dependency<'a>(
}
Prefix::None => "".into(),
};

// TODO: Try to be panic free and use Result everywhere, but separate tree
// printing and metrics printing first. Use a callback or produce tree rows
// through an Iterator together with the PackageId and map together the
// complete row for printing in the caller code.
let pack_metrics_root = geiger_ctx
.pack_id_to_metrics
.get(&package.id)
.expect(&format!(
"Failed to get unsafe counters for package: {}",
package.id
)); // TODO: Try to be panic free and use Result everywhere.
));
let unsafe_found = pack_metrics_root.used.counters.has_unsafe();
let all_used_targets_forbids_unsafe =
pack_metrics_root.used.entry_points.forbids_unsafe >= 1
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.