Switch branches/tags
Nothing to show
Commits on Mar 24, 2011
  1. Punt buffercbdata

    davidben committed Mar 11, 2011
    It has never been used in the history of this project.
  2. Punt a number of g_new NULL checks, various minor cleanups

    davidben committed Mar 11, 2011
    No real need to check g_new's return value as it always succeeds. (Or
    destroys the universe^Wprocess in embarrassment.) Also make owl_global
    manage the lifetime of the kill buffer since it's part of owl_global
    now. And replace a g_new/strncpy with a g_strndup. It's shorter.
  3. Clean up owl_keypress_tostring to return a newly-allocated string

    davidben committed Mar 11, 2011
    I don't think it's possible to overflow the function's internal buffer,
    but we may as well avoid this sketchiness.
  4. Don't pass limited buffer lengths to owl_keybinding_tostring

    davidben committed Mar 10, 2011
    The keymap tostring code still probably should be cleaned up though.
  5. Make owl_keybinding new/delete instead of init/cleanup

    davidben committed Mar 10, 2011
    Valgrind is deeply disappointed in this code...
    Hide owl_keybinding_make_keys again, so we don't construct half-baked
    owl_keybinding instances. Instead allow for creating a dummy keybinding.
    Also, initialize all fields of owl_keybinding, or freeing it afterwards
    explodes. Also fix a memory leak in unbindkey.
  6. Use owl_function_command_norv when we don't care about the result

    davidben committed Mar 8, 2011
    Otherwise, we forget to g_free it.
  7. Don't call owl_list_create in owl_dict_get_keys

    davidben committed Mar 8, 2011
    Until we get rid of this owl_list thing altogether, there should be a
    convention as to who initializes the thing. Otherwise, we leak memory
    from people initializing it too many times.
    Whoever reviews this probably wants to look over this very carefully in
    case I missed one of the owl_list_creates.
    Also kill the various wrappers over owl_list_cleanup as they are not the
    inverse of any operation.
  8. Replace owl_parse_delete with g_strfreev

    davidben committed Mar 8, 2011
    Also cut the pointless g_strdup in owl_cmddict_execute and allow argc to
    be NULL if we don't care about the value.
  9. Reimplement owl_text_substitute with g_strsplit and g_strjoinv

    andersk committed Feb 12, 2011
    (I have no idea what the rambling about backslash quoting was about.)
    Signed-off-by: Anders Kaseorg <>
    Reviewed-by: David Benjamin <>
  10. Use G_GNUC_PRINTF to get type-checking on our format strings

    davidben committed with andersk Feb 26, 2011
    The extra type-checking is nice.
    [ Move G_GNUC_PRINTF such that no further preprocessor
     magic is needed]
    Signed-off-by: Anders Kaseorg <>
  11. owl_function_show_colors: Realign default, and add black

    andersk committed Feb 28, 2011
    Signed-off-by: Anders Kaseorg <>
    Reviewed-by: David Benjamin <>
Commits on Mar 20, 2011
  1. compat/compat.h: Add #include guards

    andersk committed Mar 20, 2011
    Signed-off-by: Anders Kaseorg <>
  2. Protect memrchr prototype by !HAVE_DECL_MEMCHR instead of !HAVE_MEMCHR

    andersk committed Mar 20, 2011
    This fixes
    viewwin.c:393:7: warning: implicit declaration of function ‘memrchr’
    on platforms where PERL_CFLAGS doesn’t contain -D_GNU_SOURCE.
    !HAVE_MEMRCHR means that memrchr is undefined at link time, so we need
    to provide our own implementation; but !HAVE_DECL_MEMRCHR means that
    memrchr is not declared at compile time, so we need to provide our own
    Signed-off-by: Anders Kaseorg <>
Commits on Mar 14, 2011

    andersk committed Mar 14, 2011
    This fixes searching for |.  regex(7) lists the metacharacters
    “^.[$()|*+?{\”, so we actually have all of them now.
    Signed-off-by: Anders Kaseorg <>
Commits on Mar 6, 2011
  1. refactor owl_zephyr_zlog_in and report errors in owl_zephyr_zlog_{in,…

    Karl Ramm committed Feb 12, 2011
    Use the function ZParseExposureLevel thoughtfully provided by the library,
    and see what happens when we actually report errors that occur here.
    Reviewed-By: Nelson Elhage <>
  2. refactor owl_zephyr_get_message

    Karl Ramm committed Feb 12, 2011
    Refactor and make the control flow simpler.  Really this code
    should get moved to perl.
    Reviewed-By: Nelson Elhage <>
  3. make the unsuball functions's error handling fit in with the rest of …

    Karl Ramm committed Feb 12, 2011
    …the program
    "what is this, I don't even"
    runing com_err in the middle of a curses program is just plain wrong.
    Reviewed-By: Nelson Elhage <>
  4. when something goes wrong, give more information about what happened

    Karl Ramm committed Feb 12, 2011
    These various utility functions, instead of just saying "there was an
    error", should report to the user what the library thinks went wrong
    so they user has some small chance of debugging the problem.
    Reviewed-By: Nelson Elhage <>
  5. owl_zephyr_initialize only needs one zephyr library return value

    Karl Ramm committed Feb 12, 2011
    It doesn't need two separate return-value variabels, and the one
    should be a Code_t.
    Reviewed-By: Nelson Elhage <>
Commits on Mar 5, 2011
  1. Replace the remaining snprintfs with g_strdup_printf

    davidben committed Feb 28, 2011
    Hard-coded buffer sizes are silly.
  2. Make owl_variable's get_tostring_fn return a newly allocated string

    davidben committed Feb 28, 2011
    The mess with buffer lengths and whatnot is obnoxious. Note that this
    does change semantics slightly: instead of (optionally) filling a buffer
    and giving a return code for good vs no-variable/invalid, we now return
    NULL for missing variables and always return a string if the variable
    exists. This also appears to be more accurate from the perspective of
    the calls anyway.
Commits on Mar 2, 2011
  1. Load Encode module for IRC.

    timhillgit committed with nelhage Mar 2, 2011
    This normally doesn't cause any problems because the Jabber module has already
    loaded, but can manifest if you run a barnowl with IRC loaded but not
    Jabber. It's clearly wrong, in any case.
Commits on Feb 27, 2011
  1. Use g_get_host_name instead of gethostname and MAXHOSTNAMELEN

    davidben committed Jan 4, 2011
    This lets us punt thishost from owl_global. g_get_host_name implements
    the same localhost fallback, so we really don't need it.
    Also, Solaris gets upset about MAXHOSTNAMELEN when you define
    _XOPEN_SOURCE=500 without __EXTENSIONS__, if we ever care to get rid of
    that. (That said, glib's answer to this is lame. They just hardcode 100
    and even forget to NUL-terminate the buffer; POSIX is apparently
    braindead and leaves truncation undefined. glibc is kind enough to give
Commits on Feb 26, 2011
  1. Apply default attributes after processing commands

    davidben committed Feb 25, 2011
    Otherwise we reset the color after every clump of formatting characters,
    whether it includes a color or not. (Though this never happens because
    of how we generate fmtext.) Also, actually modify the current attr so
    that default_attrs works with search.
    (While I'm at it, simplify _owl_fmtext_append_fmtext a bit.)
  2. Remove default_{attrs,fgcolor,bgcolor} from owl_fmtext

    davidben committed Feb 25, 2011
    They didn't quite behave when appending two owl_fmtexts together; what
    does it mean to append a string whose default color is red to one whose
    default color is blue? (And then you set the default to green
    Now owl_fmtext is merely a unicode string with formatting characters.
    Default attributes are instead a property of how you view the string and
    are passed to owl_fmtext_curs_waddstr. Which unfortunately means it has
    a lot of arguments. :-/
  3. Don't precompute UTF-8 encodings of format characters

    davidben committed Feb 25, 2011
    GString can append gunichar just fine.
Commits on Feb 24, 2011
  1. Sort the output of :irc-names

    nelhage committed Jun 17, 2010
Commits on Feb 23, 2011
  1. Push typos in unpunt synopsis

    davidben committed Feb 23, 2011
  2. Should owl_zwrite_new fail to parse zaway, check the result

    davidben committed Feb 20, 2011
    In particular, should I try to reply to my good friend '-c', I might
    find myself a little bit depressed. Though we ought to take care of this
    case otherwise.
  3. Correctly quote reply messages in owl_zephyr_zaway

    davidben committed Feb 20, 2011
    Oh, I'll just go and send an automated away message to my good friend,
    '-c sipb'. It's not that big of a deal since we only make outgoing
    messages out of this though.
  4. Kill owl_fmtext_set_char

    davidben committed Feb 20, 2011
    This function is a little disturbing and, thankfully, no longer used by
  5. Use owl_util_makepath instead of faking ~ expansion by owl_text_subst…

    andersk committed Feb 12, 2011
    Signed-off-by: Anders Kaseorg <>
  6. Prepend "UNAUTH: " to displayed sender for unauthenticated zephyrs

    aglasgall committed with nelhage Feb 11, 2011
    This patch extends the default style to indicate if a zephyr message
    is unauthenticated.
    [ Tweak the styling, and also catch personals.]
Commits on Feb 14, 2011
  1. Fix a typo in zephyr.c

    nelhage committed Feb 14, 2011
Commits on Feb 11, 2011
  1. Replace owl_sprintf with g_strdup_printf.

    andersk committed Aug 27, 2009
    Signed-off-by: Anders Kaseorg <>
    Reviewed-by: Karl Ramm <>