Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Console-script, sql.Operation, fix examples #255

Merged

Conversation

vmuriart
Copy link
Contributor

Needs to add tests for sqlparse cli script. Decreases coverage by 3% 😢

@coveralls
Copy link

coveralls commented Jun 12, 2016

Coverage Status

Coverage decreased (-3.7%) to 93.303% when pulling 42fb1d0 on vmuriart:console-script-examples-sqlOperation into 50de51a on andialbrecht:master.

@codecov-io
Copy link

codecov-io commented Jun 12, 2016

Current coverage is 93.30%

Merging #255 into master will decrease coverage by 3.69%

@@             master       #255   diff @@
==========================================
  Files            20         21     +1   
  Lines          1265       1314    +49   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           1227       1226     -1   
- Misses           38         88    +50   
  Partials          0          0          

Powered by Codecov. Last updated by 50de51a...42fb1d0

@vmuriart
Copy link
Contributor Author

From 97% to 93.3% 😢.

@vmuriart vmuriart merged commit 8ad4405 into andialbrecht:master Jun 12, 2016
@vmuriart vmuriart deleted the console-script-examples-sqlOperation branch June 12, 2016 20:10
@andialbrecht
Copy link
Owner

@vmuriart the sqlformat script wasn't included in coverage before ;)

ovr pushed a commit to cube-js/sqlparse that referenced this pull request Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants