-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Console-script, sql.Operation, fix examples #255
Merged
vmuriart
merged 8 commits into
andialbrecht:master
from
vmuriart:console-script-examples-sqlOperation
Jun 12, 2016
Merged
Add Console-script, sql.Operation, fix examples #255
vmuriart
merged 8 commits into
andialbrecht:master
from
vmuriart:console-script-examples-sqlOperation
Jun 12, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alternate form to transverse the tlists and clean up matching.
switch scripts to console-script
cleanup example
Current coverage is 93.30%@@ master #255 diff @@
==========================================
Files 20 21 +1
Lines 1265 1314 +49
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 1227 1226 -1
- Misses 38 88 +50
Partials 0 0
|
From 97% to 93.3% 😢. |
@vmuriart the sqlformat script wasn't included in coverage before ;) |
ovr
pushed a commit
to cube-js/sqlparse
that referenced
this pull request
Dec 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to add tests for sqlparse cli script. Decreases coverage by 3% 😢