token_next shouldn't ignore skip_cm argument #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # TODO: May need to implement skip_cm for upstream changes. | ||
| # TODO: May need to re-add default value to idx | ||
| def token_next(self, idx, skip_ws=True, skip_cm=False): | ||
| def token_next(self, idx, skip_ws=True, skip_cm=False, _reverse=False): |
Contributor
There was a problem hiding this comment.
whats the intent of _reverse vs using token_prev?
Contributor
There was a problem hiding this comment.
Just noticed the refactoring right above this line on token_prev.
vmuriart
added a commit
that referenced
this pull request
Jun 20, 2016
| " from dual) t0"]) | ||
|
|
||
|
|
||
| def token_next_doesnt_ignore_skip_cm(): |
Contributor
There was a problem hiding this comment.
The prefix test_ was missing on the test name, and wasn't actually running. Just corrected it, but wanted to give you an FYI 😄
Contributor
Author
|
Whoops! Thanks @vmuriart |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seemed like this got left behind during all the refactoring