Skip to content

Loading…

Pausehack -- apply *after* or *instead of* rjbs' pull request #6

Merged
merged 51 commits into from

4 participants

@dagolden

This adds a couple commits. One removes the need for sqlite3 which crept into tests. The other fixes the long dormant $Id variable.

xdg and others added some commits
@xdg xdg Create SQLite schemas based on MySQL schemas 4a12213
@rjbs rjbs use YAML::XS, not YAML::Syck 1112480
@rjbs rjbs do not use NOW() -- it precludes SQLite cbf12e3
@xdg xdg Add PID_DIR config option 9e0d81c
@rjbs rjbs add a min file count option 0773671
@rjbs rjbs avoid another mysql function d6c39c2
@rjbs rjbs put these methods in PAUSE to avoid package issues
I wish we did not have so many packages in each file!
ef16cc2
@xdg xdg README note missing gpg key details ff5fee1
@xdg xdg Add ML_CHOWN_USER config option 6154138
@xdg xdg add ML_MAILER option cbae2c9
@xdg xdg Sort PAUSE config hash f58956a
@rjbs rjbs make 02packages min lines option 79744cb
@xdg xdg Add ML_CHOWN_GROUP config option bd4e101
@xdg xdg Use db-specific handle to find email addresses af2b397
@rjbs rjbs minor syntactic changes to improve synhi in vim 5796bae
@rjbs rjbs remove unused prototypes 7c5093b
@rjbs rjbs do not re-use db connections
The code assumes that both databases live on one server, which is
not a safe assumption.  Then the passed-in connection must be for the
mod table, but is used for authen, too.  We now remove
that option, and will have a shared DB manager later.
237c3d7
@rjbs rjbs eliminate hard tabs bebaaea
@rjbs rjbs rename the work and work2 methods more descriptively 5e73d17
@rjbs rjbs more qq{} conversion for vim's sake a5102f6
@xdg xdg ensure newlines on logging eba6a30
@xdg xdg Split CHECKSUMS_SIGNING_PROGRAM into program/args
New config option CHECKSUM_SIGNING_ARGS added.  IPC::Cmd added
as a prerequisite.

If the signing program isn't available, don't try to sign checksums.

Putting in a fake signing program gives an easy way to disable signing
for testing without ANDK's actual key.

(Longer term, need to break up the arguments as well and check those.)
2026586
@rjbs rjbs rename badly-named mldistwatch test b20754a
@rjbs rjbs use File::Which to find tar and unzip programs
otherwise we need more config, which I would rather avoid for now
(see, my Mac on which I am testing does not put these programs in
the places expected, I guess; it uses /usr/bin/tar)
9051421
@rjbs rjbs give a clearer error when 02package cannot be opened
(i.e., include the exact path being opened and the error)
e6b19cd
@rjbs rjbs simple-but-useful test that mldistwatch actually works
...including the import of a fakecpan from fakecpan.org
6905d15
@rjbs rjbs make testpause return an inspectable results obj 7e06c41
@rjbs rjbs new option to suppress trying to use gpg c4aa720
@rjbs rjbs more coping with gzip not being where or what expected e9f848f
@rjbs rjbs give test results access to index dbs
...and use it
19521ef
@rjbs rjbs give clearer errors when skipping ! -f files to rewrote 5c8b135
@rjbs rjbs add parsed 02packages data to pause tester results
...and use it
b012dd4
@xdg xdg Mega cleanup of log messages
These edits are mostly for consistency, e.g. upper case, no extraneous
starting newlines, some sort of descriptive intro, etc.
f89a7ed
@rjbs rjbs put a chdir guard in the reindex tester 6422a60
@rjbs rjbs give the method a clearer name: test_reindex 4c58c5b
@xdg xdg Cleanup insert logging 7a6fb84
@xdg xdg Break out PAUSE::dist and PAUSE::mldistwatch::Constants 0d3be4a
@rjbs rjbs replace global fh with lexical fh 3895ded
@rjbs rjbs trivial whitespace cleanup to avoid long lines f2a01d0
@rjbs rjbs make t/pmfile.t pass again after logging tweaks d9e1af5
@xdg xdg Extract more mldistwatch::Constants 5db3e9c
@xdg xdg Extract PAUSE::pmfile 0803244
@xdg xdg Fix test for skipping message c91a576
@xdg xdg use Test::Deep cmp_deeply throughout 3c57cff
@xdg xdg Extracted PAUSE::package ad735c0
@rjbs rjbs convert mail-sending to use Email::Sender
this means (a) we can use Email::MIME, so later ::Kit but for now,
more importantly, it means that (b) we can *test* the mail we send
trivially
ebc51a5
@xdg xdg cleanup 'package' statements in PAUSE::mldistwatch b959d40
@rjbs rjbs add new prereqs 853ca02
@xdg xdg Add DB_File to Makefile.PL 07a162d
@xdg xdg Remove need for sqlite3
Uses DBIx::RunSQL instead to create tables for testing.
c571410
@xdg xdg Fix $Id variable
It used to be an SVN identifier.  This commit makes it a string
based on PAUSE $VERSION instead.
50e39e0
@andk andk merged commit b903f9a into andk:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 13, 2011
  1. @xdg
  2. @rjbs

    use YAML::XS, not YAML::Syck

    rjbs committed
  3. @rjbs
  4. @xdg

    Add PID_DIR config option

    xdg committed
  5. @rjbs

    add a min file count option

    rjbs committed
  6. @rjbs

    avoid another mysql function

    rjbs committed
  7. @rjbs

    put these methods in PAUSE to avoid package issues

    rjbs committed
    I wish we did not have so many packages in each file!
  8. @xdg

    README note missing gpg key details

    xdg committed
  9. @xdg

    Add ML_CHOWN_USER config option

    xdg committed
  10. @xdg

    add ML_MAILER option

    xdg committed
  11. @xdg

    Sort PAUSE config hash

    xdg committed
  12. @rjbs

    make 02packages min lines option

    rjbs committed
  13. @xdg

    Add ML_CHOWN_GROUP config option

    xdg committed
  14. @xdg
  15. @rjbs
  16. @rjbs

    remove unused prototypes

    rjbs committed
  17. @rjbs

    do not re-use db connections

    rjbs committed
    The code assumes that both databases live on one server, which is
    not a safe assumption.  Then the passed-in connection must be for the
    mod table, but is used for authen, too.  We now remove
    that option, and will have a shared DB manager later.
  18. @rjbs

    eliminate hard tabs

    rjbs committed
  19. @rjbs
  20. @rjbs

    more qq{} conversion for vim's sake

    rjbs committed
  21. @xdg

    ensure newlines on logging

    xdg committed
  22. @xdg

    Split CHECKSUMS_SIGNING_PROGRAM into program/args

    xdg committed
    New config option CHECKSUM_SIGNING_ARGS added.  IPC::Cmd added
    as a prerequisite.
    
    If the signing program isn't available, don't try to sign checksums.
    
    Putting in a fake signing program gives an easy way to disable signing
    for testing without ANDK's actual key.
    
    (Longer term, need to break up the arguments as well and check those.)
  23. @rjbs
  24. @rjbs

    use File::Which to find tar and unzip programs

    rjbs committed
    otherwise we need more config, which I would rather avoid for now
    (see, my Mac on which I am testing does not put these programs in
    the places expected, I guess; it uses /usr/bin/tar)
  25. @rjbs

    give a clearer error when 02package cannot be opened

    rjbs committed
    (i.e., include the exact path being opened and the error)
  26. @rjbs

    simple-but-useful test that mldistwatch actually works

    rjbs committed
    ...including the import of a fakecpan from fakecpan.org
  27. @rjbs
  28. @rjbs
  29. @rjbs
  30. @rjbs

    give test results access to index dbs

    rjbs committed
    ...and use it
  31. @rjbs
  32. @rjbs

    add parsed 02packages data to pause tester results

    rjbs committed
    ...and use it
  33. @xdg @rjbs

    Mega cleanup of log messages

    xdg committed with rjbs
    These edits are mostly for consistency, e.g. upper case, no extraneous
    starting newlines, some sort of descriptive intro, etc.
  34. @rjbs
  35. @rjbs
  36. @xdg

    Cleanup insert logging

    xdg committed
  37. @xdg
  38. @rjbs

    replace global fh with lexical fh

    rjbs committed
  39. @rjbs
  40. @rjbs
  41. @xdg

    Extract more mldistwatch::Constants

    xdg committed
  42. @xdg

    Extract PAUSE::pmfile

    xdg committed
  43. @xdg

    Fix test for skipping message

    xdg committed
  44. @xdg

    use Test::Deep cmp_deeply throughout

    xdg committed
  45. @xdg

    Extracted PAUSE::package

    xdg committed
  46. @rjbs

    convert mail-sending to use Email::Sender

    rjbs committed
    this means (a) we can use Email::MIME, so later ::Kit but for now,
    more importantly, it means that (b) we can *test* the mail we send
    trivially
  47. @xdg
  48. @rjbs

    add new prereqs

    rjbs committed
Commits on Aug 15, 2011
  1. @xdg

    Add DB_File to Makefile.PL

    xdg committed
  2. @xdg

    Remove need for sqlite3

    xdg committed
    Uses DBIx::RunSQL instead to create tables for testing.
  3. @xdg

    Fix $Id variable

    xdg committed
    It used to be an SVN identifier.  This commit makes it a string
    based on PAUSE $VERSION instead.
Something went wrong with that request. Please try again.