Pausehack -- apply *after* or *instead of* rjbs' pull request #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wish we did not have so many packages in each file!
The code assumes that both databases live on one server, which is not a safe assumption. Then the passed-in connection must be for the mod table, but is used for authen, too. We now remove that option, and will have a shared DB manager later.
New config option CHECKSUM_SIGNING_ARGS added. IPC::Cmd added as a prerequisite. If the signing program isn't available, don't try to sign checksums. Putting in a fake signing program gives an easy way to disable signing for testing without ANDK's actual key. (Longer term, need to break up the arguments as well and check those.)
otherwise we need more config, which I would rather avoid for now (see, my Mac on which I am testing does not put these programs in the places expected, I guess; it uses /usr/bin/tar)
(i.e., include the exact path being opened and the error)
...including the import of a fakecpan from fakecpan.org
...and use it
...and use it
These edits are mostly for consistency, e.g. upper case, no extraneous starting newlines, some sort of descriptive intro, etc.
this means (a) we can use Email::MIME, so later ::Kit but for now, more importantly, it means that (b) we can *test* the mail we send trivially
Uses DBIx::RunSQL instead to create tables for testing.
It used to be an SVN identifier. This commit makes it a string based on PAUSE $VERSION instead.
andk
added a commit
that referenced
this pull request
Aug 16, 2011
Pausehack -- apply *after* or *instead of* rjbs' pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a couple commits. One removes the need for sqlite3 which crept into tests. The other fixes the long dormant $Id variable.