Skip to content
This repository

Pausehack -- apply *after* or *instead of* rjbs' pull request #6

Merged
merged 51 commits into from over 2 years ago

3 participants

David Golden andk Ricardo Signes
David Golden

This adds a couple commits. One removes the need for sqlite3 which crept into tests. The other fixes the long dormant $Id variable.

and others added some commits August 13, 2011
David Golden Create SQLite schemas based on MySQL schemas 4a12213
Ricardo Signes use YAML::XS, not YAML::Syck 1112480
Ricardo Signes do not use NOW() -- it precludes SQLite cbf12e3
David Golden Add PID_DIR config option 9e0d81c
Ricardo Signes add a min file count option 0773671
Ricardo Signes avoid another mysql function d6c39c2
Ricardo Signes put these methods in PAUSE to avoid package issues
I wish we did not have so many packages in each file!
ef16cc2
David Golden README note missing gpg key details ff5fee1
David Golden Add ML_CHOWN_USER config option 6154138
David Golden add ML_MAILER option cbae2c9
David Golden Sort PAUSE config hash f58956a
Ricardo Signes make 02packages min lines option 79744cb
David Golden Add ML_CHOWN_GROUP config option bd4e101
David Golden Use db-specific handle to find email addresses af2b397
Ricardo Signes minor syntactic changes to improve synhi in vim 5796bae
Ricardo Signes remove unused prototypes 7c5093b
Ricardo Signes do not re-use db connections
The code assumes that both databases live on one server, which is
not a safe assumption.  Then the passed-in connection must be for the
mod table, but is used for authen, too.  We now remove
that option, and will have a shared DB manager later.
237c3d7
Ricardo Signes eliminate hard tabs bebaaea
Ricardo Signes rename the work and work2 methods more descriptively 5e73d17
Ricardo Signes more qq{} conversion for vim's sake a5102f6
David Golden ensure newlines on logging eba6a30
David Golden Split CHECKSUMS_SIGNING_PROGRAM into program/args
New config option CHECKSUM_SIGNING_ARGS added.  IPC::Cmd added
as a prerequisite.

If the signing program isn't available, don't try to sign checksums.

Putting in a fake signing program gives an easy way to disable signing
for testing without ANDK's actual key.

(Longer term, need to break up the arguments as well and check those.)
2026586
Ricardo Signes rename badly-named mldistwatch test b20754a
Ricardo Signes use File::Which to find tar and unzip programs
otherwise we need more config, which I would rather avoid for now
(see, my Mac on which I am testing does not put these programs in
the places expected, I guess; it uses /usr/bin/tar)
9051421
Ricardo Signes give a clearer error when 02package cannot be opened
(i.e., include the exact path being opened and the error)
e6b19cd
Ricardo Signes simple-but-useful test that mldistwatch actually works
...including the import of a fakecpan from fakecpan.org
6905d15
Ricardo Signes make testpause return an inspectable results obj 7e06c41
Ricardo Signes new option to suppress trying to use gpg c4aa720
Ricardo Signes more coping with gzip not being where or what expected e9f848f
Ricardo Signes give test results access to index dbs
...and use it
19521ef
Ricardo Signes give clearer errors when skipping ! -f files to rewrote 5c8b135
Ricardo Signes add parsed 02packages data to pause tester results
...and use it
b012dd4
David Golden Mega cleanup of log messages
These edits are mostly for consistency, e.g. upper case, no extraneous
starting newlines, some sort of descriptive intro, etc.
f89a7ed
Ricardo Signes put a chdir guard in the reindex tester 6422a60
Ricardo Signes give the method a clearer name: test_reindex 4c58c5b
David Golden Cleanup insert logging 7a6fb84
David Golden Break out PAUSE::dist and PAUSE::mldistwatch::Constants 0d3be4a
Ricardo Signes replace global fh with lexical fh 3895ded
Ricardo Signes trivial whitespace cleanup to avoid long lines f2a01d0
Ricardo Signes make t/pmfile.t pass again after logging tweaks d9e1af5
David Golden Extract more mldistwatch::Constants 5db3e9c
David Golden Extract PAUSE::pmfile 0803244
David Golden Fix test for skipping message c91a576
David Golden use Test::Deep cmp_deeply throughout 3c57cff
David Golden Extracted PAUSE::package ad735c0
Ricardo Signes convert mail-sending to use Email::Sender
this means (a) we can use Email::MIME, so later ::Kit but for now,
more importantly, it means that (b) we can *test* the mail we send
trivially
ebc51a5
David Golden cleanup 'package' statements in PAUSE::mldistwatch b959d40
Ricardo Signes add new prereqs 853ca02
David Golden Add DB_File to Makefile.PL 07a162d
David Golden Remove need for sqlite3
Uses DBIx::RunSQL instead to create tables for testing.
c571410
David Golden Fix $Id variable
It used to be an SVN identifier.  This commit makes it a string
based on PAUSE $VERSION instead.
50e39e0
andk andk merged commit b903f9a into from August 16, 2011
andk andk closed this August 16, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 51 unique commits by 2 authors.

Aug 13, 2011
David Golden Create SQLite schemas based on MySQL schemas 4a12213
Ricardo Signes use YAML::XS, not YAML::Syck 1112480
Ricardo Signes do not use NOW() -- it precludes SQLite cbf12e3
David Golden Add PID_DIR config option 9e0d81c
Ricardo Signes add a min file count option 0773671
Ricardo Signes avoid another mysql function d6c39c2
Ricardo Signes put these methods in PAUSE to avoid package issues
I wish we did not have so many packages in each file!
ef16cc2
David Golden README note missing gpg key details ff5fee1
David Golden Add ML_CHOWN_USER config option 6154138
David Golden add ML_MAILER option cbae2c9
David Golden Sort PAUSE config hash f58956a
Ricardo Signes make 02packages min lines option 79744cb
David Golden Add ML_CHOWN_GROUP config option bd4e101
David Golden Use db-specific handle to find email addresses af2b397
Ricardo Signes minor syntactic changes to improve synhi in vim 5796bae
Ricardo Signes remove unused prototypes 7c5093b
Ricardo Signes do not re-use db connections
The code assumes that both databases live on one server, which is
not a safe assumption.  Then the passed-in connection must be for the
mod table, but is used for authen, too.  We now remove
that option, and will have a shared DB manager later.
237c3d7
Ricardo Signes eliminate hard tabs bebaaea
Ricardo Signes rename the work and work2 methods more descriptively 5e73d17
Ricardo Signes more qq{} conversion for vim's sake a5102f6
David Golden ensure newlines on logging eba6a30
David Golden Split CHECKSUMS_SIGNING_PROGRAM into program/args
New config option CHECKSUM_SIGNING_ARGS added.  IPC::Cmd added
as a prerequisite.

If the signing program isn't available, don't try to sign checksums.

Putting in a fake signing program gives an easy way to disable signing
for testing without ANDK's actual key.

(Longer term, need to break up the arguments as well and check those.)
2026586
Ricardo Signes rename badly-named mldistwatch test b20754a
Ricardo Signes use File::Which to find tar and unzip programs
otherwise we need more config, which I would rather avoid for now
(see, my Mac on which I am testing does not put these programs in
the places expected, I guess; it uses /usr/bin/tar)
9051421
Ricardo Signes give a clearer error when 02package cannot be opened
(i.e., include the exact path being opened and the error)
e6b19cd
Ricardo Signes simple-but-useful test that mldistwatch actually works
...including the import of a fakecpan from fakecpan.org
6905d15
Ricardo Signes make testpause return an inspectable results obj 7e06c41
Ricardo Signes new option to suppress trying to use gpg c4aa720
Ricardo Signes more coping with gzip not being where or what expected e9f848f
Ricardo Signes give test results access to index dbs
...and use it
19521ef
Ricardo Signes give clearer errors when skipping ! -f files to rewrote 5c8b135
Ricardo Signes add parsed 02packages data to pause tester results
...and use it
b012dd4
David Golden Mega cleanup of log messages
These edits are mostly for consistency, e.g. upper case, no extraneous
starting newlines, some sort of descriptive intro, etc.
f89a7ed
Ricardo Signes put a chdir guard in the reindex tester 6422a60
Ricardo Signes give the method a clearer name: test_reindex 4c58c5b
David Golden Cleanup insert logging 7a6fb84
David Golden Break out PAUSE::dist and PAUSE::mldistwatch::Constants 0d3be4a
Ricardo Signes replace global fh with lexical fh 3895ded
Ricardo Signes trivial whitespace cleanup to avoid long lines f2a01d0
Ricardo Signes make t/pmfile.t pass again after logging tweaks d9e1af5
David Golden Extract more mldistwatch::Constants 5db3e9c
David Golden Extract PAUSE::pmfile 0803244
David Golden Fix test for skipping message c91a576
David Golden use Test::Deep cmp_deeply throughout 3c57cff
David Golden Extracted PAUSE::package ad735c0
Ricardo Signes convert mail-sending to use Email::Sender
this means (a) we can use Email::MIME, so later ::Kit but for now,
more importantly, it means that (b) we can *test* the mail we send
trivially
ebc51a5
David Golden cleanup 'package' statements in PAUSE::mldistwatch b959d40
Ricardo Signes add new prereqs 853ca02
Aug 14, 2011
David Golden Add DB_File to Makefile.PL 07a162d
David Golden Remove need for sqlite3
Uses DBIx::RunSQL instead to create tables for testing.
c571410
David Golden Fix $Id variable
It used to be an SVN identifier.  This commit makes it a string
based on PAUSE $VERSION instead.
50e39e0
Something went wrong with that request. Please try again.