Pausehack -- apply *after* or *instead of* rjbs' pull request #6

Merged
merged 51 commits into from Aug 16, 2011

Conversation

Projects
None yet
4 participants
@ghost
Contributor

ghost commented Aug 14, 2011

This adds a couple commits. One removes the need for sqlite3 which crept into tests. The other fixes the long dormant $Id variable.

xdg and others added some commits Aug 13, 2011

put these methods in PAUSE to avoid package issues
I wish we did not have so many packages in each file!
do not re-use db connections
The code assumes that both databases live on one server, which is
not a safe assumption.  Then the passed-in connection must be for the
mod table, but is used for authen, too.  We now remove
that option, and will have a shared DB manager later.
Split CHECKSUMS_SIGNING_PROGRAM into program/args
New config option CHECKSUM_SIGNING_ARGS added.  IPC::Cmd added
as a prerequisite.

If the signing program isn't available, don't try to sign checksums.

Putting in a fake signing program gives an easy way to disable signing
for testing without ANDK's actual key.

(Longer term, need to break up the arguments as well and check those.)
use File::Which to find tar and unzip programs
otherwise we need more config, which I would rather avoid for now
(see, my Mac on which I am testing does not put these programs in
the places expected, I guess; it uses /usr/bin/tar)
give a clearer error when 02package cannot be opened
(i.e., include the exact path being opened and the error)
simple-but-useful test that mldistwatch actually works
...including the import of a fakecpan from fakecpan.org
Mega cleanup of log messages
These edits are mostly for consistency, e.g. upper case, no extraneous
starting newlines, some sort of descriptive intro, etc.
convert mail-sending to use Email::Sender
this means (a) we can use Email::MIME, so later ::Kit but for now,
more importantly, it means that (b) we can *test* the mail we send
trivially
Remove need for sqlite3
Uses DBIx::RunSQL instead to create tables for testing.
Fix $Id variable
It used to be an SVN identifier.  This commit makes it a string
based on PAUSE $VERSION instead.

andk added a commit that referenced this pull request Aug 16, 2011

Merge pull request #6 from dagolden/pausehack
Pausehack -- apply *after* or *instead of* rjbs' pull request

@andk andk merged commit b903f9a into andk:master Aug 16, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment