Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Pausehack -- apply *after* or *instead of* rjbs' pull request #6

Merged
merged 51 commits into from

3 participants

David Golden andk Ricardo Signes
David Golden

This adds a couple commits. One removes the need for sqlite3 which crept into tests. The other fixes the long dormant $Id variable.

dagolden and others added some commits
David Golden dagolden Create SQLite schemas based on MySQL schemas 4a12213
Ricardo Signes rjbs use YAML::XS, not YAML::Syck 1112480
Ricardo Signes rjbs do not use NOW() -- it precludes SQLite cbf12e3
David Golden dagolden Add PID_DIR config option 9e0d81c
Ricardo Signes rjbs add a min file count option 0773671
Ricardo Signes rjbs avoid another mysql function d6c39c2
Ricardo Signes rjbs put these methods in PAUSE to avoid package issues
I wish we did not have so many packages in each file!
ef16cc2
David Golden dagolden README note missing gpg key details ff5fee1
David Golden dagolden Add ML_CHOWN_USER config option 6154138
David Golden dagolden add ML_MAILER option cbae2c9
David Golden dagolden Sort PAUSE config hash f58956a
Ricardo Signes rjbs make 02packages min lines option 79744cb
David Golden dagolden Add ML_CHOWN_GROUP config option bd4e101
David Golden dagolden Use db-specific handle to find email addresses af2b397
Ricardo Signes rjbs minor syntactic changes to improve synhi in vim 5796bae
Ricardo Signes rjbs remove unused prototypes 7c5093b
Ricardo Signes rjbs do not re-use db connections
The code assumes that both databases live on one server, which is
not a safe assumption.  Then the passed-in connection must be for the
mod table, but is used for authen, too.  We now remove
that option, and will have a shared DB manager later.
237c3d7
Ricardo Signes rjbs eliminate hard tabs bebaaea
Ricardo Signes rjbs rename the work and work2 methods more descriptively 5e73d17
Ricardo Signes rjbs more qq{} conversion for vim's sake a5102f6
David Golden dagolden ensure newlines on logging eba6a30
David Golden dagolden Split CHECKSUMS_SIGNING_PROGRAM into program/args
New config option CHECKSUM_SIGNING_ARGS added.  IPC::Cmd added
as a prerequisite.

If the signing program isn't available, don't try to sign checksums.

Putting in a fake signing program gives an easy way to disable signing
for testing without ANDK's actual key.

(Longer term, need to break up the arguments as well and check those.)
2026586
Ricardo Signes rjbs rename badly-named mldistwatch test b20754a
Ricardo Signes rjbs use File::Which to find tar and unzip programs
otherwise we need more config, which I would rather avoid for now
(see, my Mac on which I am testing does not put these programs in
the places expected, I guess; it uses /usr/bin/tar)
9051421
Ricardo Signes rjbs give a clearer error when 02package cannot be opened
(i.e., include the exact path being opened and the error)
e6b19cd
Ricardo Signes rjbs simple-but-useful test that mldistwatch actually works
...including the import of a fakecpan from fakecpan.org
6905d15
Ricardo Signes rjbs make testpause return an inspectable results obj 7e06c41
Ricardo Signes rjbs new option to suppress trying to use gpg c4aa720
Ricardo Signes rjbs more coping with gzip not being where or what expected e9f848f
Ricardo Signes rjbs give test results access to index dbs
...and use it
19521ef
Ricardo Signes rjbs give clearer errors when skipping ! -f files to rewrote 5c8b135
Ricardo Signes rjbs add parsed 02packages data to pause tester results
...and use it
b012dd4
David Golden dagolden Mega cleanup of log messages
These edits are mostly for consistency, e.g. upper case, no extraneous
starting newlines, some sort of descriptive intro, etc.
f89a7ed
Ricardo Signes rjbs put a chdir guard in the reindex tester 6422a60
Ricardo Signes rjbs give the method a clearer name: test_reindex 4c58c5b
David Golden dagolden Cleanup insert logging 7a6fb84
David Golden dagolden Break out PAUSE::dist and PAUSE::mldistwatch::Constants 0d3be4a
Ricardo Signes rjbs replace global fh with lexical fh 3895ded
Ricardo Signes rjbs trivial whitespace cleanup to avoid long lines f2a01d0
Ricardo Signes rjbs make t/pmfile.t pass again after logging tweaks d9e1af5
David Golden dagolden Extract more mldistwatch::Constants 5db3e9c
David Golden dagolden Extract PAUSE::pmfile 0803244
David Golden dagolden Fix test for skipping message c91a576
David Golden dagolden use Test::Deep cmp_deeply throughout 3c57cff
David Golden dagolden Extracted PAUSE::package ad735c0
Ricardo Signes rjbs convert mail-sending to use Email::Sender
this means (a) we can use Email::MIME, so later ::Kit but for now,
more importantly, it means that (b) we can *test* the mail we send
trivially
ebc51a5
David Golden dagolden cleanup 'package' statements in PAUSE::mldistwatch b959d40
Ricardo Signes rjbs add new prereqs 853ca02
David Golden dagolden Add DB_File to Makefile.PL 07a162d
David Golden dagolden Remove need for sqlite3
Uses DBIx::RunSQL instead to create tables for testing.
c571410
David Golden dagolden Fix $Id variable
It used to be an SVN identifier.  This commit makes it a string
based on PAUSE $VERSION instead.
50e39e0
andk andk merged commit b903f9a into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 13, 2011
  1. David Golden
  2. Ricardo Signes

    use YAML::XS, not YAML::Syck

    rjbs authored
  3. Ricardo Signes
  4. David Golden

    Add PID_DIR config option

    dagolden authored
  5. Ricardo Signes

    add a min file count option

    rjbs authored
  6. Ricardo Signes

    avoid another mysql function

    rjbs authored
  7. Ricardo Signes

    put these methods in PAUSE to avoid package issues

    rjbs authored
    I wish we did not have so many packages in each file!
  8. David Golden
  9. David Golden
  10. David Golden

    add ML_MAILER option

    dagolden authored
  11. David Golden

    Sort PAUSE config hash

    dagolden authored
  12. Ricardo Signes

    make 02packages min lines option

    rjbs authored
  13. David Golden
  14. David Golden
  15. Ricardo Signes
  16. Ricardo Signes

    remove unused prototypes

    rjbs authored
  17. Ricardo Signes

    do not re-use db connections

    rjbs authored
    The code assumes that both databases live on one server, which is
    not a safe assumption.  Then the passed-in connection must be for the
    mod table, but is used for authen, too.  We now remove
    that option, and will have a shared DB manager later.
  18. Ricardo Signes

    eliminate hard tabs

    rjbs authored
  19. Ricardo Signes
  20. Ricardo Signes
  21. David Golden

    ensure newlines on logging

    dagolden authored
  22. David Golden

    Split CHECKSUMS_SIGNING_PROGRAM into program/args

    dagolden authored
    New config option CHECKSUM_SIGNING_ARGS added.  IPC::Cmd added
    as a prerequisite.
    
    If the signing program isn't available, don't try to sign checksums.
    
    Putting in a fake signing program gives an easy way to disable signing
    for testing without ANDK's actual key.
    
    (Longer term, need to break up the arguments as well and check those.)
  23. Ricardo Signes
  24. Ricardo Signes

    use File::Which to find tar and unzip programs

    rjbs authored
    otherwise we need more config, which I would rather avoid for now
    (see, my Mac on which I am testing does not put these programs in
    the places expected, I guess; it uses /usr/bin/tar)
  25. Ricardo Signes

    give a clearer error when 02package cannot be opened

    rjbs authored
    (i.e., include the exact path being opened and the error)
  26. Ricardo Signes

    simple-but-useful test that mldistwatch actually works

    rjbs authored
    ...including the import of a fakecpan from fakecpan.org
  27. Ricardo Signes
  28. Ricardo Signes
  29. Ricardo Signes
  30. Ricardo Signes

    give test results access to index dbs

    rjbs authored
    ...and use it
  31. Ricardo Signes
  32. Ricardo Signes

    add parsed 02packages data to pause tester results

    rjbs authored
    ...and use it
  33. David Golden Ricardo Signes

    Mega cleanup of log messages

    dagolden authored rjbs committed
    These edits are mostly for consistency, e.g. upper case, no extraneous
    starting newlines, some sort of descriptive intro, etc.
  34. Ricardo Signes
  35. Ricardo Signes
  36. David Golden

    Cleanup insert logging

    dagolden authored
  37. David Golden
  38. Ricardo Signes

    replace global fh with lexical fh

    rjbs authored
  39. Ricardo Signes
  40. Ricardo Signes
  41. David Golden
  42. David Golden

    Extract PAUSE::pmfile

    dagolden authored
  43. David Golden

    Fix test for skipping message

    dagolden authored
  44. David Golden
  45. David Golden

    Extracted PAUSE::package

    dagolden authored
  46. Ricardo Signes

    convert mail-sending to use Email::Sender

    rjbs authored
    this means (a) we can use Email::MIME, so later ::Kit but for now,
    more importantly, it means that (b) we can *test* the mail we send
    trivially
  47. David Golden
  48. Ricardo Signes

    add new prereqs

    rjbs authored
Commits on Aug 15, 2011
  1. David Golden

    Add DB_File to Makefile.PL

    dagolden authored
  2. David Golden

    Remove need for sqlite3

    dagolden authored
    Uses DBIx::RunSQL instead to create tables for testing.
  3. David Golden

    Fix $Id variable

    dagolden authored
    It used to be an SVN identifier.  This commit makes it a string
    based on PAUSE $VERSION instead.
Something went wrong with that request. Please try again.