Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Pausehack -- apply *after* or *instead of* rjbs' pull request #6

Merged
merged 51 commits into from

3 participants

@dagolden

This adds a couple commits. One removes the need for sqlite3 which crept into tests. The other fixes the long dormant $Id variable.

dagolden and others added some commits
@dagolden dagolden Create SQLite schemas based on MySQL schemas 4a12213
@rjbs rjbs use YAML::XS, not YAML::Syck 1112480
@rjbs rjbs do not use NOW() -- it precludes SQLite cbf12e3
@dagolden dagolden Add PID_DIR config option 9e0d81c
@rjbs rjbs add a min file count option 0773671
@rjbs rjbs avoid another mysql function d6c39c2
@rjbs rjbs put these methods in PAUSE to avoid package issues
I wish we did not have so many packages in each file!
ef16cc2
@dagolden dagolden README note missing gpg key details ff5fee1
@dagolden dagolden Add ML_CHOWN_USER config option 6154138
@dagolden dagolden add ML_MAILER option cbae2c9
@dagolden dagolden Sort PAUSE config hash f58956a
@rjbs rjbs make 02packages min lines option 79744cb
@dagolden dagolden Add ML_CHOWN_GROUP config option bd4e101
@dagolden dagolden Use db-specific handle to find email addresses af2b397
@rjbs rjbs minor syntactic changes to improve synhi in vim 5796bae
@rjbs rjbs remove unused prototypes 7c5093b
@rjbs rjbs do not re-use db connections
The code assumes that both databases live on one server, which is
not a safe assumption.  Then the passed-in connection must be for the
mod table, but is used for authen, too.  We now remove
that option, and will have a shared DB manager later.
237c3d7
@rjbs rjbs eliminate hard tabs bebaaea
@rjbs rjbs rename the work and work2 methods more descriptively 5e73d17
@rjbs rjbs more qq{} conversion for vim's sake a5102f6
@dagolden dagolden ensure newlines on logging eba6a30
@dagolden dagolden Split CHECKSUMS_SIGNING_PROGRAM into program/args
New config option CHECKSUM_SIGNING_ARGS added.  IPC::Cmd added
as a prerequisite.

If the signing program isn't available, don't try to sign checksums.

Putting in a fake signing program gives an easy way to disable signing
for testing without ANDK's actual key.

(Longer term, need to break up the arguments as well and check those.)
2026586
@rjbs rjbs rename badly-named mldistwatch test b20754a
@rjbs rjbs use File::Which to find tar and unzip programs
otherwise we need more config, which I would rather avoid for now
(see, my Mac on which I am testing does not put these programs in
the places expected, I guess; it uses /usr/bin/tar)
9051421
@rjbs rjbs give a clearer error when 02package cannot be opened
(i.e., include the exact path being opened and the error)
e6b19cd
@rjbs rjbs simple-but-useful test that mldistwatch actually works
...including the import of a fakecpan from fakecpan.org
6905d15
@rjbs rjbs make testpause return an inspectable results obj 7e06c41
@rjbs rjbs new option to suppress trying to use gpg c4aa720
@rjbs rjbs more coping with gzip not being where or what expected e9f848f
@rjbs rjbs give test results access to index dbs
...and use it
19521ef
@rjbs rjbs give clearer errors when skipping ! -f files to rewrote 5c8b135
@rjbs rjbs add parsed 02packages data to pause tester results
...and use it
b012dd4
@dagolden dagolden Mega cleanup of log messages
These edits are mostly for consistency, e.g. upper case, no extraneous
starting newlines, some sort of descriptive intro, etc.
f89a7ed
@rjbs rjbs put a chdir guard in the reindex tester 6422a60
@rjbs rjbs give the method a clearer name: test_reindex 4c58c5b
@dagolden dagolden Cleanup insert logging 7a6fb84
@dagolden dagolden Break out PAUSE::dist and PAUSE::mldistwatch::Constants 0d3be4a
@rjbs rjbs replace global fh with lexical fh 3895ded
@rjbs rjbs trivial whitespace cleanup to avoid long lines f2a01d0
@rjbs rjbs make t/pmfile.t pass again after logging tweaks d9e1af5
@dagolden dagolden Extract more mldistwatch::Constants 5db3e9c
@dagolden dagolden Extract PAUSE::pmfile 0803244
@dagolden dagolden Fix test for skipping message c91a576
@dagolden dagolden use Test::Deep cmp_deeply throughout 3c57cff
@dagolden dagolden Extracted PAUSE::package ad735c0
@rjbs rjbs convert mail-sending to use Email::Sender
this means (a) we can use Email::MIME, so later ::Kit but for now,
more importantly, it means that (b) we can *test* the mail we send
trivially
ebc51a5
@dagolden dagolden cleanup 'package' statements in PAUSE::mldistwatch b959d40
@rjbs rjbs add new prereqs 853ca02
@dagolden dagolden Add DB_File to Makefile.PL 07a162d
@dagolden dagolden Remove need for sqlite3
Uses DBIx::RunSQL instead to create tables for testing.
c571410
@dagolden dagolden Fix $Id variable
It used to be an SVN identifier.  This commit makes it a string
based on PAUSE $VERSION instead.
50e39e0
@andk andk merged commit b903f9a into andk:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 13, 2011
  1. @dagolden
  2. @rjbs

    use YAML::XS, not YAML::Syck

    rjbs authored
  3. @rjbs
  4. @dagolden

    Add PID_DIR config option

    dagolden authored
  5. @rjbs

    add a min file count option

    rjbs authored
  6. @rjbs

    avoid another mysql function

    rjbs authored
  7. @rjbs

    put these methods in PAUSE to avoid package issues

    rjbs authored
    I wish we did not have so many packages in each file!
  8. @dagolden
  9. @dagolden
  10. @dagolden

    add ML_MAILER option

    dagolden authored
  11. @dagolden

    Sort PAUSE config hash

    dagolden authored
  12. @rjbs

    make 02packages min lines option

    rjbs authored
  13. @dagolden
  14. @dagolden
  15. @rjbs
  16. @rjbs

    remove unused prototypes

    rjbs authored
  17. @rjbs

    do not re-use db connections

    rjbs authored
    The code assumes that both databases live on one server, which is
    not a safe assumption.  Then the passed-in connection must be for the
    mod table, but is used for authen, too.  We now remove
    that option, and will have a shared DB manager later.
  18. @rjbs

    eliminate hard tabs

    rjbs authored
  19. @rjbs
  20. @rjbs
  21. @dagolden

    ensure newlines on logging

    dagolden authored
  22. @dagolden

    Split CHECKSUMS_SIGNING_PROGRAM into program/args

    dagolden authored
    New config option CHECKSUM_SIGNING_ARGS added.  IPC::Cmd added
    as a prerequisite.
    
    If the signing program isn't available, don't try to sign checksums.
    
    Putting in a fake signing program gives an easy way to disable signing
    for testing without ANDK's actual key.
    
    (Longer term, need to break up the arguments as well and check those.)
  23. @rjbs
  24. @rjbs

    use File::Which to find tar and unzip programs

    rjbs authored
    otherwise we need more config, which I would rather avoid for now
    (see, my Mac on which I am testing does not put these programs in
    the places expected, I guess; it uses /usr/bin/tar)
  25. @rjbs

    give a clearer error when 02package cannot be opened

    rjbs authored
    (i.e., include the exact path being opened and the error)
  26. @rjbs

    simple-but-useful test that mldistwatch actually works

    rjbs authored
    ...including the import of a fakecpan from fakecpan.org
  27. @rjbs
  28. @rjbs
  29. @rjbs
  30. @rjbs

    give test results access to index dbs

    rjbs authored
    ...and use it
  31. @rjbs
  32. @rjbs

    add parsed 02packages data to pause tester results

    rjbs authored
    ...and use it
  33. @dagolden @rjbs

    Mega cleanup of log messages

    dagolden authored rjbs committed
    These edits are mostly for consistency, e.g. upper case, no extraneous
    starting newlines, some sort of descriptive intro, etc.
  34. @rjbs
  35. @rjbs
  36. @dagolden

    Cleanup insert logging

    dagolden authored
  37. @dagolden
  38. @rjbs

    replace global fh with lexical fh

    rjbs authored
  39. @rjbs
  40. @rjbs
  41. @dagolden
  42. @dagolden

    Extract PAUSE::pmfile

    dagolden authored
  43. @dagolden

    Fix test for skipping message

    dagolden authored
  44. @dagolden
  45. @dagolden

    Extracted PAUSE::package

    dagolden authored
  46. @rjbs

    convert mail-sending to use Email::Sender

    rjbs authored
    this means (a) we can use Email::MIME, so later ::Kit but for now,
    more importantly, it means that (b) we can *test* the mail we send
    trivially
  47. @dagolden
  48. @rjbs

    add new prereqs

    rjbs authored
Commits on Aug 15, 2011
  1. @dagolden

    Add DB_File to Makefile.PL

    dagolden authored
  2. @dagolden

    Remove need for sqlite3

    dagolden authored
    Uses DBIx::RunSQL instead to create tables for testing.
  3. @dagolden

    Fix $Id variable

    dagolden authored
    It used to be an SVN identifier.  This commit makes it a string
    based on PAUSE $VERSION instead.
Something went wrong with that request. Please try again.