Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many fixes #2

Merged
merged 7 commits into from Jul 12, 2019
Merged

Many fixes #2

merged 7 commits into from Jul 12, 2019

Conversation

@catfact
Copy link
Contributor

@catfact catfact commented Jul 12, 2019

  • no longer requires 2^N frames buffer
  • record offset initialized more correctly (doesn't glitch at non-integer write speeds), and can't be modulated (it's more dangerous than useful.)
  • silence output when play is disabled
  • clamp rate to +/- 32 so it doesn't crash Max
  • clamp SVF freq to 1/2 nyquist so it doesn't explode
  • update filter with per-sample rate change
  • fix filer modulation algo.

still TODO:

  • make a much nicer actual help patcher
  • phase output. dunno if this should be a second audio signal (unquantized, like groove~ sync), or a message outlet that bangs when quantized phase updates (like norns poll)
  • filter modulation helps with aliasing, but sweeping through zero rate (while writing) still causes rate spike that feels like a mistake (when playing back.) fix this with write-amplitude dead zone around rate==0.
  • soft clipper function returns -0 always. no idea why (it works on the norns and the math looks fine.) disabled for now.
@andr-ew andr-ew merged commit 31714a6 into andr-ew:master Jul 12, 2019
andr-ew added a commit that referenced this pull request Oct 12, 2019
use get_position to output phase in ms from outlet #2
andr-ew added a commit that referenced this pull request Jan 28, 2020
* works !

use get_position to output phase in ms from outlet #2

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants