From 39b06452e78fe6bd6bb5507fa1789715cc574a2a Mon Sep 17 00:00:00 2001 From: Arthur Assis Date: Tue, 16 Oct 2018 22:27:32 -0300 Subject: [PATCH 1/5] test: tests the angular/karma convention --- test/test_conventions.py | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/test/test_conventions.py b/test/test_conventions.py index e4c5640..244e803 100644 --- a/test/test_conventions.py +++ b/test/test_conventions.py @@ -1,12 +1,22 @@ -# import pytest -# import conventions.karma_angular as angular +import pytest +import conventions.karma_angular as angular # import conventions.changelog as changelog # import convention.symphony_cmf as symphony # import conventions.no_convention as no_convention -def test_angular_convention(): - pass +def test_angular_convention_with_context(): + message = angular.angular_convention('TAG','message','context') + + if not ('tag(context): message\n'): + raise AssertionError() + + +def test_angular_convention_without_context(): + message = angular.angular_convention('tag','message','') + + if not ('tag: message\n'): + raise AssertionError() def test_changelog_convention(): From af6c7d94b6f655b6c45920d7a66a3ae805007f6e Mon Sep 17 00:00:00 2001 From: Arthur Assis Date: Tue, 16 Oct 2018 22:44:04 -0300 Subject: [PATCH 2/5] test: tests changelog convention --- test/test_conventions.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/test/test_conventions.py b/test/test_conventions.py index 244e803..6d08a14 100644 --- a/test/test_conventions.py +++ b/test/test_conventions.py @@ -1,6 +1,6 @@ import pytest import conventions.karma_angular as angular -# import conventions.changelog as changelog +import conventions.changelog as changelog # import convention.symphony_cmf as symphony # import conventions.no_convention as no_convention @@ -20,7 +20,10 @@ def test_angular_convention_without_context(): def test_changelog_convention(): - pass + message = changelog.changelog_convention('tag','message') + + if not ('TAG: message\n'): + raise AssertionError() def test_symphony_convention(): From e7d5fc49608f5a8470bf3aa2f50f032c0724c8f3 Mon Sep 17 00:00:00 2001 From: Arthur Assis Date: Tue, 16 Oct 2018 22:56:24 -0300 Subject: [PATCH 3/5] test: tests symphony convention --- test/test_conventions.py | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/test/test_conventions.py b/test/test_conventions.py index 6d08a14..ea2594a 100644 --- a/test/test_conventions.py +++ b/test/test_conventions.py @@ -1,33 +1,36 @@ import pytest import conventions.karma_angular as angular import conventions.changelog as changelog -# import convention.symphony_cmf as symphony +import conventions.symphony_cmf as symphony # import conventions.no_convention as no_convention def test_angular_convention_with_context(): - message = angular.angular_convention('TAG','message','context') + message = angular.angular_convention('TAG', 'message', 'context') if not ('tag(context): message\n'): raise AssertionError() def test_angular_convention_without_context(): - message = angular.angular_convention('tag','message','') + message = angular.angular_convention('tag', 'message', '') if not ('tag: message\n'): raise AssertionError() def test_changelog_convention(): - message = changelog.changelog_convention('tag','message') + message = changelog.changelog_convention('tag', 'message') if not ('TAG: message\n'): raise AssertionError() def test_symphony_convention(): - pass + message = symphony.symphony_convention('tag', 'message') + + if not ('[Tag] message\n'): + raise AssertionError() def test_no_convention(): From d9310eca9afe059271d48c27c88a577a15a07801 Mon Sep 17 00:00:00 2001 From: Arthur Assis Date: Tue, 16 Oct 2018 23:07:06 -0300 Subject: [PATCH 4/5] test: tests just message convention --- test/test_conventions.py | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/test/test_conventions.py b/test/test_conventions.py index ea2594a..c3ad1c3 100644 --- a/test/test_conventions.py +++ b/test/test_conventions.py @@ -2,36 +2,46 @@ import conventions.karma_angular as angular import conventions.changelog as changelog import conventions.symphony_cmf as symphony -# import conventions.no_convention as no_convention +import conventions.no_convention as no_convention def test_angular_convention_with_context(): message = angular.angular_convention('TAG', 'message', 'context') if not ('tag(context): message\n'): - raise AssertionError() + raise AssertionError() def test_angular_convention_without_context(): message = angular.angular_convention('tag', 'message', '') if not ('tag: message\n'): - raise AssertionError() + raise AssertionError() def test_changelog_convention(): message = changelog.changelog_convention('tag', 'message') if not ('TAG: message\n'): - raise AssertionError() + raise AssertionError() def test_symphony_convention(): message = symphony.symphony_convention('tag', 'message') if not ('[Tag] message\n'): - raise AssertionError() + raise AssertionError() def test_no_convention(): - pass + inputs = [ + "message", + ] + + def mock_input(s): + return inputs.pop(0) + no_convention.input = mock_input + + message = no_convention.just_message() + if not message == 'Message\n': + raise AssertionError() From a0eb21c31d4b56e85ffcbc9459752920e0e64d60 Mon Sep 17 00:00:00 2001 From: Arthur Assis Date: Tue, 16 Oct 2018 23:20:36 -0300 Subject: [PATCH 5/5] fix(readme): fixes arthur assis username --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 11467dc..2d17b58 100644 --- a/README.md +++ b/README.md @@ -120,5 +120,5 @@ Supported conventions available: ## Our collaborators | **Name** | **Username** | | :------: | :----------: | -| Arthur José Benedito de Oliveira Assis | @arthur120496 | +| Arthur José Benedito de Oliveira Assis | @arthur0496 | | Matheus Richard T. Gomes | @MatheusRich |