Andreas Marschke andreas-marschke

@andreas-marschke

That's not something l18n-abide should do but your Router. Please refer to the documentation of your webapplication frameworks routing engine for t…

@andreas-marschke

Hi! I have a PR to run fail eslint on undocumented named functions it's here: #2980 If you'd like to have this issue resolved feel free to comment …

andreas-marschke commented on pull request eslint/eslint#2983
@andreas-marschke

Re-validating that my fix does what it's supposed to I've removed the tag.name check from the if-clause. This is the result from running Makefile.…

andreas-marschke commented on pull request eslint/eslint#2983
@andreas-marschke

running a it otherwise results in the described error from #2270 so it does happen here.

@andreas-marschke

Problem appears when tag.name hasn't been parsed by doctrine fix is in the PR #2983

andreas-marschke opened pull request eslint/eslint#2983
@andreas-marschke
Only add tag to the params object if tag.name is defined
1 commit with 17 additions and 1 deletion
@andreas-marschke

@mysticatea Didn't see that issue. I mostly opened this ticket to have a reference to the aforementioned PR. But yeah for the most part this should…

@andreas-marschke
Prevent undocumented functions with names
andreas-marschke commented on pull request eslint/eslint#2980
@andreas-marschke

Thanks for the link. My apologies for not honoring this. I only saw the CONTRIBUTING.md file and thought signing the code of conduct + runningMakef…

andreas-marschke opened pull request eslint/eslint#2980
@andreas-marschke
Add rule preventing undocumented functions with names
1 commit with 258 additions and 1 deletion
@andreas-marschke
@andreas-marschke
@andreas-marschke
@andreas-marschke
@andreas-marschke
@andreas-marschke
@andreas-marschke

Yeah noticed, that the deps are described lower down and were overlooked. I'll replace it with a reference to the section. Sounds good?

@andreas-marschke
@andreas-marschke
Add note for prerequisite library 's.el' in manual install instruction
1 commit with 1 addition and 0 deletions