Skip to content
This repository
Browse code

Fixed dependency to will_paginate, locked to 3.0.pre4 (newly released…

… 3.0.0 does not work yet with neo4j.rb)
  • Loading branch information...
commit fb86d975da1034fde3a3828b5f6e511f7460e09a 1 parent e9c4337
Andreas Ronge authored August 10, 2011

Showing 1 changed file with 3 additions and 2 deletions. Show diff stats Hide diff stats

  1. 5  neo4j.gemspec
5  neo4j.gemspec
@@ -17,7 +17,8 @@ Gem::Specification.new do |s|
17 17
   s.summary = "A graph database for JRuby"
18 18
   s.description = <<-EOF
19 19
 You can think of Neo4j as a high-performance graph engine with all the features of a mature and robust database.
20  
-The programmer works with an object-oriented, flexible network structure rather than with strict and static tables — yet enjoys all the benefits of a fully transactional, enterprise-strength database.
  20
+The programmer works with an object-oriented, flexible network structure rather than with strict and static tables 
  21
+yet enjoys all the benefits of a fully transactional, enterprise-strength database.
21 22
 It comes included with the Apache Lucene document database.
22 23
   EOF
23 24
 
@@ -30,6 +31,6 @@ It comes included with the Apache Lucene document database.
30 31
 
31 32
   s.add_dependency('orm_adapter', ">= 0.0.3")
32 33
   s.add_dependency("activemodel", ">= 3.0.0")
33  
-  s.add_dependency("will_paginate", ["~>3.0.pre"])
  34
+  s.add_dependency("will_paginate", ["3.0.pre4"])  # should be ~>3.0 but it's API has changed '
34 35
   s.add_dependency("railties", ">= 3.0.0")
35 36
 end

5 notes on commit fb86d97

Andrew

After updating to 1.1.3 I now get this error:
LoadError: no such file to load -- will_paginate/finders/base

I'm guessing that's related to this change? Should this change be backported to the 1.1.3 release?

Andrew

To answer my own question, yes, that did seem to be the problem. I hand-edited the gemspec in my gem dir and also edited my Gemfile.lock to point at 3.0.pre4 and that fixed my problem.

Andreas Ronge
Owner

It was not related to 1.1.3 release. I happend to release at the same time as the will_paginate was released.

Andrew

Gotcha. I guess my point is that 1.1.3 is currently broken as it stands with the will_paginate problem. While your followup commit fixes the breakage, there's no release tag to point to that contains that fix. What I probably should have said rather than "backport" was whether you'd cut a new release (1.1.3.1?) that contains the dependency change.

Andreas Ronge
Owner

I have released 1.1.4

Please sign in to comment.
Something went wrong with that request. Please try again.