Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox 70 disable this extension #19

Open
simonbcn opened this issue Nov 1, 2019 · 19 comments

Comments

@simonbcn
Copy link

@simonbcn simonbcn commented Nov 1, 2019

Firefox 70.0.1
Google Translate this page 2.3.1

Firefox disables this addon because: https://blocked.cdn.mozilla.net/11fd123a-e67d-44ab-909f-b776ea2e8d0a.html
Any workaround?

@Onurtag

This comment has been minimized.

Copy link

@Onurtag Onurtag commented Nov 2, 2019

Yeah that link tells the story.
https://bugzilla.mozilla.org/show_bug.cgi?id=1593243

A workaround is modifying the manifest.json and signing it yourself but why do we have to go that far for an addon that isn't on amo.

They killed every single translation addon that doesn't compromise to be on amo. They shouldn't have done this before releasing their own translation service.

@andreicristianpetcu

This comment has been minimized.

Copy link
Owner

@andreicristianpetcu andreicristianpetcu commented Nov 2, 2019

I had a few email exchanges with amo reviewers. It's sad that we cannot use this extension without hacks.

On the bright side there will be less malware shipped trough extensions. Believe me, there are lots of such cases. I will post more details about my interaction with them. It's not an ideal situation but I understand their point of view.

@nxtprogramer

This comment has been minimized.

Copy link

@nxtprogramer nxtprogramer commented Nov 2, 2019

:((

@haselwarter

This comment has been minimized.

Copy link

@haselwarter haselwarter commented Nov 3, 2019

This is kind of a big deal for a lot of people who need to regularly translate pages in Firefox. I have to switch to Chrome for these pages now. Is there an issue on foreign language support for Firefox anywhere?

@dessant

This comment has been minimized.

Copy link

@dessant dessant commented Nov 3, 2019

A workaround is modifying the manifest.json and signing it yourself but why do we have to go that far for an addon that isn't on amo.

That's not a solution, Mozilla does not allow you to run a perfectly safe extension such as Google Translate This in the release version of Firefox, even if it is not listed on Firefox Add-ons, and even if you sign it for personal use only. They still control a signed extension and will blocklist it the same way.

See also what happened with Page Translator: jeremiahlee/page-translator#26

@simonbcn

This comment has been minimized.

Copy link
Author

@simonbcn simonbcn commented Nov 3, 2019

I've changed to Page Translator Revised, it works very similar to this.

@grahamperrin

This comment has been minimized.

Copy link

@grahamperrin grahamperrin commented Nov 3, 2019

Nit: blocks such as this are not specific to Firefox.

The block is equally effective in Waterfox Classic, and so on.

… Is there an issue on foreign language support for Firefox anywhere?

The sad state of language translation in FirefoxFirefox is getting language translation and it's safer than Google Chrome's | Trusted Reviews

@dessant

This comment has been minimized.

Copy link

@dessant dessant commented Nov 3, 2019

@grahamperrin, is Waterfox planning to override the blocklist for these two extensions? I think not participating in this security theater would be a great differentiator for the Waterfox project.

@jscher2000

This comment has been minimized.

Copy link

@jscher2000 jscher2000 commented Nov 3, 2019

Userscript hosting extensions can still do what the content script needs to do. I think they cannot prevent that because there's no code review of userscripts. Therefore:

https://greasyfork.org/en/scripts/391935-inject-google-translate-widget

Edit: As noted in a later reply, some pages' CSP rules will prevent the remote script injection.

@grahamperrin

This comment has been minimized.

@grahamperrin

This comment has been minimized.

Copy link

@grahamperrin grahamperrin commented Nov 5, 2019

#19 (comment)

🥇

https://www.42.fr/ par exemple:

2019-11-05 06:11:38

2019-11-05 06:14:19

2019-11-05 06:15:10

Also tested with https://www.geekfaeries.fr/ et des autres.

@dessant

This comment has been minimized.

Copy link

@dessant dessant commented Nov 5, 2019

@grahamperrin, I agree that disabling blocklisting in the browser is a bad idea, I was asking if Waterfox maintainers would consider overriding the block for these two specific extensions, since they're safe to use, and offer a better user experience than an user script.

@sprite-1

This comment has been minimized.

Copy link

@sprite-1 sprite-1 commented Nov 5, 2019

@jscher2000 can you make it so that calling the function automatically loads the translation instead of having to do another click to translate?

@andreicristianpetcu

This comment has been minimized.

Copy link
Owner

@andreicristianpetcu andreicristianpetcu commented Nov 5, 2019

@jscher2000 The user script will not work on sites with CSP such as GitHub. You can try to disable CSP with this extension and then run the user script https://addons.mozilla.org/en-US/firefox/addon/laboratory-by-mozilla/

Disabling CSP for every site is NOT a good idea and this extension gives a bit more control. I did a lot of fancy stuff to inject new CSP rules in my extension.

@jscher2000

This comment has been minimized.

Copy link

@jscher2000 jscher2000 commented Nov 5, 2019

@jscher2000 can you make it so that calling the function automatically loads the translation instead of having to do another click to translate?

If you change autoDisplay: true to autoDisplay: false on line 21, it seems Google will translate automatically, but I haven't tested it much.

@jscher2000

This comment has been minimized.

Copy link

@jscher2000 jscher2000 commented Nov 5, 2019

@jscher2000 The user script will not work on sites with CSP such as GitHub. You can try to disable CSP with this extension and then run the user script https://addons.mozilla.org/en-US/firefox/addon/laboratory-by-mozilla/

Yes, this is a limitation, but the best approach to solving it is not clear. Users often have at least one extension modifying CSP (such as uBlock Origin) so it can be unpredictable adding a new one to the mix. Still not solved: https://bugzilla.mozilla.org/show_bug.cgi?id=1421725

@grahamperrin

This comment has been minimized.

Copy link

@grahamperrin grahamperrin commented Nov 5, 2019

@dessant I think, raise the Waterfox question in the Waterfox support area.

https://redd.it/dl42c9 will be ideal, do you have a Reddit account?

Defocusing from Waterfox …


… I think not participating in this security theater would be a great differentiator …

Any browser/project that begins selectively picking holes in a primary blocklist – setting the precedent for any number of future hole-picking dramas – might be perceived as engaging in theatrics.

Re: https://www.jeremiahlee.com/posts/page-translator-is-dead/ "… Nuance should not be dead. …" – true, but not everyone will appreciate nuances.

HTH

@ostrolucky

This comment has been minimized.

Copy link

@ostrolucky ostrolucky commented Nov 9, 2019

This extension can't be installed on Firefox developer edition either. Is there any instructions available how to install it in Firefox >= 70?

@11sideways

This comment has been minimized.

Copy link

@11sideways 11sideways commented Nov 10, 2019

checked - FF 52, 55, 56, 57, 58, 60, 65, 67, 68, 69 (and all other i think) blocks this extension after 5 minuts good works, altrough i started cleared FF and disable updates+sharing stats all times.
If somebody can... Please, tell me (us) step by step, how to disable checking addons, or any solution for make this addon works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.