Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: try to run shellcheck on pre-commit.ci #451

Merged
merged 2 commits into from
Jan 29, 2022
Merged

ci: try to run shellcheck on pre-commit.ci #451

merged 2 commits into from
Jan 29, 2022

Conversation

andreoliwa
Copy link
Owner

Proposed changes

  1. shellcheck has to be installed on pre-commit.ci; trying shellcheck-py to do this job

Checklist

  • Read the contribution guidelines
  • Run make locally before pushing commits
  • Add tests for the relevant parts:
    • API
    • CLI
    • flake8 plugin (normal mode)
    • flake8 plugin (offline mode)
  • Write documentation when there's a new API or functionality

@coveralls
Copy link

coveralls commented Jan 29, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1766238934

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.025%
Totals Coverage Status
Change from base Build 1766198585: 0.0%
Covered Lines: 2052
Relevant Lines: 2098
💛 - Coveralls

@andreoliwa andreoliwa marked this pull request as ready for review January 29, 2022 16:10
@andreoliwa andreoliwa merged commit 19ad1fb into develop Jan 29, 2022
@andreoliwa andreoliwa deleted the try-shellcheck-py branch January 29, 2022 16:23
@github-actions
Copy link

🎉 This PR is included in version 0.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Feature/fix is released label Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released Feature/fix is released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreoliwa @coveralls