New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't touch card numbers #2

Closed
denysdovhan opened this Issue Nov 18, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@denysdovhan
Copy link

denysdovhan commented Nov 18, 2015

I have a trouble with your package, because it touches card numbers.

If I have text with any card number, I'll get:

numbers("Card: 5441 1686 1100 5540"); // => Card: 5,441 1,686 1,100 5,540
numbers("Card: 5441168611005540"); // => Card: 5,441,168,611,005,540

Can you fix this? You could use credit-card-regex for matching credit card numbers, for example.

@andrepolischuk

This comment has been minimized.

Copy link
Owner

andrepolischuk commented Nov 18, 2015

I can fix, but I don't understand how to resolve 5441168611005540 as not-card number. What do you think about this?

@denysdovhan

This comment has been minimized.

Copy link

denysdovhan commented Nov 18, 2015

maybe better to recognize 5441168611005540 as number and 5441 1686 1100 5540 as credit card?

@denysdovhan

This comment has been minimized.

Copy link

denysdovhan commented Nov 21, 2015

👍

@andrepolischuk

This comment has been minimized.

Copy link
Owner

andrepolischuk commented Nov 21, 2015

Patched version is published to npm

@denysdovhan

This comment has been minimized.

Copy link

denysdovhan commented Nov 21, 2015

oh, nice work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment