New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work inside a display: none !important container #188

Merged
merged 1 commit into from Nov 29, 2015

Conversation

Projects
None yet
2 participants
@gwarnants
Contributor

gwarnants commented Nov 26, 2015

Rangeslider doesn't work if it is initialized inside a hidden container where display: none has been forced with an !important declaration. This way to hide elements is used by Bootstrap, HTML5 Boilerplate, ...

.hidden {
  display: none !important;
}
<div class="hidden">
  <input type="range" />
</div>

This is because hiddenParentNodes[i].style.display = 'block' doesn't override class level important style. My fix correct this problem.

Doesn't work inside a display: none !important container
Rangeslider doesn't work if it is initialized inside a hidden container where display: none has been forced with an **!important** declaration. This way to hide elements is used by Bootstrap, HTML5 Boilerplate, ...

```css
.hidden {
  display: none !important;
}
```
```html
<div class="hidden"">
  <input type="range" />
</div>
```
This is because hiddenParentNodes[i].style.display = 'block' doesn't override important style. My fix correct this problem.

andreruffert added a commit that referenced this pull request Nov 29, 2015

Merge pull request #188 from gwarnants/patch-1
Doesn't work inside a display: none !important container

@andreruffert andreruffert merged commit 6f558ee into andreruffert:develop Nov 29, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@andreruffert

This comment has been minimized.

Show comment
Hide comment
@andreruffert

andreruffert Nov 29, 2015

Owner

@gwarnants thanks! 😊✌️

Owner

andreruffert commented Nov 29, 2015

@gwarnants thanks! 😊✌️

@andreruffert andreruffert added this to the Release v2.0.5 milestone Nov 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment