This repository has been archived by the owner on May 30, 2024. It is now read-only.
fix: floating point rounding issue #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `getValueFromPosition` value calculation. The `+ this.min` needs to be outside, otherwise it gets the wrong answer unless `this.min` is divisible by this.step. Big ups to @jpmckinney Closes issue #50, #91
andreruffert
added a commit
that referenced
this pull request
Sep 28, 2014
…issue fix: floation point rounding issue
andreruffert
changed the title
This was referenced Sep 28, 2014
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
getValueFromPositionvalue calculation.The
+ this.minneeds to be outside, otherwise it gets the wronganswer unless
this.minis divisible by this.step.Big ups to @jpmckinney
Closes issue #50, #91