Make en_short consistent with other sites - #128
Merged
Merged
Conversation
This applies three changes to en_short: 1. Removes spaces between numbers and units, so that "1 h" becomes "1h" 2. Shortens "min" to "m", so that "1 min" becomes "1m" (month remains as "mo") 2. Shortens "yr" to "y", so that "1 yr" becomes "1y" I made these changes because this is what I've witnessed to be the standard on the rest of internet. This format is used by Facebook, Twitter, LinkedIn, Venmo, and others. Feel free to reject some or all changes if this doesn't match with the direction you want, I'll be happy to revert individual parts.
Collaborator
|
@andresaraujo I agree with this. What do you think? This is a breaking change, then we could add this feature in the null-safety version. |
Owner
|
Yeah I think this makes sense as default for the short version |
Owner
|
Agree on making this change into the null safe version as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This applies three changes to en_short:
I made these changes because this is what I've witnessed to be the standard on the rest of internet:
Facebook:
Twitter:
LinkedIn:
Venmo:
Feel free to reject some or all changes if this doesn't match with the direction you want, I'll be happy to revert individual parts.