New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for JS bug bash feedback #12

Merged
merged 2 commits into from Sep 14, 2018

Conversation

Projects
None yet
3 participants
@navyasric
Collaborator

navyasric commented Sep 14, 2018

  • Made http and port consistent on Redirect URIs
  • Added details for downloading and extracting project to short dir name
  • Added step to run the project
  • Updated Library version in reference
  • Added details on authority, scopes in more info.
Updates for bug bash feedback
- Made http and port consistent on Redirect URIs
- Added details for downloading and extracting project to short dir name
- Added step to run the project
- Updated Library version in reference
- Added details on authority, scopes in more info.

@navyasric navyasric requested review from jmprieur and andretms Sep 14, 2018

@navyasric

This comment has been minimized.

Show comment
Hide comment
@navyasric

navyasric Sep 14, 2018

Collaborator

@andretms @jmprieur Please review the updates in doc content.

Collaborator

navyasric commented Sep 14, 2018

@andretms @jmprieur Please review the updates in doc content.

@andretms

This comment has been minimized.

Show comment
Hide comment
@andretms

andretms Sep 14, 2018

Owner

Validation status: passed

File Status Preview URL Details
articles/active-directory/develop/quickstarts/active-directory-javascriptspa.md Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Owner

andretms commented Sep 14, 2018

Validation status: passed

File Status Preview URL Details
articles/active-directory/develop/quickstarts/active-directory-javascriptspa.md Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@navyasric navyasric changed the title from Updates for bug bash feedback to Updates for JS bug bash feedback Sep 14, 2018

@jmprieur

@navyasric : this looks very good !

@andretms

This comment has been minimized.

Show comment
Hide comment
@andretms

andretms Sep 14, 2018

Owner

Validation status: passed

File Status Preview URL Details
articles/active-directory/develop/quickstarts/active-directory-javascriptspa.md Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Owner

andretms commented Sep 14, 2018

Validation status: passed

File Status Preview URL Details
articles/active-directory/develop/quickstarts/active-directory-javascriptspa.md Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@navyasric navyasric merged commit 751299f into master Sep 14, 2018

1 check passed

OpenPublishing.Build Validation status: passed
Details

@navyasric navyasric deleted the nc_spa_quickstart branch Sep 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment