Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
What to do about melpa? #9
Looking at the commit log, @xhcoding started his package on November 23 with code from my blog post. (I just noticed his readme does link back to my blog post, quite prominently. :)
Anyways, @andrew-christianson started this package on November 27, a few days later. We did not see that there already was a package, else we could have joined forces.
The most logical thing to do would be to compare functionality, and ensure that the union of the two packages is on melpa so that Emacs users get the best solution available. If @xhcoding is a responsive maintainer, I'm sure that should not be a problem.
The ms-python package on melpa appears to be windows-only (based on a quick scan of the source, there seems to be a hard-coded dll expectation), whereas this also works on linux (and I'd imagine probably OSx too?).
Kudos on spotting/fixing the filter / nil string bug quickly by the way -- I was just about to submit a PR :)
Sounds good to me!
@xhcoding no need to apologize! I'll look through ms-python to flag anything we should merge here, and happily accept any PRs from you for those or other enhancements.
I'll also PR this to MELPA, under the current package name, if that works for everyone, as it's already linked as such from the lsp-mode README, and from @cormacc's Spacemacs PR as such.
@cpbotha I neglected to include a LICENSE when I created this repo, as I didn't see if you explicitly released (any/every)thing on your blog under a specific license. Are you ok with releasing this under GPL?