Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link gh issues to v1 part 2 #9

Merged
merged 10 commits into from Mar 3, 2019

Conversation

Projects
None yet
1 participant
@andrew-codes
Copy link
Owner

andrew-codes commented Mar 2, 2019

No description provided.

andrew-codes added some commits Mar 2, 2019

story/defect labeled issues => Story/Defect asset in v1
- creating an issue labeled with proper story/defect mapping will create correct asset in V1; wil also tag the asset with the github Identifier, and link back to the github issue.
- will label the gh issue with the asset's oid token
- broken validation of options into a separate package; many plugins could find this useful; named @andrew-codes/webhooked-utils
test implemented for created assets in V1 to gh issue- test for creat…
…ed stories are implemented, but do not pass- tests for created defects are not implemented and would not pass (no implementation)make all tests pass

@andrew-codes andrew-codes force-pushed the 2-link-gh-issues-to-v1-part-2 branch from 103220f to 1991ba3 Mar 3, 2019

andrew-codes added some commits Mar 3, 2019

rename to issue sync
It makes sense for this package to handle issue syncing and not just issue creation, so a rename is in order
implement v1 request matcher
Not 100% sure the header for the hmac signature is on the key `x-v1-signature`.
bi-directional sync tests passing
Created a new package for matching V1 webhook requests. Also change implementation to verify via a hmac signature instead of a header/body property value.
@andrew-codes

This comment has been minimized.

Copy link
Owner Author

andrew-codes commented Mar 3, 2019

Closes #2

fix lint errors; ignore linting in tests
ignoring linting on tests. either need to ignore them on tests or configure linting tests differently as some requires are not publishable (dev dependencies) which fails a lint rule.

@andrew-codes andrew-codes merged commit a09e1e7 into master Mar 3, 2019

2 checks passed

Verify/Linting Passed
Verify/Testing 1 passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.