Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weights/Percentages Not Sticking #267

Closed
danielschwartz opened this issue Sep 26, 2014 · 5 comments
Closed

Weights/Percentages Not Sticking #267

danielschwartz opened this issue Sep 26, 2014 · 5 comments

Comments

@danielschwartz
Copy link
Contributor

When set in the configuration file like so:

"20140923_product_reviews" => { :alternatives => [{'hide' => 0.75}, {'show' => 0.25}] }

The experiment will still be weighted 1:1. On initialization of alternative the correct weight is being set, but somehow after the fact it is being reset to a weight a 1. I confirmed this by doing the following:

Added a binding.pry to the bottom of the initialization method of the Alternative class and saw that @weight was correctly set. However, after initialization, when looking up the experiment like so: Split::ExperimentCatalog.find("20140923_product_reviews") the weights are set back to 1 for both alternatives.

We're on Split 0.7.2

@andrew
Copy link
Member

andrew commented Oct 4, 2014

@danielschwartz do you think you'd be able to write a failing test for this?

@danielschwartz
Copy link
Contributor Author

Yup, will probably get to it at some point this week.

@Coedcoe
Copy link

Coedcoe commented Aug 10, 2015

@andrew @danielschwartz I seem to be having similar issues where the weights aren't sticking, they keep defaulting back to 1:1 . Was this issue ever resolved?

@andrew
Copy link
Member

andrew commented Jul 17, 2016

Closing as this issue it's nearly 2 years old, please reopen if it's still affecting you.

@andrew andrew closed this as completed Jul 17, 2016
@neyp
Copy link

neyp commented Apr 18, 2018

This is still happening on the latest version. I ended up creating #521.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants