New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace EmptyLogger with SimpleLogger for #28 #33

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@openstrike

openstrike commented Mar 29, 2015

The new class Business::CPI::Util::SimpleLogger replaces the old Business::CPI::Util::EmptyLogger and includes some trivial methods for logging which act as a fallback in the absence of a more fully-featured user-provided logger such as Log::Log4Perl. The only significant difference is that SimpleLogger has a fatal() method which actually dies. If this is retained it would probably be advisable to have an explicit die immediately after calling fatal() in case it is over-ridden by a non-terminating method. eg:

die $log->fatal('Too many jabberwocks!');

There are some additional tests for these new logging methods as well.

Replace EmptyLogger with SimpleLogger for #28
Additional tests for logging
@openstrike

This comment has been minimized.

openstrike commented Jan 6, 2017

Are there any further changes you require to this PR prior to merging, Andre? Any feedback which you could provide would be most welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment